Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4927)

Unified Diff: chrome/test/data/webui/md_history/history_metrics_test.js

Issue 2643533003: MD History: Use one-way binding for history query state. (Closed)
Patch Set: Remove wrapper function Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/md_history/history_metrics_test.js
diff --git a/chrome/test/data/webui/md_history/history_metrics_test.js b/chrome/test/data/webui/md_history/history_metrics_test.js
index a708454b026dc3e3e3ad3298b2e784dd47830f20..c065ac10f90b5eadc0b8644016fda6a077c7f2f1 100644
--- a/chrome/test/data/webui/md_history/history_metrics_test.js
+++ b/chrome/test/data/webui/md_history/history_metrics_test.js
@@ -76,9 +76,9 @@ suite('Metrics', function() {
assertEquals(1, histogram[HistoryPageViewHistogram.SYNCED_TABS]);
app.selectedPage_ = 'history';
assertEquals(2, histogram[HistoryPageViewHistogram.HISTORY]);
- app.set('queryState_.range', HistoryRange.WEEK);
+ app.fire('change-query', {range: HistoryRange.WEEK});
assertEquals(1, histogram[HistoryPageViewHistogram.GROUPED_WEEK]);
- app.set('queryState_.range', HistoryRange.MONTH);
+ app.fire('change-query', {range: HistoryRange.MONTH});
assertEquals(1, histogram[HistoryPageViewHistogram.GROUPED_MONTH]);
});
});
@@ -102,7 +102,7 @@ suite('Metrics', function() {
assertEquals(1, histogramMap['HistoryPage.ClickPosition'][1]);
assertEquals(1, histogramMap['HistoryPage.ClickPositionSubset'][1]);
- app.set('queryState_.searchTerm', 'goog');
+ app.fire('change-query', {search: 'goog'});
assertEquals(1, actionMap['Search']);
app.set('queryState_.incremental', true);
app.historyResult(createHistoryInfo('goog'), [
« no previous file with comments | « chrome/test/data/webui/md_history/history_list_test.js ('k') | chrome/test/data/webui/md_history/history_routing_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698