Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issue 2643493002: Added -[Tab webState:didCommitNavigationWithDetails:]. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added -[Tab webState:didCommitNavigationWithDetails:]. Moved most of -[Tab webDidStartLoadingURL:shouldUpdateHistory:] to this new method. |didCommitNavigationWithDetails:| is called right before |webDidStartLoadingURL:shouldUpdateHistory:|, so this CL should not change the logic. |webDidStartLoadingURL:shouldUpdateHistory:| is a part of deprecated CRWWebDelegate and should be fully removed in a separate CL. BUG=674991 Review-Url: https://codereview.chromium.org/2643493002 Cr-Commit-Position: refs/heads/master@{#444381} Committed: https://chromium.googlesource.com/chromium/src/+/4f2c57e57018d7c3b19c877171a062fd1508a0f6

Patch Set 1 #

Patch Set 2 : Removed self.webController usage #

Patch Set 3 : Cleaned up tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -20 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 1 2 chunks +13 lines, -15 lines 0 comments Download
M ios/chrome/browser/tabs/tab_unittest.mm View 1 2 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-18 00:23:25 UTC) #10
marq (ping after 24h)
lgtm
3 years, 11 months ago (2017-01-18 10:04:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643493002/40001
3 years, 11 months ago (2017-01-18 16:11:34 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 16:16:18 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4f2c57e57018d7c3b19c877171a0...

Powered by Google App Engine
This is Rietveld 408576698