Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: ios/chrome/browser/tabs/tab_unittest.mm

Issue 2643493002: Added -[Tab webState:didCommitNavigationWithDetails:]. (Closed)
Patch Set: Cleaned up tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_unittest.mm
diff --git a/ios/chrome/browser/tabs/tab_unittest.mm b/ios/chrome/browser/tabs/tab_unittest.mm
index 0b10e803e01f76258024cd172edd25bbfa96aa27..9f72c6012fe874c6ce0854a5c0228244c8c5e2ea 100644
--- a/ios/chrome/browser/tabs/tab_unittest.mm
+++ b/ios/chrome/browser/tabs/tab_unittest.mm
@@ -115,7 +115,6 @@ typedef BOOL (^openURLBlockType)(const GURL&, BOOL);
namespace {
-const web::LoadPhase kLoadRequested = web::LOAD_REQUESTED;
const web::LoadPhase kPageLoading = web::PAGE_LOADING;
const web::LoadPhase kPageLoaded = web::PAGE_LOADED;
@@ -229,8 +228,6 @@ class TabTest : public BlockCleanupTest {
}
void BrowseTo(const GURL& userUrl, const GURL& redirectUrl, NSString* title) {
- [[[(id)mock_web_controller_ expect]
- andReturnValue:OCMOCK_VALUE(kLoadRequested)] loadPhase];
web::Referrer empty_referrer;
[tab_ webWillAddPendingURL:userUrl transition:ui::PAGE_TRANSITION_TYPED];
[tab_ webStateImpl]->OnProvisionalNavigationStarted(userUrl);
@@ -242,8 +239,6 @@ class TabTest : public BlockCleanupTest {
transition:ui::PAGE_TRANSITION_CLIENT_REDIRECT
rendererInitiated:YES];
[tab_ webStateImpl]->OnProvisionalNavigationStarted(redirectUrl);
- [[[(id)mock_web_controller_ expect]
- andReturnValue:OCMOCK_VALUE(kPageLoading)] loadPhase];
[[tab_ navigationManager]->GetSessionController() commitPendingEntry];
[[tab_ webController] webStateImpl]->OnNavigationCommitted(redirectUrl);
[tab_ webDidStartLoadingURL:redirectUrl shouldUpdateHistory:YES];
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698