Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2643393004: Revert of [build] Introduce an embedder version string (Closed)

Created:
3 years, 11 months ago by Michael Hablich
Modified:
3 years, 11 months ago
Reviewers:
targos, ofrobots, hablich, Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [build] Introduce an embedder version string (patchset #3 id:40001 of https://codereview.chromium.org/2619213002/ ) Reason for revert: Blocks roll https://codereview.chromium.org/2647183002/ Original issue's description: > [build] Introduce an embedder version string > > Sometimes, the embedder might want to merge a fix to an abandoned branch > or to a supported branch but the fix is not relevant to Chromium. > This adds a new version string that the embedder can set on compile time > and that will be appended to the official V8 version. > The separator must be provided in the string. For instance, to have a > full version string like "5.5.372.37.custom.1", the embedder must set > V8_EMBEDDER_STRING to ".custom.1". > > Related Node.js issue: https://github.com/nodejs/node/pull/9754 > > BUG=v8:5740 > R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng > > Review-Url: https://codereview.chromium.org/2619213002 > Cr-Original-Commit-Position: refs/heads/master@{#42175} > Committed: https://chromium.googlesource.com/v8/v8/+/fc86d4329b253bf21c1dd85469f1ef4b6e5ba01a > Review-Url: https://codereview.chromium.org/2619213002 > Cr-Commit-Position: refs/heads/master@{#42582} > Committed: https://chromium.googlesource.com/v8/v8/+/2c1d1e60883882011ed50310a9b09e95dc61234a TBR=hablich@chromium.com,machenbach@chromium.org,ofrobots@google.com,mic.besace@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5740 Review-Url: https://codereview.chromium.org/2643393004 Cr-Commit-Position: refs/heads/master@{#42583} Committed: https://chromium.googlesource.com/v8/v8/+/d840ed11d9fa9f38676e6edcee93ed749afb284d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -77 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -7 lines 0 comments Download
M gypfiles/features.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M include/v8-version.h View 1 chunk +0 lines, -4 lines 0 comments Download
M include/v8-version-string.h View 1 chunk +1 line, -1 line 0 comments Download
M src/log-utils.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M src/version.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/version.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-version.cc View 4 chunks +31 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Hablich
Created Revert of [build] Introduce an embedder version string
3 years, 11 months ago (2017-01-21 22:36:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643393004/1
3 years, 11 months ago (2017-01-21 22:36:47 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 22:37:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d840ed11d9fa9f38676e6edcee93ed749af...

Powered by Google App Engine
This is Rietveld 408576698