[build] Introduce an embedder version string

[build] Introduce an embedder version string

Sometimes, the embedder might want to merge a fix to an abandoned branch
or to a supported branch but the fix is not relevant to Chromium.
This adds a new version string that the embedder can set on compile time
and that will be appended to the official V8 version.
The separator must be provided in the string. For instance, to have a
full version string like "5.5.372.37.custom.1", the embedder must set
V8_EMBEDDER_STRING to ".custom.1".

Related Node.js issue: https://github.com/nodejs/node/pull/9754

BUG=v8:5740
R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng

Review-Url: https://codereview.chromium.org/2619213002
Cr-Original-Commit-Position: refs/heads/master@{#42175}
Committed: https://chromium.googlesource.com/v8/v8/+/fc86d4329b253bf21c1dd85469f1ef4b6e5ba01a
Review-Url: https://codereview.chromium.org/2619213002
Cr-Commit-Position: refs/heads/master@{#42582}
Committed: https://chromium.googlesource.com/v8/v8/+/2c1d1e60883882011ed50310a9b09e95dc61234a

[Michael Achenbach, 2017-01-09 12:15:09]

lgtm - maybe add to the CL description how this is supposed to look like, e.g.
mention that the embedder must add a dot to the string if there should be a dot.
To avoid things like embedder_version="1" added to 1.2.3.4 and looking like
1.2.3.41

[targos, 2017-01-09 13:30:19]

Description was changed from

==========
[build] Introduce an embedder version string

Sometimes, the embedder might want to merge a fix to an abandoned branch
or to a supported branch but the fix is not relevant to Chromium.
This adds a new version string that the embedder can set on compile time
and that will be appended to the official V8 version.

Related Node.js issue: https://github.com/nodejs/node/pull/9754

BUG=v8:5740
R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com
==========

to

==========
[build] Introduce an embedder version string

Sometimes, the embedder might want to merge a fix to an abandoned branch
or to a supported branch but the fix is not relevant to Chromium.
This adds a new version string that the embedder can set on compile time
and that will be appended to the official V8 version.
The separator must be provided in the string. For instance, to have a
full version string like "5.5.372.37.custom.1", the embedder must set
V8_EMBEDDER_STRING to ".custom.1".

Related Node.js issue: https://github.com/nodejs/node/pull/9754

BUG=v8:5740
R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com
==========

[targos, 2017-01-10 07:34:29]

To answer https://bugs.chromium.org/p/v8/issues/detail?id=5740#c9

> Do we also want to display this number in D8?

The suffix is displayed in D8 as part of the "V8 version ..." line but only for
releases because I didn't append the string if there is no patch level.
I thought it would be confusing, considering the embedder string ".5" to jump
for example from 5.5.372.5 to 5.5.372.1.5.

[Michael Achenbach, 2017-01-10 07:51:40]

On 2017/01/10 07:34:29, targos wrote:
> To answer https://bugs.chromium.org/p/v8/issues/detail?id=5740#c9
> 
> > Do we also want to display this number in D8?
> 
> The suffix is displayed in D8 as part of the "V8 version ..." line but only
for
> releases because I didn't append the string if there is no patch level.
> I thought it would be confusing, considering the embedder string ".5" to jump
> for example from 5.5.372.5 to 5.5.372.1.5.

fine with me

[Michael Achenbach, 2017-01-10 07:53:31]

On 2017/01/10 07:51:40, Michael Achenbach wrote:
> On 2017/01/10 07:34:29, targos wrote:
> > To answer https://bugs.chromium.org/p/v8/issues/detail?id=5740#c9
> > 
> > > Do we also want to display this number in D8?
> > 
> > The suffix is displayed in D8 as part of the "V8 version ..." line but only
> for
> > releases because I didn't append the string if there is no patch level.
> > I thought it would be confusing, considering the embedder string ".5" to
jump
> > for example from 5.5.372.5 to 5.5.372.1.5.
> 
> fine with me

As a consequence, I think the v8-node integration bot will not show the embedder
string in its builds, as it is based on V8 HEAD. But I think this is fine.

[targos, 2017-01-10 08:18:47]

The CQ bit was checked by mic.besace@gmail.com

[commit-bot: I haz the power, 2017-01-10 08:18:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 08:36:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 08:36:45]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[targos, 2017-01-10 09:14:01]

https://codereview.chromium.org/2619213002/diff/1/src/version.cc
File src/version.cc (right):

https://codereview.chromium.org/2619213002/diff/1/src/version.cc#newcode28
src/version.cc:28: V8_EMBEDDER_STRING CANDIDATE_STRING
I forgot the S(), sorry. Running the tests locally

[targos, 2017-01-10 12:04:52]

The CQ bit was checked by mic.besace@gmail.com

[targos, 2017-01-10 12:04:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2619213002/#ps20001
(title: "fix tests")

[commit-bot: I haz the power, 2017-01-10 12:05:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[targos, 2017-01-10 12:16:40]

Actually it was test-version.cc that contained changes based on an different
implementation. It is fixed now.

[commit-bot: I haz the power, 2017-01-10 12:34:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484049892387420,
"parent_rev": "8f1353256f5cd814e490194a52862ff0bad4e83e", "commit_rev":
"fc86d4329b253bf21c1dd85469f1ef4b6e5ba01a"}

[commit-bot: I haz the power, 2017-01-10 12:34:15]

Description was changed from

==========
[build] Introduce an embedder version string

Sometimes, the embedder might want to merge a fix to an abandoned branch
or to a supported branch but the fix is not relevant to Chromium.
This adds a new version string that the embedder can set on compile time
and that will be appended to the official V8 version.
The separator must be provided in the string. For instance, to have a
full version string like "5.5.372.37.custom.1", the embedder must set
V8_EMBEDDER_STRING to ".custom.1".

Related Node.js issue: https://github.com/nodejs/node/pull/9754

BUG=v8:5740
R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com
==========

to

==========
[build] Introduce an embedder version string

Sometimes, the embedder might want to merge a fix to an abandoned branch
or to a supported branch but the fix is not relevant to Chromium.
This adds a new version string that the embedder can set on compile time
and that will be appended to the official V8 version.
The separator must be provided in the string. For instance, to have a
full version string like "5.5.372.37.custom.1", the embedder must set
V8_EMBEDDER_STRING to ".custom.1".

Related Node.js issue: https://github.com/nodejs/node/pull/9754

BUG=v8:5740
R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com

Review-Url: https://codereview.chromium.org/2619213002
Cr-Commit-Position: refs/heads/master@{#42175}
Committed:
https://chromium.googlesource.com/v8/v8/+/fc86d4329b253bf21c1dd85469f1ef4b6e5...
==========

[commit-bot: I haz the power, 2017-01-10 12:34:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/fc86d4329b253bf21c1dd85469f1ef4b6e5...

[Michael Hablich, 2017-01-10 15:21:16]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2621033002/ by hablich@chromium.org.

The reason for reverting is: Seems to break the Chromium build:
https://codereview.chromium.org/2619193005/

Message:

[1832/9671] CXX obj/v8/v8_base/version.o
FAILED: obj/v8/v8_base/version.o 
/b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++
-MMD -MF obj/v8/v8_base/version.o.d -DV8_DEPRECATION_WARNINGS
-DDCHECK_ALWAYS_ON=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1
-DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1
-DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
-DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1
-DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=289944-2 -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNDEBUG -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0 -DV8_I18N_SUPPORT -DENABLE_HANDLE_ZAPPING
-DV8_USE_EXTERNAL_STARTUP_DATA -DV8_TARGET_ARCH_X64 -DDEBUG
-DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION
-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. -Igen -I../../v8
-I../../v8/include -I../../third_party/icu/source/common
-I../../third_party/icu/source/i18n -fno-strict-aliasing
--param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe
-B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics
-fdebug-prefix-map=/b/c/b/linux/src=. -m64 -march=x86-64 -pthread -g1
--sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden
-Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs
-Xclang check-ipc -Wheader-hygiene -Wstring-conversion
-Wtautological-overlap-compare -Werror -Wall -Wno-unused-variable
-Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing
-Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-undefined-var-template
-Wno-nonportable-include-path -Wno-address-of-packed-member -Wsign-compare
-Winconsistent-missing-override -Wshorten-64-to-32 -O3 -fno-ident
-fdata-sections -ffunction-sections -fno-threadsafe-statics
-fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions
-Wno-deprecated -c ../../v8/src/version.cc -o obj/v8/v8_base/version.o
../../v8/src/version.cc:42:34: error: use of undeclared identifier
'V8_EMBEDDER_STRING'
const char* Version::embedder_ = V8_EMBEDDER_STRING;
                                 ^
1 error generated.

.

[targos, 2017-01-11 14:08:27]

I tried to add a try bot from https://codereview.chromium.org/2619193005/
(linux_chromium_rel_ng) but I think I don't have the rights to do it, because
the request fails with:

Unhandled exception.
Details: Failed to call
https://cr-buildbucket.appspot.com/api/buildbucket/v1/builds/batch: HTTP 403
[AuthError]

[Michael Achenbach, 2017-01-11 14:13:32]

On 2017/01/11 14:08:27, targos wrote:
> I tried to add a try bot from https://codereview.chromium.org/2619193005/
> (linux_chromium_rel_ng) but I think I don't have the rights to do it, because
> the request fails with:
> 
> Unhandled exception.
> Details: Failed to call
> https://cr-buildbucket.appspot.com/api/buildbucket/v1/builds/batch: HTTP 403
> [AuthError]

Hmm, do you have chromium trybot access? Otherwise, can you try adding it like
in the CL description of the roll with CQ_INCLUDE_TRYBOTS=... to this CL
description and then make a dry run?

[targos, 2017-01-11 15:00:48]

Description was changed from

==========
[build] Introduce an embedder version string

Sometimes, the embedder might want to merge a fix to an abandoned branch
or to a supported branch but the fix is not relevant to Chromium.
This adds a new version string that the embedder can set on compile time
and that will be appended to the official V8 version.
The separator must be provided in the string. For instance, to have a
full version string like "5.5.372.37.custom.1", the embedder must set
V8_EMBEDDER_STRING to ".custom.1".

Related Node.js issue: https://github.com/nodejs/node/pull/9754

BUG=v8:5740
R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com

Review-Url: https://codereview.chromium.org/2619213002
Cr-Commit-Position: refs/heads/master@{#42175}
Committed:
https://chromium.googlesource.com/v8/v8/+/fc86d4329b253bf21c1dd85469f1ef4b6e5...
==========

to

==========
[build] Introduce an embedder version string

Sometimes, the embedder might want to merge a fix to an abandoned branch
or to a supported branch but the fix is not relevant to Chromium.
This adds a new version string that the embedder can set on compile time
and that will be appended to the official V8 version.
The separator must be provided in the string. For instance, to have a
full version string like "5.5.372.37.custom.1", the embedder must set
V8_EMBEDDER_STRING to ".custom.1".

Related Node.js issue: https://github.com/nodejs/node/pull/9754

BUG=v8:5740
R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng

Review-Url: https://codereview.chromium.org/2619213002
Cr-Commit-Position: refs/heads/master@{#42175}
Committed:
https://chromium.googlesource.com/v8/v8/+/fc86d4329b253bf21c1dd85469f1ef4b6e5...
==========

[targos, 2017-01-11 15:01:00]

The CQ bit was checked by mic.besace@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 15:01:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 16:29:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 16:29:35]

Dry run: This issue passed the CQ dry run.

[targos, 2017-01-13 13:56:47]

On 2017/01/11 at 14:13:32, machenbach wrote:
> On 2017/01/11 14:08:27, targos wrote:
> > I tried to add a try bot from https://codereview.chromium.org/2619193005/
> > (linux_chromium_rel_ng) but I think I don't have the rights to do it,
because
> > the request fails with:
> > 
> > Unhandled exception.
> > Details: Failed to call
> > https://cr-buildbucket.appspot.com/api/buildbucket/v1/builds/batch: HTTP 403
> > [AuthError]
> 
> Hmm, do you have chromium trybot access? Otherwise, can you try adding it like
in the CL description of the roll with CQ_INCLUDE_TRYBOTS=... to this CL
description and then make a dry run?

linux_chromium_rel_ng in green from here.

[Michael Achenbach, 2017-01-13 14:43:56]

On 2017/01/13 13:56:47, targos wrote:
> On 2017/01/11 at 14:13:32, machenbach wrote:
> > On 2017/01/11 14:08:27, targos wrote:
> > > I tried to add a try bot from https://codereview.chromium.org/2619193005/
> > > (linux_chromium_rel_ng) but I think I don't have the rights to do it,
> because
> > > the request fails with:
> > > 
> > > Unhandled exception.
> > > Details: Failed to call
> > > https://cr-buildbucket.appspot.com/api/buildbucket/v1/builds/batch: HTTP
403
> > > [AuthError]
> > 
> > Hmm, do you have chromium trybot access? Otherwise, can you try adding it
like
> in the CL description of the roll with CQ_INCLUDE_TRYBOTS=... to this CL
> description and then make a dry run?
> 
> linux_chromium_rel_ng in green from here.

Well, did anything change? Nothing in this CL as I can see. Is it because of
scott's changes that landed in the meantime?
https://chromium.googlesource.com/v8/v8/+/ffc0931f879b5aeb48490d1ff34f710b454...

Otherwise, I'd be a bit alerted why the trybot is not giving the right signal.
If Scott's CL changed things in the meantime, please just reland and we see.
Please also notify hablich@ if there's the potential that we block the roll
again...

[targos, 2017-01-21 17:22:59]

The CQ bit was checked by mic.besace@gmail.com

[targos, 2017-01-21 17:23:00]

Rebased

[targos, 2017-01-21 17:23:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2619213002/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2017-01-21 17:23:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 19:04:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485019379656790,
"parent_rev": "72e8a978155394b0c67b07404f5241594f42c906", "commit_rev":
"2c1d1e60883882011ed50310a9b09e95dc61234a"}

[commit-bot: I haz the power, 2017-01-21 19:04:31]

Description was changed from

==========
[build] Introduce an embedder version string

Sometimes, the embedder might want to merge a fix to an abandoned branch
or to a supported branch but the fix is not relevant to Chromium.
This adds a new version string that the embedder can set on compile time
and that will be appended to the official V8 version.
The separator must be provided in the string. For instance, to have a
full version string like "5.5.372.37.custom.1", the embedder must set
V8_EMBEDDER_STRING to ".custom.1".

Related Node.js issue: https://github.com/nodejs/node/pull/9754

BUG=v8:5740
R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng

Review-Url: https://codereview.chromium.org/2619213002
Cr-Commit-Position: refs/heads/master@{#42175}
Committed:
https://chromium.googlesource.com/v8/v8/+/fc86d4329b253bf21c1dd85469f1ef4b6e5...
==========

to

==========
[build] Introduce an embedder version string

Sometimes, the embedder might want to merge a fix to an abandoned branch
or to a supported branch but the fix is not relevant to Chromium.
This adds a new version string that the embedder can set on compile time
and that will be appended to the official V8 version.
The separator must be provided in the string. For instance, to have a
full version string like "5.5.372.37.custom.1", the embedder must set
V8_EMBEDDER_STRING to ".custom.1".

Related Node.js issue: https://github.com/nodejs/node/pull/9754

BUG=v8:5740
R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng

Review-Url: https://codereview.chromium.org/2619213002
Cr-Original-Commit-Position: refs/heads/master@{#42175}
Committed:
https://chromium.googlesource.com/v8/v8/+/fc86d4329b253bf21c1dd85469f1ef4b6e5...
Review-Url: https://codereview.chromium.org/2619213002
Cr-Commit-Position: refs/heads/master@{#42582}
Committed:
https://chromium.googlesource.com/v8/v8/+/2c1d1e60883882011ed50310a9b09e95dc6...
==========

[commit-bot: I haz the power, 2017-01-21 19:04:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/2c1d1e60883882011ed50310a9b09e95dc6...

[Michael Hablich, 2017-01-21 22:36:35]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2643393004/ by hablich@chromium.org.

The reason for reverting is: Blocks roll
https://codereview.chromium.org/2647183002/.

[Yeaisme, 2017-01-22 15:29:24]

joseroubertm@gmail.com changed reviewers:
+ joseroubertm@gmail.com

[Yeaisme, 2017-01-22 15:29:27]

lgtm

[Michael Achenbach, 2017-01-23 07:36:13]

Ah, I see now. The auto-roller takes the version file from the last roll branch
and modifies it. It ignores the one from master. So when we roll, the embedder
string is lost:
https://chromium.googlesource.com/v8/v8/+/5.8.2%5E%21/#F2

I'll think about if we could just manually wave this through or if the
auto-roller code should be changed for this.