Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2643393003: Disable precache on svelte. (Closed)

Created:
3 years, 11 months ago by twifkak
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Disable precache on svelte. Precache was enabled for svelte in http://crrev.com/c8e7c272, when the experiment was only on dev, in the interest in seeing the maximum percent of users that we could impact. There is an unconfirmed possibility that the background service may slow down phones with low RAM/CPU. Until we verify that it does not, we would like to avoid launching on svelte devices, in order to eliminate any potential for harm. This change re-disables the service on svelte devices, by checking PrivacyPreferencesManager#shouldPrerender() instead of PrefServiceBridge#getNetworkPredictionEnabled(). BUG=683259 Review-Url: https://codereview.chromium.org/2642733004 Cr-Commit-Position: refs/heads/master@{#445110} (cherry picked from commit 5fe1163de91a80f23c4a2b68ca1d1a5c53319986) Review-Url: https://codereview.chromium.org/2643393003 . Cr-Commit-Position: refs/branch-heads/2987@{#10} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/dd98737fa64262a5b13631518fde382ff8ad9d36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java View 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java View 8 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
twifkak
3 years, 11 months ago (2017-01-21 04:44:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dd98737fa64262a5b13631518fde382ff8ad9d36.

Powered by Google App Engine
This is Rietveld 408576698