Disable precache on svelte.

Disable precache on svelte.

Precache was enabled for svelte in http://crrev.com/c8e7c272, when the
experiment was only on dev, in the interest in seeing the maximum percent of
users that we could impact.

There is an unconfirmed possibility that the background service may slow down
phones with low RAM/CPU. Until we verify that it does not, we would like to
avoid launching on svelte devices, in order to eliminate any potential for
harm.

This change re-disables the service on svelte devices, by checking
PrivacyPreferencesManager#shouldPrerender() instead of
PrefServiceBridge#getNetworkPredictionEnabled().

BUG=683259
Review-Url: https://codereview.chromium.org/2642733004
Cr-Commit-Position: refs/heads/master@{#445110}
Committed: https://chromium.googlesource.com/chromium/src/+/5fe1163de91a80f23c4a2b68ca1d1a5c53319986

[twifkak, 2017-01-19 19:43:08]

twifkak@chromium.org changed reviewers:
+ nyquist@chromium.org

[twifkak, 2017-01-19 19:43:24]

The CQ bit was checked by twifkak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 19:44:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 20:29:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 20:29:07]

Dry run: This issue passed the CQ dry run.

[nyquist, 2017-01-20 18:25:43]

Could you expand the CL description to include why this change is being made,
not just what it does?

As in; I was wondering why we first had it enabled on svelte and now we do not.
The bug is a very long to read bug, so it's not easy to skim through that one to
find the reason either.

Following something along these lines are helpful for CL descriptions:
- What is happening now?
- Why is that bad?
- How does this CL make it better?
One paragraph for each of those makes it much easier to understand the reasoning
behind a CL.

[twifkak, 2017-01-20 18:44:46]

Description was changed from

==========
Disable precache on svelte.

Precache was enabled for svelte in http://crrev.com/c8e7c272. This
change re-disables it, by checking
PrivacyPreferencesManager#shouldPrerender() instead of
PrefServiceBridge#getNetworkPredictionEnabled().

BUG=309216
==========

to

==========
Disable precache on svelte.

Precache was enabled for svelte in http://crrev.com/c8e7c272, when the
experiment was only on dev, in the interest in seeing the maximum percent of
users that we could impact.

There is an unconfirmed possibility that the background service may slow down
phones with low RAM/CPU. Until we verify that it does not, we would like to
avoid launching on svelte devices, in order to eliminate any potential for harm.

This change re-disables it, by checking
PrivacyPreferencesManager#shouldPrerender() instead of
PrefServiceBridge#getNetworkPredictionEnabled().

BUG=683259
==========

[twifkak, 2017-01-20 18:45:50]

Description was changed from

==========
Disable precache on svelte.

Precache was enabled for svelte in http://crrev.com/c8e7c272, when the
experiment was only on dev, in the interest in seeing the maximum percent of
users that we could impact.

There is an unconfirmed possibility that the background service may slow down
phones with low RAM/CPU. Until we verify that it does not, we would like to
avoid launching on svelte devices, in order to eliminate any potential for harm.

This change re-disables it, by checking
PrivacyPreferencesManager#shouldPrerender() instead of
PrefServiceBridge#getNetworkPredictionEnabled().

BUG=683259
==========

to

==========
Disable precache on svelte.

Precache was enabled for svelte in http://crrev.com/c8e7c272, when the
experiment was only on dev, in the interest in seeing the maximum percent of
users that we could impact.

There is an unconfirmed possibility that the background service may slow down
phones with low RAM/CPU. Until we verify that it does not, we would like to
avoid launching on svelte devices, in order to eliminate any potential for
harm.

This change re-disables the service on svelte devices, by checking
PrivacyPreferencesManager#shouldPrerender() instead of
PrefServiceBridge#getNetworkPredictionEnabled().

BUG=683259
==========

[twifkak, 2017-01-20 18:46:23]

On 2017/01/20 18:25:43, nyquist wrote:
> Could you expand the CL description to include why this change is being made,
> not just what it does?
> 
> As in; I was wondering why we first had it enabled on svelte and now we do
not.
> The bug is a very long to read bug, so it's not easy to skim through that one
to
> find the reason either.
> 
> Following something along these lines are helpful for CL descriptions:
> - What is happening now?
> - Why is that bad?
> - How does this CL make it better?
> One paragraph for each of those makes it much easier to understand the
reasoning
> behind a CL.

Good idea, done. Let me know if this is sufficient.

[nyquist, 2017-01-20 18:47:10]

awesome! lgtm

[twifkak, 2017-01-20 18:49:46]

Thanks! Submitting.

[twifkak, 2017-01-20 18:49:53]

The CQ bit was checked by twifkak@chromium.org

[commit-bot: I haz the power, 2017-01-20 18:50:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 18:54:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484938193422850, "parent_rev":
"07dcf42f46e211a53f7c33ed634cc5f416a3929f", "commit_rev":
"5fe1163de91a80f23c4a2b68ca1d1a5c53319986"}

[commit-bot: I haz the power, 2017-01-20 18:55:20]

Description was changed from

==========
Disable precache on svelte.

Precache was enabled for svelte in http://crrev.com/c8e7c272, when the
experiment was only on dev, in the interest in seeing the maximum percent of
users that we could impact.

There is an unconfirmed possibility that the background service may slow down
phones with low RAM/CPU. Until we verify that it does not, we would like to
avoid launching on svelte devices, in order to eliminate any potential for
harm.

This change re-disables the service on svelte devices, by checking
PrivacyPreferencesManager#shouldPrerender() instead of
PrefServiceBridge#getNetworkPredictionEnabled().

BUG=683259
==========

to

==========
Disable precache on svelte.

Precache was enabled for svelte in http://crrev.com/c8e7c272, when the
experiment was only on dev, in the interest in seeing the maximum percent of
users that we could impact.

There is an unconfirmed possibility that the background service may slow down
phones with low RAM/CPU. Until we verify that it does not, we would like to
avoid launching on svelte devices, in order to eliminate any potential for
harm.

This change re-disables the service on svelte devices, by checking
PrivacyPreferencesManager#shouldPrerender() instead of
PrefServiceBridge#getNetworkPredictionEnabled().

BUG=683259

Review-Url: https://codereview.chromium.org/2642733004
Cr-Commit-Position: refs/heads/master@{#445110}
Committed:
https://chromium.googlesource.com/chromium/src/+/5fe1163de91a80f23c4a2b68ca1d...
==========

[commit-bot: I haz the power, 2017-01-20 18:55:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5fe1163de91a80f23c4a2b68ca1d...