bluetooth: Remove queuing of GetCharacteristicsCallbacks

bluetooth: Remove queuing of GetCharacteristicsCallbacks

Changes GetCharacteristics message implementation in Device to process
    calls immediately without queuing.
Changes return value of GetCharacteristics to an optional array.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2643393002
Cr-Commit-Position: refs/heads/master@{#445641}
Committed: https://chromium.googlesource.com/chromium/src/+/bb0f962b804ccacb423cb76a5a50505b4de6294a

[mbrunson, 2017-01-21 02:09:02]

Description was changed from

==========
bluetooth: Remove queuing of GetCharacteristicsCallbacks

Changes GetCharacteristics message implementation in Device to process
    calls immediately without queuing.
Changes return value of GetCharacteristics to an optional array.

BUG=651282
==========

to

==========
bluetooth: Remove queuing of GetCharacteristicsCallbacks

Changes GetCharacteristics message implementation in Device to process
    calls immediately without queuing.
Changes return value of GetCharacteristics to an optional array.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[mbrunson, 2017-01-21 02:18:50]

mbrunson@chromium.org changed reviewers:
+ ortuno@chromium.org, scheib@chromium.org

[scheib, 2017-01-21 02:37:54]

LGTM

[ortuno, 2017-01-22 22:40:38]

lgtm

[mbrunson, 2017-01-23 20:16:44]

mbrunson@chromium.org changed reviewers:
+ dcheng@chromium.org, dpapad@chromium.org

[mbrunson, 2017-01-23 20:16:45]

OWNERS review, please:

dcheng:
  device/bluetooth/public/interfaces/device.mojom

dpapad:
  chrome/browser/resources/bluetooth_internals/characteristic_list.js

[dpapad, 2017-01-23 20:30:07]

characteristic_list.js LGTM

[dcheng, 2017-01-23 22:42:57]

What's the difference between a null result and a result that's just the empty
array result?

[ortuno, 2017-01-23 22:49:40]

On 2017/01/23 at 22:42:57, dcheng wrote:
> What's the difference between a null result and a result that's just the empty
array result?

One indicates that there was an error while retrieving the characteristics
(null) while the other one indicates that the service doesn't have any
characteristics.

[dcheng, 2017-01-23 22:50:37]

On 2017/01/23 22:49:40, ortuno wrote:
> On 2017/01/23 at 22:42:57, dcheng wrote:
> > What's the difference between a null result and a result that's just the
empty
> array result?
> 
> One indicates that there was an error while retrieving the characteristics
> (null) while the other one indicates that the service doesn't have any
> characteristics.

mojom lgtm with an updated comment on the interface method that says that

[mbrunson, 2017-01-24 00:29:41]

The CQ bit was checked by mbrunson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 00:30:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 02:07:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 02:07:13]

Dry run: This issue passed the CQ dry run.

[mbrunson, 2017-01-24 04:22:24]

The CQ bit was checked by mbrunson@chromium.org

[mbrunson, 2017-01-24 04:22:26]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
ortuno@chromium.org, dcheng@chromium.org, dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2643393002/#ps40001
(title: "Add comment explaining null/empty difference")

[commit-bot: I haz the power, 2017-01-24 04:22:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 04:27:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485231744683780,
"parent_rev": "6932383d121be06d4c40094b7f44b99026d2c396", "commit_rev":
"bb0f962b804ccacb423cb76a5a50505b4de6294a"}

[commit-bot: I haz the power, 2017-01-24 04:27:49]

Description was changed from

==========
bluetooth: Remove queuing of GetCharacteristicsCallbacks

Changes GetCharacteristics message implementation in Device to process
    calls immediately without queuing.
Changes return value of GetCharacteristics to an optional array.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
bluetooth: Remove queuing of GetCharacteristicsCallbacks

Changes GetCharacteristics message implementation in Device to process
    calls immediately without queuing.
Changes return value of GetCharacteristics to an optional array.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2643393002
Cr-Commit-Position: refs/heads/master@{#445641}
Committed:
https://chromium.googlesource.com/chromium/src/+/bb0f962b804ccacb423cb76a5a50...
==========

[commit-bot: I haz the power, 2017-01-24 04:27:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bb0f962b804ccacb423cb76a5a50...