Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2643393002: bluetooth: Remove queuing of GetCharacteristicsCallbacks (Closed)

Created:
3 years, 11 months ago by mbrunson
Modified:
3 years, 11 months ago
Reviewers:
scheib, ortuno, dcheng, dpapad
CC:
Aaron Boodman, abarth-chromium, arv+watch_chromium.org, chromium-reviews, darin (slow to review), ortuno+watch_chromium.org, qsr+mojo_chromium.org, scheib+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Remove queuing of GetCharacteristicsCallbacks Changes GetCharacteristics message implementation in Device to process calls immediately without queuing. Changes return value of GetCharacteristics to an optional array. BUG=651282 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2643393002 Cr-Commit-Position: refs/heads/master@{#445641} Committed: https://chromium.googlesource.com/chromium/src/+/bb0f962b804ccacb423cb76a5a50505b4de6294a

Patch Set 1 #

Patch Set 2 : Change check of device to DCHECK #

Patch Set 3 : Add comment explaining null/empty difference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -150 lines) Patch
M chrome/browser/resources/bluetooth_internals/characteristic_list.js View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/device.h View 1 chunk +0 lines, -3 lines 0 comments Download
M device/bluetooth/device.cc View 1 2 chunks +18 lines, -32 lines 0 comments Download
M device/bluetooth/device_unittest.cc View 2 chunks +0 lines, -113 lines 0 comments Download
M device/bluetooth/public/interfaces/device.mojom View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
mbrunson
3 years, 11 months ago (2017-01-21 02:18:51 UTC) #3
scheib
LGTM
3 years, 11 months ago (2017-01-21 02:37:54 UTC) #4
ortuno
lgtm
3 years, 11 months ago (2017-01-22 22:40:38 UTC) #5
mbrunson
OWNERS review, please: dcheng: device/bluetooth/public/interfaces/device.mojom dpapad: chrome/browser/resources/bluetooth_internals/characteristic_list.js
3 years, 11 months ago (2017-01-23 20:16:45 UTC) #7
dpapad
characteristic_list.js LGTM
3 years, 11 months ago (2017-01-23 20:30:07 UTC) #8
dcheng
What's the difference between a null result and a result that's just the empty array ...
3 years, 11 months ago (2017-01-23 22:42:57 UTC) #9
ortuno
On 2017/01/23 at 22:42:57, dcheng wrote: > What's the difference between a null result and ...
3 years, 11 months ago (2017-01-23 22:49:40 UTC) #10
dcheng
On 2017/01/23 22:49:40, ortuno wrote: > On 2017/01/23 at 22:42:57, dcheng wrote: > > What's ...
3 years, 11 months ago (2017-01-23 22:50:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643393002/40001
3 years, 11 months ago (2017-01-24 04:22:52 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 04:27:50 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bb0f962b804ccacb423cb76a5a50...

Powered by Google App Engine
This is Rietveld 408576698