bluetooth: Remove queuing of GetCharacteristicsCallbacks

device/bluetooth/device_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/device.h"
 
 #include <memory>
 #include <string>
 #include <utility>
 
@@ skipping 161 matching lines @@
   Device::GetServicesCallback CheckGetServicesCount(Call expected) {
     if (expected == Call::EXPECTED)
       ++expected_success_callback_calls_;
 
     return base::Bind(&BluetoothInterfaceDeviceTest::CheckGetServicesCountImpl,
                       weak_factory_.GetWeakPtr(), expected,
                       2 /* expected_service_count */,
                       expected_callback_count_++);
   }
 
-  void CheckGetCharacteristicsCountImpl(
-      Call expected,
-      size_t expected_count,
-      int num_of_preceding_calls,
-      std::vector<mojom::CharacteristicInfoPtr> characteristics) {
-    EXPECT_EQ(num_of_preceding_calls, actual_callback_count_);
-    ++actual_callback_count_;
-
-    if (expected == Call::EXPECTED)
-      ++actual_success_callback_calls_;
-
-    EXPECT_EQ(expected_count, characteristics.size());
-  }
-
-  Device::GetCharacteristicsCallback CheckGetCharacteristicsCount(
-      Call expected,
-      int expected_count) {
-    if (expected == Call::EXPECTED)
-      ++expected_success_callback_calls_;
-
-    return base::Bind(
-        &BluetoothInterfaceDeviceTest::CheckGetCharacteristicsCountImpl,
-        weak_factory_.GetWeakPtr(), expected, expected_count,
-        expected_callback_count_++);
-  }
-
   scoped_refptr<NiceMockBluetoothAdapter> adapter_;
   NiceMockBluetoothDevice device_;
   base::MessageLoop message_loop_;
   mojom::DevicePtr proxy_;
   mojo::StrongBindingPtr<mojom::Device> binding_ptr_;
 
   bool message_pipe_closed_ = false;
   bool expect_device_service_deleted_ = false;
   int expected_success_callback_calls_ = 0;
   int actual_success_callback_calls_ = 0;
@@ skipping 73 matching lines @@
   proxy_->GetServices(CheckGetServicesCount(Call::NOT_EXPECTED));
   EXPECT_EQ(0, actual_callback_count_);
 
   // Simulate connection loss.
   proxy_->Disconnect();
   expect_device_service_deleted_ = true;
 
   // Wait for message pipe to process error.
   base::RunLoop().RunUntilIdle();
 }
-
-TEST_F(BluetoothInterfaceDeviceTest, GetCharacteristics) {
-  EXPECT_CALL(device_, IsGattServicesDiscoveryComplete())
-      .WillRepeatedly(Return(true));
-
-  proxy_->GetCharacteristics(kTestServiceId0,
-                             CheckGetCharacteristicsCount(Call::EXPECTED, 2));
-
-  base::RunLoop().RunUntilIdle();
-}
-
-TEST_F(BluetoothInterfaceDeviceTest, GetCharacteristicsNotDiscovered) {
-  EXPECT_CALL(device_, IsGattServicesDiscoveryComplete())
-      .WillOnce(Return(false))
-      .WillOnce(Return(false))
-      .WillRepeatedly(Return(true));
-
-  // Client: Sends multiple requests for characteristics.
-  proxy_->GetCharacteristics(kTestServiceId0,
-                             CheckGetCharacteristicsCount(Call::EXPECTED, 2));
-  proxy_->GetCharacteristics(kTestServiceId1,
-                             CheckGetCharacteristicsCount(Call::EXPECTED, 1));
-
-  base::RunLoop().RunUntilIdle();
-
-  SimulateGattServicesDiscovered();
-
-  // No more GetCharacteristics calls will complete.
-  SimulateGattServicesDiscovered();
-
-  base::RunLoop().RunUntilIdle();
-
-  // Client: Sends more requests which run immediately.
-  proxy_->GetCharacteristics(kTestServiceId0,
-                             CheckGetCharacteristicsCount(Call::EXPECTED, 2));
-  proxy_->GetCharacteristics(kTestServiceId1,
-                             CheckGetCharacteristicsCount(Call::EXPECTED, 1));
-
-  base::RunLoop().RunUntilIdle();
-
-  // No more GetCharacteristics calls will complete.
-  SimulateGattServicesDiscovered();
-
-  // Wait for message pipe to process error.
-  base::RunLoop().RunUntilIdle();
-}
-
-TEST_F(BluetoothInterfaceDeviceTest,
-       GetCharacteristicsLostConnectionWithPendingRequests) {
-  EXPECT_CALL(device_, IsGattServicesDiscoveryComplete())
-      .WillRepeatedly(Return(false));
-  // Client: Sends multiple requests for characteristics.
-  proxy_->GetCharacteristics(
-      kTestServiceId0, CheckGetCharacteristicsCount(Call::NOT_EXPECTED, 2));
-  proxy_->GetCharacteristics(
-      kTestServiceId1, CheckGetCharacteristicsCount(Call::NOT_EXPECTED, 1));
-  EXPECT_EQ(0, actual_callback_count_);
-
-  // Simulate connection loss.
-  device_.SetConnected(false);
-  SimulateDeviceChanged();
-  expect_device_service_deleted_ = true;
-
-  // Wait for message pipe to process error.
-  base::RunLoop().RunUntilIdle();
-}
-
-TEST_F(BluetoothInterfaceDeviceTest,
-       GetCharacteristicsForcedDisconnectionWithPendingRequests) {
-  EXPECT_CALL(device_, IsGattServicesDiscoveryComplete())
-      .WillRepeatedly(Return(false));
-
-  // Client: Sends multiple requests for characteristics.
-  proxy_->GetCharacteristics(
-      kTestServiceId0, CheckGetCharacteristicsCount(Call::NOT_EXPECTED, 2));
-  proxy_->GetCharacteristics(
-      kTestServiceId1, CheckGetCharacteristicsCount(Call::NOT_EXPECTED, 1));
-  EXPECT_EQ(0, actual_callback_count_);
-
-  // Simulate connection loss.
-  proxy_->Disconnect();
-  expect_device_service_deleted_ = true;
-
-  // Wait for message pipe to process error.
-  base::RunLoop().RunUntilIdle();
-}
-
 }  // namespace bluetooth