Adding Accessibility test coverage for more settings screens

Adding Accessibility test coverage for more settings screens

testAccessibilityOnPrivacyHandoffSettingsPage
testAccessibilityOnPrivacyClearBrowsingHistoryPage
testAccessibilityOnBandwidthPreloadWebpagesSettingsPage
testAccessibilityOnContentSettingsBlockPopupsPage
testAccessibilityOnContentSettingsTranslatePage

BUG=

Review-Url: https://codereview.chromium.org/2643303005
Cr-Commit-Position: refs/heads/master@{#445790}
Committed: https://chromium.googlesource.com/chromium/src/+/9e2228671a0ba78b940f8a4f43043e0880027a0b

[lindsayw, 2017-01-20 22:16:40]

lindsayw@chromium.org changed reviewers:
+ baxley@chromium.org, rohitrao@chromium.org

[baxley, 2017-01-20 23:24:58]

LGTM once comments are addressed (or overruled). No need to wait for me for
OWNERS review, unless you have other questions.

https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/settings_egtest.mm (right):

https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/settings_egtest.mm:149: id<GREYMatcher>
bandwidthPreloadWebpagesButton() {
Would you mind making these 4 matchers start with a capital letter?

I know we've done otherwise before, but we decided to make them capital to match
Chromium style, and be inconsistent with EG.

I have a big CL to clean it up, but it would be helpful if you could do it here.
:)

https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/settings_egtest.mm:152:
grey_not(grey_accessibilityTrait(UIAccessibilityTraitKeyboardKey)), nil);
do we need the matcher for not UIAccessibilityTraitKeyboardKey here? Are there
buttons on the keyboard that collide with this? (here and below)

[rohitrao (ping after 24h), 2017-01-23 12:55:31]

lgtm

https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/settings_egtest.mm (right):

https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/settings_egtest.mm:822: // Verifies the UI
elements are accessibile on the Content Settings
"Accessible", here and below.

[rohitrao (ping after 24h), 2017-01-23 13:07:36]

https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/settings_egtest.mm (right):

https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/settings_egtest.mm:868: [[EarlGrey
selectElementWithMatcher:clearBrowsingDataButton()]
Have you tried running this test on a 5S in landscape mode?  This button might
be below the fold in that configuration.

[lindsayw, 2017-01-24 18:46:57]

https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/settings_egtest.mm (right):

https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/settings_egtest.mm:149: id<GREYMatcher>
bandwidthPreloadWebpagesButton() {
On 2017/01/20 23:24:58, baxley wrote:
> Would you mind making these 4 matchers start with a capital letter?
> 
> I know we've done otherwise before, but we decided to make them capital to
match
> Chromium style, and be inconsistent with EG.
> 
> I have a big CL to clean it up, but it would be helpful if you could do it
here.
> :)

Done.

https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/settings_egtest.mm:152:
grey_not(grey_accessibilityTrait(UIAccessibilityTraitKeyboardKey)), nil);
On 2017/01/20 23:24:58, baxley wrote:
> do we need the matcher for not UIAccessibilityTraitKeyboardKey here? Are there
> buttons on the keyboard that collide with this? (here and below)

Good point, updated.

https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/settings_egtest.mm:822: // Verifies the UI
elements are accessibile on the Content Settings
On 2017/01/23 12:55:30, rohitrao wrote:
> "Accessible", here and below.

accessibile->accessible - Done.

https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/settings_egtest.mm:868: [[EarlGrey
selectElementWithMatcher:clearBrowsingDataButton()]
On 2017/01/23 13:07:36, rohitrao wrote:
> Have you tried running this test on a 5S in landscape mode?  This button might
> be below the fold in that configuration.

All of these tests fail, not only mine, in 5s landscape mode. I'll add a todo to
the openSubSetting method to investigate why usingSearchAction does not continue
to scroll down a given view as described in the API docs.

[lindsayw, 2017-01-24 19:06:11]

The CQ bit was checked by lindsayw@chromium.org

[lindsayw, 2017-01-24 19:06:11]

The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org,
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2643303005/#ps40001
(title: "Addressing baxley and rohitrao comments.")

[commit-bot: I haz the power, 2017-01-24 19:06:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 20:05:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485284771521450,
"parent_rev": "467d339230d5db21352a3568e906ab96818062d5", "commit_rev":
"9e2228671a0ba78b940f8a4f43043e0880027a0b"}

[commit-bot: I haz the power, 2017-01-24 20:06:47]

Description was changed from

==========
Adding Accessibility test coverage for more settings screens

testAccessibilityOnPrivacyHandoffSettingsPage
testAccessibilityOnPrivacyClearBrowsingHistoryPage
testAccessibilityOnBandwidthPreloadWebpagesSettingsPage
testAccessibilityOnContentSettingsBlockPopupsPage
testAccessibilityOnContentSettingsTranslatePage

BUG=
==========

to

==========
Adding Accessibility test coverage for more settings screens

testAccessibilityOnPrivacyHandoffSettingsPage
testAccessibilityOnPrivacyClearBrowsingHistoryPage
testAccessibilityOnBandwidthPreloadWebpagesSettingsPage
testAccessibilityOnContentSettingsBlockPopupsPage
testAccessibilityOnContentSettingsTranslatePage

BUG=

Review-Url: https://codereview.chromium.org/2643303005
Cr-Commit-Position: refs/heads/master@{#445790}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e2228671a0ba78b940f8a4f4304...
==========

[commit-bot: I haz the power, 2017-01-24 20:06:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9e2228671a0ba78b940f8a4f4304...