Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2643303005: Adding Accessibility test coverage for more settings screens (Closed)

Created:
3 years, 11 months ago by lindsayw
Modified:
3 years, 11 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding Accessibility test coverage for more settings screens testAccessibilityOnPrivacyHandoffSettingsPage testAccessibilityOnPrivacyClearBrowsingHistoryPage testAccessibilityOnBandwidthPreloadWebpagesSettingsPage testAccessibilityOnContentSettingsBlockPopupsPage testAccessibilityOnContentSettingsTranslatePage BUG= Review-Url: https://codereview.chromium.org/2643303005 Cr-Commit-Position: refs/heads/master@{#445790} Committed: https://chromium.googlesource.com/chromium/src/+/9e2228671a0ba78b940f8a4f43043e0880027a0b

Patch Set 1 #

Patch Set 2 : Fixing a comment. #

Total comments: 8

Patch Set 3 : Addressing baxley and rohitrao comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -4 lines) Patch
M ios/chrome/browser/ui/settings/settings_egtest.mm View 1 2 7 chunks +82 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
lindsayw
3 years, 11 months ago (2017-01-20 22:16:40 UTC) #2
baxley
LGTM once comments are addressed (or overruled). No need to wait for me for OWNERS ...
3 years, 11 months ago (2017-01-20 23:24:58 UTC) #3
rohitrao (ping after 24h)
lgtm https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/settings/settings_egtest.mm File ios/chrome/browser/ui/settings/settings_egtest.mm (right): https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/settings/settings_egtest.mm#newcode822 ios/chrome/browser/ui/settings/settings_egtest.mm:822: // Verifies the UI elements are accessibile on ...
3 years, 11 months ago (2017-01-23 12:55:31 UTC) #4
rohitrao (ping after 24h)
https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/settings/settings_egtest.mm File ios/chrome/browser/ui/settings/settings_egtest.mm (right): https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/settings/settings_egtest.mm#newcode868 ios/chrome/browser/ui/settings/settings_egtest.mm:868: [[EarlGrey selectElementWithMatcher:clearBrowsingDataButton()] Have you tried running this test on ...
3 years, 11 months ago (2017-01-23 13:07:36 UTC) #5
lindsayw
https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/settings/settings_egtest.mm File ios/chrome/browser/ui/settings/settings_egtest.mm (right): https://codereview.chromium.org/2643303005/diff/20001/ios/chrome/browser/ui/settings/settings_egtest.mm#newcode149 ios/chrome/browser/ui/settings/settings_egtest.mm:149: id<GREYMatcher> bandwidthPreloadWebpagesButton() { On 2017/01/20 23:24:58, baxley wrote: > ...
3 years, 11 months ago (2017-01-24 18:46:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643303005/40001
3 years, 11 months ago (2017-01-24 19:06:51 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 20:06:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9e2228671a0ba78b940f8a4f4304...

Powered by Google App Engine
This is Rietveld 408576698