Adding Accessibility test coverage for more settings screens

ios/chrome/browser/ui/settings/settings_egtest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <EarlGrey/EarlGrey.h>
 #import <UIKit/UIKit.h>
 #import <XCTest/XCTest.h>
 #include <map>
 
 #include "base/bind.h"
@@ skipping 127 matching lines @@
 id<GREYMatcher> googleChromeButton() {
   return buttonWithAccessibilityLabelId(IDS_IOS_PRODUCT_NAME);
 }
 
 // Matcher for the Google Chrome cell on the main Settings screen.
 id<GREYMatcher> voiceSearchButton() {
   return grey_allOf(grey_accessibilityID(kSettingsVoiceSearchCellId),
                     grey_accessibilityTrait(UIAccessibilityTraitButton), nil);
 }
 
+// Matcher for the Preload Webpages button on the bandwidth UI.
+id<GREYMatcher> bandwidthPreloadWebpagesButton() {

[baxley, 2017/01/20 23:24:58]

Would you mind making these 4 matchers start with a capital letter?

I know we've done otherwise before, but we decided to make them capital to match
Chromium style, and be inconsistent with EG.

I have a big CL to clean it up, but it would be helpful if you could do it here.
:)

[lindsayw, 2017/01/24 18:46:57]

Done.

+  return grey_allOf(
+      buttonWithAccessibilityLabelId(IDS_IOS_OPTIONS_PRELOAD_WEBPAGES),
+      grey_not(grey_accessibilityTrait(UIAccessibilityTraitKeyboardKey)), nil);

[baxley, 2017/01/20 23:24:58]

do we need the matcher for not UIAccessibilityTraitKeyboardKey here? Are there
buttons on the keyboard that collide with this? (here and below)

[lindsayw, 2017/01/24 18:46:57]

Good point, updated.

+}
+
+// Matcher for the Privacy Handoff button on the privacy UI.
+id<GREYMatcher> privacyHandoffButton() {
+  return grey_allOf(
+      buttonWithAccessibilityLabelId(
+          IDS_IOS_OPTIONS_ENABLE_HANDOFF_TO_OTHER_DEVICES),
+      grey_not(grey_accessibilityTrait(UIAccessibilityTraitKeyboardKey)), nil);
+}
+
+// Matcher for the Privacy Block Popups button on the privacy UI.
+id<GREYMatcher> blockPopupsButton() {
+  return grey_allOf(
+      buttonWithAccessibilityLabelId(IDS_IOS_BLOCK_POPUPS),
+      grey_not(grey_accessibilityTrait(UIAccessibilityTraitKeyboardKey)), nil);
+}
+
+// Matcher for the Privacy Translate Settings button on the privacy UI.
+id<GREYMatcher> translateSettingsButton() {
+  return grey_allOf(
+      buttonWithAccessibilityLabelId(IDS_IOS_TRANSLATE_SETTING),
+      grey_not(grey_accessibilityTrait(UIAccessibilityTraitKeyboardKey)), nil);
+}
+
 // Asserts that there is no cookie in current web state.
 void AssertNoCookieExists() {
   NSError* error = nil;
   chrome_test_util::ExecuteJavaScript(
       base::SysUTF8ToNSString(kJavaScriptGetCookies), &error);
   [[EarlGrey selectElementWithMatcher:chrome_test_util::webViewContainingText(
                                           kNoCookieText)]
       assertWithMatcher:grey_notNil()];
 }
 
@@ skipping 625 matching lines @@
 }
 
 // Verifies the UI elements are accessibile on the Content Settings page.
 - (void)testAccessibilityOnContentSettingsPage {
   [self openSubSettingMenu:chrome_test_util::buttonWithAccessibilityLabelId(
                                IDS_IOS_CONTENT_SETTINGS_TITLE)];
   chrome_test_util::VerifyAccessibilityForCurrentScreen();
   [self closeSubSettingsMenu];
 }
 
+// Verifies the UI elements are accessibile on the Content Settings

[rohitrao (ping after 24h), 2017/01/23 12:55:30]

"Accessible", here and below.

[lindsayw, 2017/01/24 18:46:57]

accessibile->accessible - Done.

+// Block Popups page.
+- (void)testAccessibilityOnContentSettingsBlockPopupsPage {
+  [self openSubSettingMenu:chrome_test_util::buttonWithAccessibilityLabelId(
+                               IDS_IOS_CONTENT_SETTINGS_TITLE)];
+  [[EarlGrey selectElementWithMatcher:blockPopupsButton()]
+      performAction:grey_tap()];
+  chrome_test_util::VerifyAccessibilityForCurrentScreen();
+  [self closeSubSettingsMenu];
+}
+
+// Verifies the UI elements are accessibile on the Content Translations Settings
+// page.
+- (void)testAccessibilityOnContentSettingsTranslatePage {
+  [self openSubSettingMenu:chrome_test_util::buttonWithAccessibilityLabelId(
+                               IDS_IOS_CONTENT_SETTINGS_TITLE)];
+  [[EarlGrey selectElementWithMatcher:translateSettingsButton()]
+      performAction:grey_tap()];
+  chrome_test_util::VerifyAccessibilityForCurrentScreen();
+  [self closeSubSettingsMenu];
+}
+
 // Verifies the UI elements are accessibile on the Privacy Settings page.
 - (void)testAccessibilityOnPrivacySettingsPage {
   [self openSubSettingMenu:chrome_test_util::buttonWithAccessibilityLabelId(
                                IDS_OPTIONS_ADVANCED_SECTION_TITLE_PRIVACY)];
   chrome_test_util::VerifyAccessibilityForCurrentScreen();
   [self closeSubSettingsMenu];
 }
 
+// Verifies the UI elements are accessibile on the Privacy Handoff Settings
+// page.
+- (void)testAccessibilityOnPrivacyHandoffSettingsPage {
+  [self openSubSettingMenu:chrome_test_util::buttonWithAccessibilityLabelId(
+                               IDS_OPTIONS_ADVANCED_SECTION_TITLE_PRIVACY)];
+  [[EarlGrey selectElementWithMatcher:privacyHandoffButton()]
+      performAction:grey_tap()];
+  chrome_test_util::VerifyAccessibilityForCurrentScreen();
+  [self closeSubSettingsMenu];
+}
+
+// Verifies the UI elements are accessibile on the Privacy Clear Browsing Data
+// Settings page.
+- (void)testAccessibilityOnPrivacyClearBrowsingHistoryPage {
+  [self openSubSettingMenu:chrome_test_util::buttonWithAccessibilityLabelId(
+                               IDS_OPTIONS_ADVANCED_SECTION_TITLE_PRIVACY)];
+  [[EarlGrey selectElementWithMatcher:clearBrowsingDataButton()]

[rohitrao (ping after 24h), 2017/01/23 13:07:36]

Have you tried running this test on a 5S in landscape mode?  This button might
be below the fold in that configuration.

[lindsayw, 2017/01/24 18:46:57]

All of these tests fail, not only mine, in 5s landscape mode. I'll add a todo to
the openSubSetting method to investigate why usingSearchAction does not continue
to scroll down a given view as described in the API docs.

+      performAction:grey_tap()];
+  chrome_test_util::VerifyAccessibilityForCurrentScreen();
+  [self closeSubSettingsMenu];
+}
+
 // Verifies the UI elements are accessibile on the Bandwidth Management Settings
 // page.
 - (void)testAccessibilityOnBandwidthManagementSettingsPage {
   [self openSubSettingMenu:chrome_test_util::buttonWithAccessibilityLabelId(
                                IDS_IOS_BANDWIDTH_MANAGEMENT_SETTINGS)];
   chrome_test_util::VerifyAccessibilityForCurrentScreen();
   [self closeSubSettingsMenu];
 }
 
+// Verifies the UI elements are accessibile on the Bandwidth Preload Webpages
+// Settings page.
+- (void)testAccessibilityOnBandwidthPreloadWebpagesSettingsPage {
+  [self openSubSettingMenu:chrome_test_util::buttonWithAccessibilityLabelId(
+                               IDS_IOS_BANDWIDTH_MANAGEMENT_SETTINGS)];
+  [[EarlGrey selectElementWithMatcher:bandwidthPreloadWebpagesButton()]
+      performAction:grey_tap()];
+  chrome_test_util::VerifyAccessibilityForCurrentScreen();
+  [self closeSubSettingsMenu];
+}
+
 // Verifies the UI elements are accessible on the Save Passwords page.
 - (void)testAccessibilityOnSavePasswords {
   [ChromeEarlGreyUI openToolsMenu];
   [[EarlGrey selectElementWithMatcher:settingsButton()]
       performAction:grey_tap()];
   [[EarlGrey selectElementWithMatcher:passwordsButton()]
       performAction:grey_tap()];
   chrome_test_util::VerifyAccessibilityForCurrentScreen();
   [self closeSubSettingsMenu];
 }
@@ skipping 39 matching lines @@
 }
 
 // Verifies the UI elements are accessible on the Voice Search page.
 - (void)testAccessibilityOnVoiceSearch {
   [self openSubSettingMenu:voiceSearchButton()];
   chrome_test_util::VerifyAccessibilityForCurrentScreen();
   [self closeSubSettingsMenu];
 }
 
 @end