Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2643233002: Revert of [Compiler] Have renumber recurse into eagerly compiled function literals. (Closed)

Created:
3 years, 11 months ago by rmcilroy
Modified:
3 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, jochen (gone - plz use gerrit)
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Compiler] Have renumber recurse into eagerly compiled function literals. (patchset #2 id:40001 of https://codereview.chromium.org/2648503002/ ) Reason for revert: Revert in order to revert dependent patchset https://codereview.chromium.org/2632123006/ Original issue's description: > [Compiler] Have renumber recurse into eagerly compiled function literals. > > This enables us to produce the list of eager inner functions for compilation > in one go during the outer function's renumbering step, and avoid having > to do renumbering explicitly on the inner functions, simplifying the zone > ownership. > > BUG=v8:5203, v8:5215 > > Review-Url: https://codereview.chromium.org/2648503002 > Cr-Commit-Position: refs/heads/master@{#42540} > Committed: https://chromium.googlesource.com/v8/v8/+/3541a074e241421b64ba41d81d8a99bb6ac62c5e TBR=mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203, v8:5215 Review-Url: https://codereview.chromium.org/2643233002 Cr-Commit-Position: refs/heads/master@{#42541} Committed: https://chromium.googlesource.com/v8/v8/+/d2fe6dfadc213fb29e90fcd5cfeb742de926221d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -36 lines) Patch
M src/ast/ast-numbering.cc View 1 chunk +6 lines, -12 lines 0 comments Download
M src/compiler.cc View 6 chunks +32 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmcilroy
Created Revert of [Compiler] Have renumber recurse into eagerly compiled function literals.
3 years, 11 months ago (2017-01-20 10:41:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643233002/1
3 years, 11 months ago (2017-01-20 10:41:55 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 10:42:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d2fe6dfadc213fb29e90fcd5cfeb742de92...

Powered by Google App Engine
This is Rietveld 408576698