Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2648503002:
[Compiler] Have renumber recurse into eagerly compiled function literals. (Closed)
|
Created:
3 years, 11 months ago by rmcilroy Modified:
3 years, 11 months ago Reviewers:
Michael Starzinger CC:
v8-reviews_googlegroups.com, jochen (gone - plz use gerrit) Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Compiler] Have renumber recurse into eagerly compiled function literals.
This enables us to produce the list of eager inner functions for compilation
in one go during the outer function's renumbering step, and avoid having
to do renumbering explicitly on the inner functions, simplifying the zone
ownership.
BUG=v8:5203, v8:5215
Review-Url: https://codereview.chromium.org/2648503002
Cr-Original-Commit-Position: refs/heads/master@{#42540}
Committed: https://chromium.googlesource.com/v8/v8/+/3541a074e241421b64ba41d81d8a99bb6ac62c5e
Review-Url: https://codereview.chromium.org/2648503002
Cr-Commit-Position: refs/heads/master@{#42580}
Committed: https://chromium.googlesource.com/v8/v8/+/380b720d3cfa9d8377176033298158f6d0d3c78f
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add comment #
Depends on Patchset: Messages
Total messages: 22 (14 generated)
rmcilroy@chromium.org changed reviewers: + mstarzinger@chromium.org
Michi, PTAL. Jochen, FYI
LGTM. https://codereview.chromium.org/2648503002/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/2648503002/diff/1/src/compiler.cc#newcode524 src/compiler.cc:524: SetSharedFunctionFlagsFromLiteral(literal, shared); nit: Please add a brief comment here explaining that the given {literal} has already been numbered because AstNumbering descends into eagerly compiled function literals.
https://codereview.chromium.org/2648503002/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/2648503002/diff/1/src/compiler.cc#newcode524 src/compiler.cc:524: SetSharedFunctionFlagsFromLiteral(literal, shared); On 2017/01/19 13:29:22, Michael Starzinger wrote: > nit: Please add a brief comment here explaining that the given {literal} has > already been numbered because AstNumbering descends into eagerly compiled > function literals. Done.
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rmcilroy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mstarzinger@chromium.org Link to the patchset: https://codereview.chromium.org/2648503002/#ps40001 (title: "Add comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484905743602190,
"parent_rev": "839b06b64fcaaaa9cceb2c3fd8fd5429e2932095", "commit_rev":
"3541a074e241421b64ba41d81d8a99bb6ac62c5e"}
Message was sent while issue was closed.
Description was changed from ========== [Compiler] Have renumber recurse into eagerly compiled function literals. This enables us to produce the list of eager inner functions for compilation in one go during the outer function's renumbering step, and avoid having to do renumbering explicitly on the inner functions, simplifying the zone ownership. BUG=v8:5203, v8:5215 ========== to ========== [Compiler] Have renumber recurse into eagerly compiled function literals. This enables us to produce the list of eager inner functions for compilation in one go during the outer function's renumbering step, and avoid having to do renumbering explicitly on the inner functions, simplifying the zone ownership. BUG=v8:5203, v8:5215 Review-Url: https://codereview.chromium.org/2648503002 Cr-Commit-Position: refs/heads/master@{#42540} Committed: https://chromium.googlesource.com/v8/v8/+/3541a074e241421b64ba41d81d8a99bb6ac... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/v8/v8/+/3541a074e241421b64ba41d81d8a99bb6ac...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/2643233002/ by rmcilroy@chromium.org. The reason for reverting is: Revert in order to revert dependent patchset https://codereview.chromium.org/2632123006/.
Message was sent while issue was closed.
Description was changed from ========== [Compiler] Have renumber recurse into eagerly compiled function literals. This enables us to produce the list of eager inner functions for compilation in one go during the outer function's renumbering step, and avoid having to do renumbering explicitly on the inner functions, simplifying the zone ownership. BUG=v8:5203, v8:5215 Review-Url: https://codereview.chromium.org/2648503002 Cr-Commit-Position: refs/heads/master@{#42540} Committed: https://chromium.googlesource.com/v8/v8/+/3541a074e241421b64ba41d81d8a99bb6ac... ========== to ========== [Compiler] Have renumber recurse into eagerly compiled function literals. This enables us to produce the list of eager inner functions for compilation in one go during the outer function's renumbering step, and avoid having to do renumbering explicitly on the inner functions, simplifying the zone ownership. BUG=v8:5203, v8:5215 Review-Url: https://codereview.chromium.org/2648503002 Cr-Commit-Position: refs/heads/master@{#42540} Committed: https://chromium.googlesource.com/v8/v8/+/3541a074e241421b64ba41d81d8a99bb6ac... ==========
The CQ bit was checked by rmcilroy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484949031411290,
"parent_rev": "87851fda78e45bd95833c7e50b0befaf2445f911", "commit_rev":
"380b720d3cfa9d8377176033298158f6d0d3c78f"}
Message was sent while issue was closed.
Description was changed from ========== [Compiler] Have renumber recurse into eagerly compiled function literals. This enables us to produce the list of eager inner functions for compilation in one go during the outer function's renumbering step, and avoid having to do renumbering explicitly on the inner functions, simplifying the zone ownership. BUG=v8:5203, v8:5215 Review-Url: https://codereview.chromium.org/2648503002 Cr-Commit-Position: refs/heads/master@{#42540} Committed: https://chromium.googlesource.com/v8/v8/+/3541a074e241421b64ba41d81d8a99bb6ac... ========== to ========== [Compiler] Have renumber recurse into eagerly compiled function literals. This enables us to produce the list of eager inner functions for compilation in one go during the outer function's renumbering step, and avoid having to do renumbering explicitly on the inner functions, simplifying the zone ownership. BUG=v8:5203, v8:5215 Review-Url: https://codereview.chromium.org/2648503002 Cr-Original-Commit-Position: refs/heads/master@{#42540} Committed: https://chromium.googlesource.com/v8/v8/+/3541a074e241421b64ba41d81d8a99bb6ac... Review-Url: https://codereview.chromium.org/2648503002 Cr-Commit-Position: refs/heads/master@{#42580} Committed: https://chromium.googlesource.com/v8/v8/+/380b720d3cfa9d8377176033298158f6d0d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/v8/v8/+/380b720d3cfa9d8377176033298158f6d0d... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
