Don't cancel out scroll offset when calculating the clip rectangle for multicol.

Don't cancel out scroll offset when calculating the clip rectangle for multicol.

We still want the clip rect to be relative to the multicol container, but we
cannot get there by using the location() of the flow thread's PaintLayer,
because then we'll then cancel out the scroll offset that's also baked into
offsetOfPaginationLayerFromRoot.

This CL will cause paint/invalidation/paged-with-overflowing-block-rl.html to
regress, but it turned out that it just passed by accident anyway. Having that
test broken is way less serious than barely being able to scroll at all in a
regular multicol container.

BUG=674640
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2643123004
Cr-Commit-Position: refs/heads/master@{#445478}
Committed: https://chromium.googlesource.com/chromium/src/+/ccde605b5967c796069c4208227f088b62bc7483

[mstensho (USE GERRIT), 2017-01-20 20:44:40]

Description was changed from

==========
Don't cancel out scroll offset when calculating the clip rectangle for multicol.

We still want the clip rect to be relative to the multicol container, but we
cannot get there by using the location() of the flow thread's PaintLayer,
because then we'll then cancel out the scroll offset that's also baked into
offsetOfPaginationLayerFromRoot.

This CL will cause paint/invalidation/paged-with-overflowing-block-rl.html to
regress, but it turned out that it just passed by accident anyway. Having that
test broken is way less serious than barely being able to scroll at all in a
regular multicol container.

BUG=674640
==========

to

==========
Don't cancel out scroll offset when calculating the clip rectangle for multicol.

We still want the clip rect to be relative to the multicol container, but we
cannot get there by using the location() of the flow thread's PaintLayer,
because then we'll then cancel out the scroll offset that's also baked into
offsetOfPaginationLayerFromRoot.

This CL will cause paint/invalidation/paged-with-overflowing-block-rl.html to
regress, but it turned out that it just passed by accident anyway. Having that
test broken is way less serious than barely being able to scroll at all in a
regular multicol container.

BUG=674640
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[mstensho (USE GERRIT), 2017-01-20 20:49:07]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 20:49:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 21:55:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 21:55:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mstensho (USE GERRIT), 2017-01-21 10:28:24]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-21 10:28:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 11:03:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 11:03:48]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[mstensho (USE GERRIT), 2017-01-22 21:23:00]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-22 21:23:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-22 21:54:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-22 21:54:10]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[mstensho (USE GERRIT), 2017-01-23 10:13:47]

mstensho@opera.com changed reviewers:
+ wangxianzhu@chromium.org

[mstensho (USE GERRIT), 2017-01-23 10:13:47]

I have problems with the linux_layout_tests_slimming_paint_v2 trybot. My new
test fails there. Then I tested locally, and it does indeed fail, but it also
seems that multicol is pretty much unsupported with SlimmingPaintV2. If I run
through the tests in LayoutTests/fast/multicol/ with
--additional-drt-flag=--enable-blink-features=SlimmingPaintV2, more than 200
tests fail. How do I proceed from here?

[Xianzhu, 2017-01-23 17:10:23]

lgtm.

On 2017/01/23 10:13:47, mstensho wrote:
> I have problems with the linux_layout_tests_slimming_paint_v2 trybot. My new
> test fails there. Then I tested locally, and it does indeed fail, but it also
> seems that multicol is pretty much unsupported with SlimmingPaintV2. If I run
> through the tests in LayoutTests/fast/multicol/ with
> --additional-drt-flag=--enable-blink-features=SlimmingPaintV2, more than 200
> tests fail. How do I proceed from here?

You can add the failure expectations into
LayoutTests/FlagExpectations/enable-slimming-paint-v2 with crbug.com/648274.

[mstensho (USE GERRIT), 2017-01-23 18:30:01]

On 2017/01/23 17:10:23, Xianzhu wrote:
> You can add the failure expectations into
> LayoutTests/FlagExpectations/enable-slimming-paint-v2 with crbug.com/648274.

Thanks! Done.

[mstensho (USE GERRIT), 2017-01-23 18:30:09]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2017-01-23 18:30:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2643123004/#ps60001
(title: "The new test is expected to fail with SlimmingPaintV2")

[commit-bot: I haz the power, 2017-01-23 18:30:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 20:52:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485196209020270,
"parent_rev": "a26a3a7b14e17d5d76b393f7df52210346b359cb", "commit_rev":
"ccde605b5967c796069c4208227f088b62bc7483"}

[commit-bot: I haz the power, 2017-01-23 20:52:58]

Description was changed from

==========
Don't cancel out scroll offset when calculating the clip rectangle for multicol.

We still want the clip rect to be relative to the multicol container, but we
cannot get there by using the location() of the flow thread's PaintLayer,
because then we'll then cancel out the scroll offset that's also baked into
offsetOfPaginationLayerFromRoot.

This CL will cause paint/invalidation/paged-with-overflowing-block-rl.html to
regress, but it turned out that it just passed by accident anyway. Having that
test broken is way less serious than barely being able to scroll at all in a
regular multicol container.

BUG=674640
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't cancel out scroll offset when calculating the clip rectangle for multicol.

We still want the clip rect to be relative to the multicol container, but we
cannot get there by using the location() of the flow thread's PaintLayer,
because then we'll then cancel out the scroll offset that's also baked into
offsetOfPaginationLayerFromRoot.

This CL will cause paint/invalidation/paged-with-overflowing-block-rl.html to
regress, but it turned out that it just passed by accident anyway. Having that
test broken is way less serious than barely being able to scroll at all in a
regular multicol container.

BUG=674640
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2643123004
Cr-Commit-Position: refs/heads/master@{#445478}
Committed:
https://chromium.googlesource.com/chromium/src/+/ccde605b5967c796069c4208227f...
==========

[commit-bot: I haz the power, 2017-01-23 20:52:59]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ccde605b5967c796069c4208227f...