third_party/WebKit/Source/core/paint/PaintLayer.cpp - Issue 2643123004: Don't cancel out scroll offset when calculating the clip rectangle for multicol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2643123004: Don't cancel out scroll offset when calculating the clip rectangle for multicol. (Closed)

Patch Set: The new test is expected to fail with SlimmingPaintV2 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

index 73e6debb93a0f95c56cb0ae8c10362ba4c388675..1406e435a1bcb5268ffff3a19d821ee131dfda73 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

@@ -1635,7 +1635,7 @@ void PaintLayer::collectFragments(

// Make the dirty rect relative to the fragmentation context (multicol

// container, etc.).

LayoutRect dirtyRectInMulticolContainer(dirtyRect);

- dirtyRectInMulticolContainer.move(enclosingPaginationLayer()->location() -

+ dirtyRectInMulticolContainer.move(enclosingFlowThread->physicalLocation() -

offsetOfPaginationLayerFromRoot);

// Slice the layer into fragments. Each fragment needs to be processed (e.g.

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/scrollable-basic-expected.html ('k') | no next file » | no next file with comments »