Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2643023005: Move VibrationController to TaskRunnerTimer. (Closed)

Created:
3 years, 11 months ago by jbroman
Modified:
3 years, 11 months ago
CC:
blink-reviews, chromium-reviews, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move VibrationController to TaskRunnerTimer. Using TaskType::MiscPlatformAPI, since the spec merely describes this as "wait": https://w3c.github.io/vibration/#vibration-interface BUG=624694 Review-Url: https://codereview.chromium.org/2643023005 Cr-Commit-Position: refs/heads/master@{#445073} Committed: https://chromium.googlesource.com/chromium/src/+/8a8f9410c5341f0d338e0b99451672fd448db188

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/vibration/VibrationController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vibration/VibrationController.cpp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
jbroman
3 years, 11 months ago (2017-01-20 02:30:56 UTC) #5
jbroman
adding haraken as a reviewer: I believe this should be MiscPlatformAPI, but it's possible it ...
3 years, 11 months ago (2017-01-20 02:49:56 UTC) #7
haraken
On 2017/01/20 02:49:56, jbroman wrote: > adding haraken as a reviewer: I believe this should ...
3 years, 11 months ago (2017-01-20 04:44:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643023005/1
3 years, 11 months ago (2017-01-20 16:33:39 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 16:38:23 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8a8f9410c5341f0d338e0b994516...

Powered by Google App Engine
This is Rietveld 408576698