Have VisitorHelper<> handle moving object registration.

Have VisitorHelper<> handle moving object registration.

As the registration of objects is only done by a compacting
GC, there isn't any need to be indirect about registering
them - remove a layer of Visitor virtual methods and have
the VisitorHelper<> do the registration directly.

R=haraken
BUG=681991
Review-Url: https://codereview.chromium.org/2642933005
Cr-Commit-Position: refs/heads/master@{#445245}
Committed: https://chromium.googlesource.com/chromium/src/+/715f6ff05807d86ba55be0614c999a823a32f850

[sof, 2017-01-20 13:20:53]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 13:21:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-01-20 13:25:10]

Description was changed from

==========
Avoid Visitor indirections when registering moving objects.

As the registration of objects is only done by a compacting
GC, there really isn't any need to be indirect about registering
them - remove a layer of virtual methods.

R=
BUG=681991
==========

to

==========
Have VisitorHelper<> handle moving object registration.

As the registration of objects is only done by a compacting
GC, there isn't any need to be indirect about registering
them - remove a layer of Visitor virtual methods and have
the VisitorHelper<> do the registration directly.

R=
BUG=681991
==========

[sof, 2017-01-20 13:27:27]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2017-01-20 13:27:27]

please take a look.

this doesn't help with the code size regression reported, but is worth doing
regardless, i suggest.

[haraken, 2017-01-20 13:50:41]

LGTM

[commit-bot: I haz the power, 2017-01-20 13:50:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 13:50:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sof, 2017-01-20 14:57:11]

Description was changed from

==========
Have VisitorHelper<> handle moving object registration.

As the registration of objects is only done by a compacting
GC, there isn't any need to be indirect about registering
them - remove a layer of Visitor virtual methods and have
the VisitorHelper<> do the registration directly.

R=
BUG=681991
==========

to

==========
Have VisitorHelper<> handle moving object registration.

As the registration of objects is only done by a compacting
GC, there isn't any need to be indirect about registering
them - remove a layer of Visitor virtual methods and have
the VisitorHelper<> do the registration directly.

R=haraken
BUG=681991
==========

[sof, 2017-01-20 14:57:59]

I forgot to remove some trivial & empty overrides in HeapTest; updated to do so.

[sof, 2017-01-20 14:58:04]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2017-01-20 14:58:05]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2642933005/#ps20001
(title: "fix unit test compilation")

[commit-bot: I haz the power, 2017-01-20 14:58:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 15:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 15:54:04]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[sof, 2017-01-20 21:52:20]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2017-01-20 21:52:20]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2642933005/#ps40001
(title: "msvc compile fix")

[commit-bot: I haz the power, 2017-01-20 21:52:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 01:38:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484949140670330,
"parent_rev": "e100229f582a151b27bfe1d1bd85942b5b7d05e8", "commit_rev":
"715f6ff05807d86ba55be0614c999a823a32f850"}

[commit-bot: I haz the power, 2017-01-21 01:38:43]

Description was changed from

==========
Have VisitorHelper<> handle moving object registration.

As the registration of objects is only done by a compacting
GC, there isn't any need to be indirect about registering
them - remove a layer of Visitor virtual methods and have
the VisitorHelper<> do the registration directly.

R=haraken
BUG=681991
==========

to

==========
Have VisitorHelper<> handle moving object registration.

As the registration of objects is only done by a compacting
GC, there isn't any need to be indirect about registering
them - remove a layer of Visitor virtual methods and have
the VisitorHelper<> do the registration directly.

R=haraken
BUG=681991

Review-Url: https://codereview.chromium.org/2642933005
Cr-Commit-Position: refs/heads/master@{#445245}
Committed:
https://chromium.googlesource.com/chromium/src/+/715f6ff05807d86ba55be0614c99...
==========

[commit-bot: I haz the power, 2017-01-21 01:38:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/715f6ff05807d86ba55be0614c99...