Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: third_party/WebKit/Source/platform/heap/Visitor.h

Issue 2642933005: Have VisitorHelper<> handle moving object registration. (Closed)
Patch Set: msvc compile fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/SparseHeapBitmap.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/Visitor.h
diff --git a/third_party/WebKit/Source/platform/heap/Visitor.h b/third_party/WebKit/Source/platform/heap/Visitor.h
index 0b6129b248650abfacc65208e4fcaeda962859fb..aacbce1106ada97591ab5a331610b2bffa323e2f 100644
--- a/third_party/WebKit/Source/platform/heap/Visitor.h
+++ b/third_party/WebKit/Source/platform/heap/Visitor.h
@@ -283,7 +283,7 @@ class VisitorHelper {
void registerBackingStoreReference(void* slot) {
if (getMarkingMode() != VisitorMarkingMode::GlobalMarkingWithCompaction)
return;
- Derived::fromHelper(this)->registerMovingObjectReference(
+ heap().registerMovingObjectReference(
reinterpret_cast<MovableReference*>(slot));
}
@@ -292,7 +292,7 @@ class VisitorHelper {
void* callbackData) {
if (getMarkingMode() != VisitorMarkingMode::GlobalMarkingWithCompaction)
return;
- Derived::fromHelper(this)->registerMovingObjectCallback(
+ heap().registerMovingObjectCallback(
reinterpret_cast<MovableReference>(backingStore), callback,
callbackData);
}
@@ -387,12 +387,6 @@ class PLATFORM_EXPORT Visitor : public VisitorHelper<Visitor> {
virtual bool ensureMarked(const void*) = 0;
- virtual void registerMovingObjectReference(MovableReference*) = 0;
-
- virtual void registerMovingObjectCallback(MovableReference,
- MovingObjectCallback,
- void*) = 0;
-
virtual void registerWeakCellWithCallback(void**, WeakCallback) = 0;
protected:
« no previous file with comments | « third_party/WebKit/Source/platform/heap/SparseHeapBitmap.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698