Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issue 2642923002: Add pixel shader version to GPU control list (Closed)

Created:
3 years, 11 months ago by ericrk
Modified:
3 years, 10 months ago
Reviewers:
jbauman
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add pixel shader version to GPU control list Adds the ability to filter GPU control list entries by pixel shader version. This will be used to mass-exclude older cards from GPU raster. crrev.com/2654993004 moves GPU blacklist calculation (for GPU raster) to the GPU proc, communicating GPU raster status with the renderer via context caps. This enables more advanced filtering like this. BUG=648493 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2642923002 Cr-Commit-Position: refs/heads/master@{#449756} Committed: https://chromium.googlesource.com/chromium/src/+/2c9e097081d506490382ae599a1543436144a195

Patch Set 1 #

Patch Set 2 : ps_version > pixel_shader_version #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M gpu/config/gpu_control_list.h View 2 chunks +5 lines, -0 lines 0 comments Download
M gpu/config/gpu_control_list.cc View 1 4 chunks +36 lines, -0 lines 0 comments Download
M gpu/config/gpu_control_list_entry_unittest.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M gpu/config/gpu_control_list_format.txt View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (12 generated)
ericrk
3 years, 10 months ago (2017-02-06 21:57:13 UTC) #5
jbauman
lgtm
3 years, 10 months ago (2017-02-07 22:56:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642923002/60001
3 years, 10 months ago (2017-02-10 21:26:58 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 22:16:16 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2c9e097081d506490382ae599a15...

Powered by Google App Engine
This is Rietveld 408576698