XS: s/malware_pattern_type/malware_threat_type

XS: s/malware_pattern_type/malware_threat_type

BUG=680802
Review-Url: https://codereview.chromium.org/2642823013
Cr-Commit-Position: refs/heads/master@{#445894}
Committed: https://chromium.googlesource.com/chromium/src/+/0d7499da3e2579015a187268d58863f713eec33e

[vakh (use Gerrit instead), 2017-01-21 02:08:29]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-21 02:08:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vakh (use Gerrit instead), 2017-01-21 02:09:03]

vakh@chromium.org changed reviewers:
+ awoz@chromium.org, nparker@chromium.org

[commit-bot: I haz the power, 2017-01-21 03:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 03:46:23]

Dry run: This issue passed the CQ dry run.

[Nathan Parker, 2017-01-24 00:01:32]

lgtm

https://codereview.chromium.org/2642823013/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/v4_get_hash_protocol_manager.cc (right):

https://codereview.chromium.org/2642823013/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_get_hash_protocol_manager.cc:122: const char
kPhaPatternType[] = "pha_pattern_type";
Huh, why is this one pha_PATTERN_type then? Maybe this was a mistake in the
original public spec.

https://codereview.chromium.org/2642823013/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_get_hash_protocol_manager.cc:590:
match.threat_type() == POTENTIALLY_HARMFUL_APPLICATION) {
Is this even possible?  I'm wondering if we can remove the
POTENTIALLY_HARMFUL_APPLICATION and kPhaPatternType from this file -- those are
mobile-only terms.  We do use "pha_pattern_type" when parsing metadata from
XLB/GMSCore, but that's here:

https://cs.chromium.org/chromium/src/components/safe_browsing_db/safe_browsin...

At least add a TODO

[vakh (use Gerrit instead), 2017-01-24 23:40:29]

On 2017/01/24 00:01:32, Nathan Parker wrote:
> lgtm
> 
>
https://codereview.chromium.org/2642823013/diff/1/components/safe_browsing_db...
> File components/safe_browsing_db/v4_get_hash_protocol_manager.cc (right):
> 
>
https://codereview.chromium.org/2642823013/diff/1/components/safe_browsing_db...
> components/safe_browsing_db/v4_get_hash_protocol_manager.cc:122: const char
> kPhaPatternType[] = "pha_pattern_type";
> Huh, why is this one pha_PATTERN_type then? Maybe this was a mistake in the
> original public spec.
> 
>
https://codereview.chromium.org/2642823013/diff/1/components/safe_browsing_db...
> components/safe_browsing_db/v4_get_hash_protocol_manager.cc:590:
> match.threat_type() == POTENTIALLY_HARMFUL_APPLICATION) {
> Is this even possible?  I'm wondering if we can remove the
> POTENTIALLY_HARMFUL_APPLICATION and kPhaPatternType from this file -- those
are
> mobile-only terms.  We do use "pha_pattern_type" when parsing metadata from
> XLB/GMSCore, but that's here:
> 
>
https://cs.chromium.org/chromium/src/components/safe_browsing_db/safe_browsin...
> 
> At least add a TODO

Discussed offline. Will make those changes separately. Thanks.

[vakh (use Gerrit instead), 2017-01-24 23:40:35]

The CQ bit was checked by vakh@chromium.org

[commit-bot: I haz the power, 2017-01-24 23:41:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 01:15:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485301235164900, "parent_rev":
"787481e555f426d100fb24a4342206f6b8d4a1f6", "commit_rev":
"0d7499da3e2579015a187268d58863f713eec33e"}

[commit-bot: I haz the power, 2017-01-25 01:17:05]

Description was changed from

==========
XS: s/malware_pattern_type/malware_threat_type

BUG=680802
==========

to

==========
XS: s/malware_pattern_type/malware_threat_type

BUG=680802

Review-Url: https://codereview.chromium.org/2642823013
Cr-Commit-Position: refs/heads/master@{#445894}
Committed:
https://chromium.googlesource.com/chromium/src/+/0d7499da3e2579015a187268d588...
==========

[commit-bot: I haz the power, 2017-01-25 01:17:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0d7499da3e2579015a187268d588...