XS: s/malware_pattern_type/malware_threat_type

components/safe_browsing_db/v4_get_hash_protocol_manager.cc

Index: components/safe_browsing_db/v4_get_hash_protocol_manager.cc
diff --git a/components/safe_browsing_db/v4_get_hash_protocol_manager.cc b/components/safe_browsing_db/v4_get_hash_protocol_manager.cc
index f0dd8cb1db64dc605ddd4ba3910c247af468b5dd..effd0f9781405e57c24e2b2c989ba95a1012926e 100644
--- a/components/safe_browsing_db/v4_get_hash_protocol_manager.cc
+++ b/components/safe_browsing_db/v4_get_hash_protocol_manager.cc
@@ -120,7 +120,7 @@ void RecordV4GetHashCheckResult(V4GetHashCheckResultType result_type) {
 
 const char kPermission[] = "permission";
 const char kPhaPatternType[] = "pha_pattern_type";

[Nathan Parker, 2017/01/24 00:01:32]

Huh, why is this one pha_PATTERN_type then? Maybe this was a mistake in the
original public spec.  

-const char kMalwarePatternType[] = "malware_pattern_type";
+const char kMalwareThreatType[] = "malware_threat_type";
 const char kSePatternType[] = "se_pattern_type";
 const char kLanding[] = "LANDING";
 const char kDistribution[] = "DISTRIBUTION";
@@ -590,7 +590,7 @@ void V4GetHashProtocolManager::ParseMetadata(const ThreatMatch& match,
              match.threat_type() == POTENTIALLY_HARMFUL_APPLICATION) {

[Nathan Parker, 2017/01/24 00:01:32]

Is this even possible?  I'm wondering if we can remove the
POTENTIALLY_HARMFUL_APPLICATION and kPhaPatternType from this file -- those are
mobile-only terms.  We do use "pha_pattern_type" when parsing metadata from
XLB/GMSCore, but that's here:

https://cs.chromium.org/chromium/src/components/safe_browsing_db/safe_browsin...

At least add a TODO

     for (const ThreatEntryMetadata::MetadataEntry& m :
          match.threat_entry_metadata().entries()) {
-      if (m.key() == kPhaPatternType || m.key() == kMalwarePatternType) {
+      if (m.key() == kPhaPatternType || m.key() == kMalwareThreatType) {
         if (m.value() == kLanding) {
           metadata->threat_pattern_type = ThreatPatternType::MALWARE_LANDING;
           break;