Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2642683004: [headless] Ensure devtooled tests call Disable/RemoveObserver. (Closed)

Created:
3 years, 11 months ago by Eric Seckler
Modified:
3 years, 11 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, devtools-reviews_chromium.org, darin (slow to review), pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[headless] Ensure devtooled tests call Disable/RemoveObserver. Related to crbug.com/682670, where a missing RemoveObserver() call caused a segfault. For completeness, this also adds Disable() calls where they were missing. BUG= Review-Url: https://codereview.chromium.org/2642683004 Cr-Commit-Position: refs/heads/master@{#444737} Committed: https://chromium.googlesource.com/chromium/src/+/6ccdcca31bc009460bc1cacedb2ada65588ddf12

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M headless/lib/embedder_mojo_browsertest.cc View 2 chunks +7 lines, -1 line 0 comments Download
M headless/lib/headless_devtools_client_browsertest.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M headless/public/util/dom_tree_extractor_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Eric Seckler
Thanks, Alex!
3 years, 11 months ago (2017-01-19 14:54:36 UTC) #4
Eric Seckler
Thanks, Alex!
3 years, 11 months ago (2017-01-19 14:54:50 UTC) #5
alex clarke (OOO till 29th)
lgtm
3 years, 11 months ago (2017-01-19 15:00:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642683004/40001
3 years, 11 months ago (2017-01-19 15:07:43 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 15:19:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6ccdcca31bc009460bc1cacedb2a...

Powered by Google App Engine
This is Rietveld 408576698