Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: headless/public/util/dom_tree_extractor_browsertest.cc

Issue 2642683004: [headless] Ensure devtooled tests call Disable/RemoveObserver. (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/headless_devtools_client_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/public/util/dom_tree_extractor_browsertest.cc
diff --git a/headless/public/util/dom_tree_extractor_browsertest.cc b/headless/public/util/dom_tree_extractor_browsertest.cc
index 808a10b614e20dcc3618f04b2f0fc4c5796d851a..22b237960c531047398bf1d7291862cc040e431c 100644
--- a/headless/public/util/dom_tree_extractor_browsertest.cc
+++ b/headless/public/util/dom_tree_extractor_browsertest.cc
@@ -49,6 +49,7 @@ class DomTreeExtractorBrowserTest : public HeadlessAsyncDevTooledBrowserTest,
}
void OnLoadEventFired(const page::LoadEventFiredParams& params) override {
+ devtools_client_->GetPage()->Disable();
devtools_client_->GetPage()->RemoveObserver(this);
extractor_.reset(new DomTreeExtractor(devtools_client_.get()));
« no previous file with comments | « headless/lib/headless_devtools_client_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698