Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 2642463002: Implemented FormResubmissionTabHelper. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implemented FormResubmissionTabHelper. FormResubmissionTabHelper fully encapsulates the logic of Form Resubmission dialog presentation so this code can be moved to WebStateDelegate. Previously Resubmission Dialog was dismissed in webWillAddPendingURL:transition: callback. With this change dismissal happens after provisional navigation is started which should not make any noticeable difference in app behavior. BUG=674991, 681867 Review-Url: https://codereview.chromium.org/2642463002 Cr-Commit-Position: refs/heads/master@{#444382} Committed: https://chromium.googlesource.com/chromium/src/+/b721caa478257949628e2eda07bb1dd9588285ad

Patch Set 1 #

Patch Set 2 : Updated GN deps #

Total comments: 5

Patch Set 3 : Moved FormResubmissionTabHelper::CreateForWebState to init #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -25 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 1 2 8 chunks +10 lines, -25 lines 0 comments Download
M ios/chrome/browser/web/BUILD.gn View 1 3 chunks +11 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/form_resubmission_tab_helper.h View 1 chunk +45 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/form_resubmission_tab_helper.mm View 1 chunk +41 lines, -0 lines 2 comments Download
A ios/chrome/browser/web/form_resubmission_tab_helper_unittest.mm View 1 chunk +106 lines, -0 lines 0 comments Download
M ios/web/public/test/fakes/test_web_state.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/public/test/fakes/test_web_state.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (16 generated)
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-17 20:55:20 UTC) #9
rohitrao (ping after 24h)
+marq Eugene, can we use this as the example CL for figuring out how Coordinators ...
3 years, 11 months ago (2017-01-17 21:07:31 UTC) #10
Eugene But (OOO till 7-30)
Thanks! I guess this could be a reference CL if Mark agrees with the approach. ...
3 years, 11 months ago (2017-01-17 21:25:39 UTC) #11
rohitrao (ping after 24h)
https://codereview.chromium.org/2642463002/diff/20001/ios/chrome/browser/tabs/tab.mm File ios/chrome/browser/tabs/tab.mm (right): https://codereview.chromium.org/2642463002/diff/20001/ios/chrome/browser/tabs/tab.mm#newcode1696 ios/chrome/browser/tabs/tab.mm:1696: FormResubmissionTabHelper::CreateForWebState(webController.webState); On 2017/01/17 21:25:39, Eugene But wrote: > On ...
3 years, 11 months ago (2017-01-17 21:31:24 UTC) #12
rohitrao (ping after 24h)
https://codereview.chromium.org/2642463002/diff/20001/ios/chrome/browser/tabs/tab.mm File ios/chrome/browser/tabs/tab.mm (right): https://codereview.chromium.org/2642463002/diff/20001/ios/chrome/browser/tabs/tab.mm#newcode1696 ios/chrome/browser/tabs/tab.mm:1696: FormResubmissionTabHelper::CreateForWebState(webController.webState); > Form resubmission callback will move from Tab ...
3 years, 11 months ago (2017-01-17 21:32:49 UTC) #13
Eugene But (OOO till 7-30)
On 2017/01/17 21:32:49, rohitrao wrote: > https://codereview.chromium.org/2642463002/diff/20001/ios/chrome/browser/tabs/tab.mm > File ios/chrome/browser/tabs/tab.mm (right): > > https://codereview.chromium.org/2642463002/diff/20001/ios/chrome/browser/tabs/tab.mm#newcode1696 > ...
3 years, 11 months ago (2017-01-17 21:45:12 UTC) #14
Eugene But (OOO till 7-30)
Thanks! PTAL https://codereview.chromium.org/2642463002/diff/20001/ios/chrome/browser/tabs/tab.mm File ios/chrome/browser/tabs/tab.mm (right): https://codereview.chromium.org/2642463002/diff/20001/ios/chrome/browser/tabs/tab.mm#newcode1696 ios/chrome/browser/tabs/tab.mm:1696: FormResubmissionTabHelper::CreateForWebState(webController.webState); On 2017/01/17 21:31:24, rohitrao wrote: > ...
3 years, 11 months ago (2017-01-17 21:48:59 UTC) #16
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-18 00:21:19 UTC) #21
marq (ping after 24h)
LGTM in general. https://codereview.chromium.org/2642463002/diff/40001/ios/chrome/browser/web/form_resubmission_tab_helper.mm File ios/chrome/browser/web/form_resubmission_tab_helper.mm (right): https://codereview.chromium.org/2642463002/diff/40001/ios/chrome/browser/web/form_resubmission_tab_helper.mm#newcode20 ios/chrome/browser/web/form_resubmission_tab_helper.mm:20: UIViewController* top_controller = I'm fine with ...
3 years, 11 months ago (2017-01-18 11:54:19 UTC) #22
Eugene But (OOO till 7-30)
Thanks! https://codereview.chromium.org/2642463002/diff/40001/ios/chrome/browser/web/form_resubmission_tab_helper.mm File ios/chrome/browser/web/form_resubmission_tab_helper.mm (right): https://codereview.chromium.org/2642463002/diff/40001/ios/chrome/browser/web/form_resubmission_tab_helper.mm#newcode20 ios/chrome/browser/web/form_resubmission_tab_helper.mm:20: UIViewController* top_controller = On 2017/01/18 11:54:19, marq wrote: ...
3 years, 11 months ago (2017-01-18 16:13:24 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642463002/40001
3 years, 11 months ago (2017-01-18 16:14:09 UTC) #25
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 16:18:49 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b721caa478257949628e2eda07bb...

Powered by Google App Engine
This is Rietveld 408576698