Implemented FormResubmissionTabHelper.

ios/chrome/browser/tabs/tab.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/tabs/tab.h"
 
 #import <CoreLocation/CoreLocation.h>
 #import <UIKit/UIKit.h>
 
 #include <utility>
@@ skipping 56 matching lines @@
 #include "ios/chrome/browser/history/history_service_factory.h"
 #include "ios/chrome/browser/history/top_sites_factory.h"
 #include "ios/chrome/browser/infobars/infobar_manager_impl.h"
 #include "ios/chrome/browser/metrics/ios_chrome_origins_seen_service_factory.h"
 #import "ios/chrome/browser/metrics/tab_usage_recorder.h"
 #import "ios/chrome/browser/native_app_launcher/native_app_navigation_controller.h"
 #import "ios/chrome/browser/passwords/credential_manager.h"
 #import "ios/chrome/browser/passwords/js_credential_manager.h"
 #import "ios/chrome/browser/passwords/password_controller.h"
 #import "ios/chrome/browser/passwords/passwords_ui_delegate_impl.h"
+#import "ios/chrome/browser/web/form_resubmission_tab_helper.h"
 #include "ios/chrome/browser/pref_names.h"
 #include "ios/chrome/browser/reading_list/reading_list_model_factory.h"
 #include "ios/chrome/browser/reading_list/reading_list_web_state_observer.h"
 #include "ios/chrome/browser/search_engines/template_url_service_factory.h"
 #include "ios/chrome/browser/sessions/ios_chrome_session_tab_helper.h"
 #include "ios/chrome/browser/signin/account_consistency_service_factory.h"
 #include "ios/chrome/browser/signin/account_reconcilor_factory.h"
 #include "ios/chrome/browser/signin/authentication_service.h"
 #include "ios/chrome/browser/signin/authentication_service_factory.h"
 #include "ios/chrome/browser/signin/signin_capability.h"
 #import "ios/chrome/browser/snapshots/snapshot_manager.h"
 #import "ios/chrome/browser/snapshots/snapshot_overlay_provider.h"
 #import "ios/chrome/browser/snapshots/web_controller_snapshot_helper.h"
 #include "ios/chrome/browser/ssl/ios_security_state_tab_helper.h"
 #import "ios/chrome/browser/storekit_launcher.h"
 #include "ios/chrome/browser/sync/ios_chrome_synced_tab_delegate.h"
 #import "ios/chrome/browser/tabs/tab_delegate.h"
 #import "ios/chrome/browser/tabs/tab_dialog_delegate.h"
 #import "ios/chrome/browser/tabs/tab_headers_delegate.h"
 #import "ios/chrome/browser/tabs/tab_model.h"
 #import "ios/chrome/browser/tabs/tab_private.h"
 #import "ios/chrome/browser/tabs/tab_snapshotting_delegate.h"
 #include "ios/chrome/browser/translate/chrome_ios_translate_client.h"
 #import "ios/chrome/browser/u2f/u2f_controller.h"
-#import "ios/chrome/browser/ui/alert_coordinator/form_resubmission_coordinator.h"
 #import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
 #import "ios/chrome/browser/ui/commands/generic_chrome_command.h"
 #include "ios/chrome/browser/ui/commands/ios_command_ids.h"
 #import "ios/chrome/browser/ui/commands/open_url_command.h"
 #import "ios/chrome/browser/ui/commands/show_signin_command.h"
 #import "ios/chrome/browser/ui/downloads/download_manager_controller.h"
 #import "ios/chrome/browser/ui/fullscreen_controller.h"
 #import "ios/chrome/browser/ui/open_in_controller.h"
 #import "ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.h"
 #import "ios/chrome/browser/ui/prerender_delegate.h"
 #import "ios/chrome/browser/ui/reader_mode/reader_mode_checker.h"
 #import "ios/chrome/browser/ui/reader_mode/reader_mode_controller.h"
 #import "ios/chrome/browser/ui/sad_tab/sad_tab_view.h"
 #include "ios/chrome/browser/ui/ui_util.h"
-#import "ios/chrome/browser/ui/util/top_view_controller.h"
 #import "ios/chrome/browser/web/auto_reload_bridge.h"
 #import "ios/chrome/browser/web/blocked_popup_handler.h"
 #import "ios/chrome/browser/web/external_app_launcher.h"
 #include "ios/chrome/browser/web/network_activity_indicator_tab_helper.h"
 #import "ios/chrome/browser/web/passkit_dialog_provider.h"
 #include "ios/chrome/browser/web/print_observer.h"
 #import "ios/chrome/browser/xcallback_parameters.h"
 #include "ios/chrome/grit/ios_strings.h"
 #include "ios/public/provider/chrome/browser/chrome_browser_provider.h"
 #import "ios/public/provider/chrome/browser/native_app_launcher/native_app_metadata.h"
@@ skipping 163 matching lines @@
       nativeAppNavigationController_;
 
   // Handles caching and retrieving of snapshots.
   base::scoped_nsobject<SnapshotManager> snapshotManager_;
 
   // Handles retrieving, generating and updating snapshots of CRWWebController's
   // web page.
   base::scoped_nsobject<WebControllerSnapshotHelper>
       webControllerSnapshotHelper_;
 
-  // Coordinates Form Resubmission dialog presentation.
-  base::scoped_nsobject<FormResubmissionCoordinator>
-      formResubmissionCoordinator_;
-
   // Handles support for window.print JavaScript calls.
   std::unique_ptr<PrintObserver> printObserver_;
 
   // AutoReloadBridge for this tab.
   base::scoped_nsobject<AutoReloadBridge> autoReloadBridge_;
 
   // WebStateImpl for this tab.
   std::unique_ptr<web::WebStateImpl> webStateImpl_;
 
   // Allows Tab to conform CRWWebStateDelegate protocol.
@@ skipping 920 matching lines @@
     [self.webController removeObserver:fullScreenController_];
   [fullScreenController_ invalidate];
   fullScreenController_.reset();
   if (overscrollActionsController_)
     [self.webController removeObserver:overscrollActionsController_];
   [overscrollActionsController_ invalidate];
   overscrollActionsController_.reset();
   [readerModeController_ detachFromWebState];
   readerModeController_.reset();
 
-  formResubmissionCoordinator_.reset();
-
   // Invalidate any snapshot stored for this session.
   NSString* sessionID = [self currentSessionID];
   DCHECK(sessionID);
   [snapshotManager_ removeImageWithSessionID:sessionID];
   // Reset association with the webController.
   [self.webController setDelegate:nil];
   [self.webController setUIDelegate:nil];
 
   webStateImpl_->ClearTransientContentView();
   // Terminate the network activity before notifying the parent model, because
@@ skipping 437 matching lines @@
                        openedByDOM:YES
                            atIndex:TabModelConstants::kTabPositionAutomatically
                       inBackground:NO];
   return tab.webController;
 }
 
 - (void)webController:(CRWWebController*)webController
     onFormResubmissionForRequest:(NSURLRequest*)request
                    continueBlock:(ProceduralBlock)continueBlock
                      cancelBlock:(ProceduralBlock)cancelBlock {
-  UIViewController* topController =
-      top_view_controller::TopPresentedViewControllerFrom(
-          [UIApplication sharedApplication].keyWindow.rootViewController);
+  FormResubmissionTabHelper::CreateForWebState(webController.webState);

[rohitrao (ping after 24h), 2017/01/17 21:07:31]

This should go into initWithWebState, somewhere around line 575.

[Eugene But (OOO till 7-30), 2017/01/17 21:25:39]

Form resubmission callback will move from Tab to BVC (WebStateDelegate
implementation) so I wanted to move FormResubmissionTabHelper creation there as
well. Is there a reason why you would want to keep CreateForWebState call in
Tab? Maybe because you want to make this CL as a "reference CL" for
coordinator<->TabHelper interoperation? I don't have a strong preference, but
not having FormResubmissionTabHelper::CreateForWebState call in Tab seems
beneficial to me.

[rohitrao (ping after 24h), 2017/01/17 21:31:24]

I'd like to follow desktop, which has
https://cs.chromium.org/chromium/src/chrome/browser/ui/tab_helpers.cc?l=127. 
They register all of their tab helpers in one place, and that AttachTabHelpers()
method is called when a new WebContents is created by Browser.

We don't yet have an iOS equivalent for that method, so for now we're putting
all of the Create() calls into Tab's init method.  At some point we'll switch to
something that looks more like desktop, where the code that creates a Tab (later
WebState) calls Attach().

[rohitrao (ping after 24h), 2017/01/17 21:32:49]

This object needs to be one-per-WebState, right?  Not one-per-BrowserState?

[Eugene But (OOO till 7-30), 2017/01/17 21:48:59]

I see. This makes total sense. Moved
FormResubmissionTabHelper::CreateForWebState to init.

 
   // Display the action sheet with the arrow pointing at the top center of the
   // web contents.
   CGPoint dialogLocation =
       CGPointMake(CGRectGetMidX(webController.view.frame),
                   CGRectGetMinY(webController.view.frame) +
                       [self.tabHeadersDelegate headerHeightForTab:self]);
-
-  formResubmissionCoordinator_.reset([[FormResubmissionCoordinator alloc]
-      initWithBaseViewController:topController
-                  dialogLocation:dialogLocation
-                        webState:webController.webState
-               completionHandler:^(BOOL shouldContinue) {
-                 if (shouldContinue)
-                   continueBlock();
-                 else
-                   cancelBlock();
-               }]);
-  [formResubmissionCoordinator_ start];
+  auto helper = FormResubmissionTabHelper::FromWebState(webController.webState);
+  helper->PresentFormResubmissionDialog(dialogLocation,
+                                        base::BindBlock(^(bool shouldContinue) {
+                                          if (shouldContinue)
+                                            continueBlock();
+                                          else
+                                            cancelBlock();
+                                        }));
 }
 
 // The web page wants to close its own window.
 - (void)webPageOrderedClose {
   // Only allow a web page to close itself if it was opened by DOM, or if there
   // are no navigation items.
   DCHECK([[self navigationManager]->GetSessionController() isOpenedByDOM] ||
          ![self navigationManager]->GetItemCount());
   [self closeThisTab];
 }
 
 // This method is invoked whenever the system believes the URL is about to
 // change, or immediately after any unexpected change of the URL. The apparent
 // destination URL is included in the |url| parameter.
 // Warning: because of the present design it is possible for malicious websites
 // to invoke superflous instances of this delegate with artibrary URLs.
 // Ensure there is nothing here that could be a risk to the user beyond mild
 // confusion in that event (e.g. progress bar starting unexpectedly).
 - (void)webWillAddPendingURL:(const GURL&)url
                   transition:(ui::PageTransition)transition {
   DCHECK(self.webController.loadPhase == web::LOAD_REQUESTED);
   DCHECK([self navigationManager]);
-  formResubmissionCoordinator_.reset();
 
   // Move the toolbar to visible during page load.
   [fullScreenController_ disableFullScreen];
 
   isUserNavigationEvent_ =
       (transition & ui::PAGE_TRANSITION_IS_REDIRECT_MASK) == 0;
   // Check for link-follow clobbers. These are changes where there is no
   // pending entry (since that means the change wasn't caused by this class),
   // and where the URL changes (to avoid counting page resurrection).
   // TODO(crbug.com/546401): Consider moving this into NavigationManager, or
@@ skipping 617 matching lines @@
 
 - (TabModel*)parentTabModel {
   return parentTabModel_;
 }
 
 - (FormInputAccessoryViewController*)inputAccessoryViewController {
   return inputAccessoryViewController_.get();
 }
 
 @end