Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2642373002: Clarify requirements for third-party additions (Closed)

Created:
3 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify requirements for third-party additions R=ben@chromium.org BUG= Review-Url: https://codereview.chromium.org/2642373002 Cr-Commit-Position: refs/heads/master@{#447342} Committed: https://chromium.googlesource.com/chromium/src/+/893d5184aad6e4a88fa7e46b11202d1a4a7f3009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M docs/adding_to_third_party.md View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
jochen (gone - plz use gerrit)
3 years, 11 months ago (2017-01-20 13:27:06 UTC) #1
brettw
lgtm
3 years, 10 months ago (2017-01-31 20:24:39 UTC) #5
Ben Goodger (Google)
On 2017/01/31 20:24:39, brettw (ping after 24h) wrote: > lgtm lgtm2
3 years, 10 months ago (2017-01-31 20:47:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642373002/1
3 years, 10 months ago (2017-01-31 21:41:06 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 22:04:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/893d5184aad6e4a88fa7e46b1120...

Powered by Google App Engine
This is Rietveld 408576698