Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: docs/adding_to_third_party.md

Issue 2642373002: Clarify requirements for third-party additions (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/adding_to_third_party.md
diff --git a/docs/adding_to_third_party.md b/docs/adding_to_third_party.md
index 89b9ff19e020c61194edee882a55f9d7d2103b45..02bc23503484c191876fa1fbaccc891dde1eec62 100644
--- a/docs/adding_to_third_party.md
+++ b/docs/adding_to_third_party.md
@@ -126,12 +126,14 @@ All third party additions and substantive changes like re-licensing need the
following sign-offs. Some of these are accessible to Googlers only. Non-Googlers
can email one of the people in third_party/OWNERS for help.
-* Chrome Eng Review. Googlers should see go/chrome-eng-review
+* Chrome Eng Review. Googlers should see go/chrome-eng-review (please include information about the additional checkout size, build times, and binary sizes. Please also make sure that the motivation for your project is clear, e.g., a design doc has been circulated).
* open-source-third-party-reviews@google.com (ping the list with relevant
details and a link to the CL).
* security@chromium.org (ping the list with relevant details and a link to the
CL).
+Please send separate emails to the three lists.
+
Third party code is a hot spot for security vulnerabilities. When adding a new
package that could potentially carry security risk, make sure to highlight risk
to security@chromium.org. You may be asked to add a README.security or, in
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698