Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2642263005: Fix fullscreen browser overrides when no tab is present. (Closed)

Created:
3 years, 11 months ago by Ted C
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix fullscreen browser overrides when no tab is present. If a client requests the top controls be made visible via the BrowserStateBrowserControlsVisibilityDelegate but no tabs are available, the fullscreen manager should force the controls to be visible anyway. This fixes an issue where you only have a single incognito tab, scroll off the top controls, then hit the close all incognito tabs notification. At this point, you are jumped back to the tab switcher but the controls were not being shown without this additional logic. BUG=675518 Review-Url: https://codereview.chromium.org/2647943002 Cr-Original-Commit-Position: refs/heads/master@{#445157} Review-Url: https://codereview.chromium.org/2642263005 . Cr-Commit-Position: refs/branch-heads/2987@{#8} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/44310667eedd4953655d14377c2ce34b9257e91b

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Ted C
3 years, 11 months ago (2017-01-20 21:17:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
44310667eedd4953655d14377c2ce34b9257e91b.

Powered by Google App Engine
This is Rietveld 408576698