Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2647943002: Fix fullscreen browser overrides when no tab is present. (Closed)

Created:
3 years, 11 months ago by Ted C
Modified:
3 years, 11 months ago
Reviewers:
mdjones
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix fullscreen browser overrides when no tab is present. If a client requests the top controls be made visible via the BrowserStateBrowserControlsVisibilityDelegate but no tabs are available, the fullscreen manager should force the controls to be visible anyway. This fixes an issue where you only have a single incognito tab, scroll off the top controls, then hit the close all incognito tabs notification. At this point, you are jumped back to the tab switcher but the controls were not being shown without this additional logic. BUG=675518 Review-Url: https://codereview.chromium.org/2647943002 Cr-Commit-Position: refs/heads/master@{#445157} Committed: https://chromium.googlesource.com/chromium/src/+/c5be519e4e6afeed39e9b8f94dc46731cd844997

Patch Set 1 #

Messages

Total messages: 8 (4 generated)
Ted C
PTAL
3 years, 11 months ago (2017-01-20 18:52:37 UTC) #2
mdjones
lgtm
3 years, 11 months ago (2017-01-20 19:56:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647943002/1
3 years, 11 months ago (2017-01-20 20:14:12 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 20:54:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c5be519e4e6afeed39e9b8f94dc4...

Powered by Google App Engine
This is Rietveld 408576698