Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2642253002: Revert of Enable BrowserScheduler.RedirectHistoryService experiment on trunk. (Closed)

Created:
3 years, 11 months ago by gab
Modified:
3 years, 11 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, fdoray
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable BrowserScheduler.RedirectHistoryService experiment on trunk. (patchset #7 id:140001 of https://codereview.chromium.org/2592813002/ ) Reason for revert: Suspected culprit http://crbug.com/680698 and http://crbug.com/682219 per HistoryService tasks no longer being guaranteed to be flushed in ~HistoryService -- which BookmarksModel depends on. Original issue's description: > Enable BrowserScheduler.RedirectHistoryService experiment on trunk. > > BUG=661143 > Committed: https://crrev.com/4aa30591e0953da7e0c54ffdb91856e496d16b5f > Cr-Commit-Position: refs/heads/master@{#440418} > > Reverted: https://crrev.com/2885403f92c9ab0a8769c2c41e859502da5a7e6f > Cr-Commit-Position: refs/heads/master@{#440479} > Cause of revert fixed in https://codereview.chromium.org/2611053003/. > > Review-Url: https://codereview.chromium.org/2592813002 > Cr-Commit-Position: refs/heads/master@{#441997} > Committed: https://chromium.googlesource.com/chromium/src/+/344517411399fc467e5a6938e4793650729b3506 TBR=rkaplow@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=661143, 680698, 682219 Review-Url: https://codereview.chromium.org/2642253002 Cr-Commit-Position: refs/heads/master@{#444942} Committed: https://chromium.googlesource.com/chromium/src/+/8f3596ad8588a28907ccfca0f9c9af984e3c5681

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M testing/variations/fieldtrial_testing_config.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (6 generated)
gab
Created Revert of Enable BrowserScheduler.RedirectHistoryService experiment on trunk.
3 years, 11 months ago (2017-01-20 00:22:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642253002/1
3 years, 11 months ago (2017-01-20 00:23:50 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 01:56:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8f3596ad8588a28907ccfca0f9c9...

Powered by Google App Engine
This is Rietveld 408576698