Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

BUG=661143
Committed: https://crrev.com/4aa30591e0953da7e0c54ffdb91856e496d16b5f
Cr-Commit-Position: refs/heads/master@{#440418}

Reverted: https://crrev.com/2885403f92c9ab0a8769c2c41e859502da5a7e6f
Cr-Commit-Position: refs/heads/master@{#440479}
Cause of revert fixed in https://codereview.chromium.org/2611053003/.

Review-Url: https://codereview.chromium.org/2592813002
Cr-Commit-Position: refs/heads/master@{#441997}
Committed: https://chromium.googlesource.com/chromium/src/+/344517411399fc467e5a6938e4793650729b3506

[gab, 2016-12-20 20:23:18]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 20:23:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-12-20 20:23:58]

gab@chromium.org changed reviewers:
+ rkaplow@chromium.org

[gab, 2016-12-20 20:23:59]

Rob PTAL, thanks!

[commit-bot: I haz the power, 2016-12-20 21:01:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 21:01:16]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[gab, 2016-12-20 21:33:38]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2016-12-20 21:33:45]

The CQ bit was unchecked by gab@chromium.org

[rkaplow, 2016-12-20 21:36:53]

lgtm

[gab, 2016-12-21 14:51:12]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 14:51:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-12-21 14:51:52]

Description was changed from

==========
Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

BUG=661143
==========

to

==========
Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

Add .WithSyncPrimitives() trait to history service's backend
TaskRunner. Required by ChromeHistoryBackendClient::IsBookmarked().

BUG=661143
==========

[gab, 2016-12-21 15:23:29]

gab@chromium.org changed reviewers:
+ sky@chromium.org

[gab, 2016-12-21 15:23:29]

TBR sky for addition of .WithSyncPrimitives() in history_service.cc. The history
thread was already allowed to wait so this is no different than before, it
merely makes AssertWaitAllowed() pass on the redirected sequence.

[gab, 2016-12-21 15:23:51]

The CQ bit was unchecked by gab@chromium.org

[gab, 2016-12-21 15:24:16]

Description was changed from

==========
Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

Add .WithSyncPrimitives() trait to history service's backend
TaskRunner. Required by ChromeHistoryBackendClient::IsBookmarked().

BUG=661143
==========

to

==========
Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

Add .WithSyncPrimitives() trait to history service's backend
TaskRunner. Required by ChromeHistoryBackendClient::IsBookmarked().

BUG=661143
TBR=sky@chromium.org (history_service.cc tweak to experiment)
==========

[gab, 2016-12-21 15:24:24]

The CQ bit was checked by gab@chromium.org

[gab, 2016-12-21 15:24:24]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2592813002/#ps20001
(title: "Add .WithSyncPrimitives() trait to history service's backend
TaskRunner.")

[commit-bot: I haz the power, 2016-12-21 15:24:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 15:24:53]

This CL has an open dependency (Issue 2593803002 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[gab, 2016-12-21 15:26:23]

The CQ bit was unchecked by gab@chromium.org

[gab, 2016-12-21 15:31:22]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 15:31:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 16:17:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 16:17:08]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[gab, 2016-12-21 16:20:41]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 16:21:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 16:26:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 16:26:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gab, 2016-12-21 16:36:03]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 16:36:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 17:54:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 17:54:57]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gab, 2016-12-21 20:20:46]

The CQ bit was checked by gab@chromium.org

[gab, 2016-12-21 20:20:47]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2592813002/#ps40001
(title: "update dependencies")

[commit-bot: I haz the power, 2016-12-21 20:21:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 21:31:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 21:31:18]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gab, 2016-12-21 21:56:18]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 21:56:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 22:04:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 22:04:59]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[gab, 2016-12-22 01:45:29]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 01:45:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-12-22 01:49:44]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 01:49:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-12-22 01:51:22]

Patchset #6 (id:100001) has been deleted

[commit-bot: I haz the power, 2016-12-22 01:52:31]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2016-12-22 01:53:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 01:53:52]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[gab, 2016-12-22 14:16:32]

The CQ bit was checked by gab@chromium.org

[gab, 2016-12-22 14:16:32]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2592813002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-22 14:16:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 15:04:33]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1482416192292260,
"parent_rev": "dde9b4d547559a98d79ae1aa44838af119078a2c", "commit_rev":
"34603d1727b94b860a384996a3699094841cb395"}

[commit-bot: I haz the power, 2016-12-22 15:04:59]

Description was changed from

==========
Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

Add .WithSyncPrimitives() trait to history service's backend
TaskRunner. Required by ChromeHistoryBackendClient::IsBookmarked().

BUG=661143
TBR=sky@chromium.org (history_service.cc tweak to experiment)
==========

to

==========
Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

Add .WithSyncPrimitives() trait to history service's backend
TaskRunner. Required by ChromeHistoryBackendClient::IsBookmarked().

BUG=661143
TBR=sky@chromium.org (history_service.cc tweak to experiment)

Review-Url: https://codereview.chromium.org/2592813002
==========

[commit-bot: I haz the power, 2016-12-22 15:05:00]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-12-22 15:08:46]

Description was changed from

==========
Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

Add .WithSyncPrimitives() trait to history service's backend
TaskRunner. Required by ChromeHistoryBackendClient::IsBookmarked().

BUG=661143
TBR=sky@chromium.org (history_service.cc tweak to experiment)

Review-Url: https://codereview.chromium.org/2592813002
==========

to

==========
Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

Add .WithSyncPrimitives() trait to history service's backend
TaskRunner. Required by ChromeHistoryBackendClient::IsBookmarked().

BUG=661143
TBR=sky@chromium.org (history_service.cc tweak to experiment)

Committed: https://crrev.com/4aa30591e0953da7e0c54ffdb91856e496d16b5f
Cr-Commit-Position: refs/heads/master@{#440418}
==========

[commit-bot: I haz the power, 2016-12-22 15:08:47]

Patchset 6 (id:??) landed as
https://crrev.com/4aa30591e0953da7e0c54ffdb91856e496d16b5f
Cr-Commit-Position: refs/heads/master@{#440418}

[hcarmona, 2016-12-22 19:43:57]

A revert of this CL (patchset #6 id:120001) has been created in
https://codereview.chromium.org/2597013005/ by hcarmona@chromium.org.

The reason for reverting is: Suspecting this CL of causing test failures:
  ProfileBrowserTest.CreateNewProfileSynchronous
  ProfileBrowserTest.OffTheRecordURLRequestContextIsolation
  ProfileBrowserTest.CreateOldProfileSynchronous
  ProfileBrowserTest.ExitType

b/c error messages mention HistoryBackend

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%20....

[gab, 2017-01-06 16:55:09]

Description was changed from

==========
Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

Add .WithSyncPrimitives() trait to history service's backend
TaskRunner. Required by ChromeHistoryBackendClient::IsBookmarked().

BUG=661143
TBR=sky@chromium.org (history_service.cc tweak to experiment)

Committed: https://crrev.com/4aa30591e0953da7e0c54ffdb91856e496d16b5f
Cr-Commit-Position: refs/heads/master@{#440418}
==========

to

==========
Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

Add .WithSyncPrimitives() trait to history service's backend
TaskRunner. Required by ChromeHistoryBackendClient::IsBookmarked().

BUG=661143
TBR=sky@chromium.org (history_service.cc tweak to experiment)

Committed: https://crrev.com/4aa30591e0953da7e0c54ffdb91856e496d16b5f
Cr-Commit-Position: refs/heads/master@{#440418}

Cause of revert fixed in https://codereview.chromium.org/2611053003/.
==========

[gab, 2017-01-06 16:55:16]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-01-06 16:55:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 16:57:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 16:57:42]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[gab, 2017-01-06 17:17:31]

Description was changed from

==========
Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

Add .WithSyncPrimitives() trait to history service's backend
TaskRunner. Required by ChromeHistoryBackendClient::IsBookmarked().

BUG=661143
TBR=sky@chromium.org (history_service.cc tweak to experiment)

Committed: https://crrev.com/4aa30591e0953da7e0c54ffdb91856e496d16b5f
Cr-Commit-Position: refs/heads/master@{#440418}

Cause of revert fixed in https://codereview.chromium.org/2611053003/.
==========

to

==========
Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

BUG=661143
Committed: https://crrev.com/4aa30591e0953da7e0c54ffdb91856e496d16b5f
Cr-Commit-Position: refs/heads/master@{#440418}

Cause of revert fixed in https://codereview.chromium.org/2611053003/.
==========

[gab, 2017-01-06 17:17:31]

gab@chromium.org changed reviewers:
- sky@chromium.org

[gab, 2017-01-06 17:18:42]

Description was changed from

==========
Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

BUG=661143
Committed: https://crrev.com/4aa30591e0953da7e0c54ffdb91856e496d16b5f
Cr-Commit-Position: refs/heads/master@{#440418}

Cause of revert fixed in https://codereview.chromium.org/2611053003/.
==========

to

==========
Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

BUG=661143
Committed: https://crrev.com/4aa30591e0953da7e0c54ffdb91856e496d16b5f
Cr-Commit-Position: refs/heads/master@{#440418}

Reverted: https://crrev.com/2885403f92c9ab0a8769c2c41e859502da5a7e6f
Cr-Commit-Position: refs/heads/master@{#440479}
Cause of revert fixed in https://codereview.chromium.org/2611053003/.
==========

[gab, 2017-01-06 17:19:02]

The CQ bit was checked by gab@chromium.org

[gab, 2017-01-06 17:19:03]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2592813002/#ps140001
(title: "merge up to r441948")

[commit-bot: I haz the power, 2017-01-06 17:19:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 18:58:31]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1483723142918300,
"parent_rev": "e344cf0c658526a278eeae8817026b1a032b5633", "commit_rev":
"344517411399fc467e5a6938e4793650729b3506"}

[commit-bot: I haz the power, 2017-01-06 18:59:00]

Description was changed from

==========
Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

BUG=661143
Committed: https://crrev.com/4aa30591e0953da7e0c54ffdb91856e496d16b5f
Cr-Commit-Position: refs/heads/master@{#440418}

Reverted: https://crrev.com/2885403f92c9ab0a8769c2c41e859502da5a7e6f
Cr-Commit-Position: refs/heads/master@{#440479}
Cause of revert fixed in https://codereview.chromium.org/2611053003/.
==========

to

==========
Enable BrowserScheduler.RedirectHistoryService experiment on trunk.

BUG=661143
Committed: https://crrev.com/4aa30591e0953da7e0c54ffdb91856e496d16b5f
Cr-Commit-Position: refs/heads/master@{#440418}

Reverted: https://crrev.com/2885403f92c9ab0a8769c2c41e859502da5a7e6f
Cr-Commit-Position: refs/heads/master@{#440479}
Cause of revert fixed in https://codereview.chromium.org/2611053003/.

Review-Url: https://codereview.chromium.org/2592813002
Cr-Commit-Position: refs/heads/master@{#441997}
Committed:
https://chromium.googlesource.com/chromium/src/+/344517411399fc467e5a6938e479...
==========

[commit-bot: I haz the power, 2017-01-06 18:59:02]

Committed patchset #7 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/344517411399fc467e5a6938e479...

[gab, 2017-01-20 00:22:33]

A revert of this CL (patchset #7 id:140001) has been created in
https://codereview.chromium.org/2642253002/ by gab@chromium.org.

The reason for reverting is: Suspected culprit http://crbug.com/680698 and
http://crbug.com/682219 per HistoryService tasks no longer being guaranteed to
be flushed in ~HistoryService -- which BookmarksModel depends on..