Unify all types of overflow-related clips for paint and hit testing.

Unify all types of overflow-related clips for paint and hit testing.

This patch:
* Centralizes business logic around clipping overflow into LayoutBox
instead of spread across paint layer, box and property tree use-cases for painting/
hit-testing.

* Makes control clip a kind of overflow clip.

Now shouldClipOverflow() and overflowClipRect() apply overflow and control clipping
for overflow:hidden/scroll CSS, contain: paint, control clip and SVG viewport
overflow clipping.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2642193011
Cr-Commit-Position: refs/heads/master@{#445503}
Committed: https://chromium.googlesource.com/chromium/src/+/aa907828b27ae82aeb95be2f86d35d03cc67dc54

[chrishtr, 2017-01-21 00:19:18]

Description was changed from

==========
none


none


none

BUG=
==========

to

==========
none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-01-21 00:19:42]

Description was changed from

==========
none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fully unify control, SVG and overflow clips for all use cases.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-01-21 00:26:12]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-21 00:26:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 01:14:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 01:14:07]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[chrishtr, 2017-01-21 04:40:28]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-01-21 04:40:32]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-01-21 04:51:52]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-21 04:52:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 05:34:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 05:34:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2017-01-21 17:46:59]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-21 17:47:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 18:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 18:52:53]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2017-01-21 22:36:21]

Description was changed from

==========
Fully unify control, SVG and overflow clips for all use cases.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Unify all types of overflow-related clips for paint and hit testing.

This patch:
* Centralizes business logic around clipping overflow into LayoutBox
instead of spread across paint layer, box and property tree use-cases for
painting/
hit-testing.

* Makes control clip a kind of overflow clip.

Now shouldClipOverflow() and overflowClipRect() apply overflow and control
clipping
for overflow:hidden/scroll CSS, contain: paint, control clip and SVG viewport
overflow clipping.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-01-22 00:13:58]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-22 00:14:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-22 01:10:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-22 01:10:17]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[chrishtr, 2017-01-22 04:42:50]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-22 04:42:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-22 06:56:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-22 06:56:11]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2017-01-22 17:38:48]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-22 17:38:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-01-22 18:58:59]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[commit-bot: I haz the power, 2017-01-22 20:12:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-22 20:12:28]

Dry run: This issue passed the CQ dry run.

[pdr., 2017-01-23 18:46:12]

Great change! Much like. One question

https://codereview.chromium.org/2642193011/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2642193011/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:1795: if (hasControlClip())
I think this needs to be after excludeScrollbars.

[chrishtr, 2017-01-23 18:53:19]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-01-23 18:53:20]

https://codereview.chromium.org/2642193011/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2642193011/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:1795: if (hasControlClip())
On 2017/01/23 at 18:46:12, pdr. wrote:
> I think this needs to be after excludeScrollbars.

DONE!!!

[chrishtr, 2017-01-23 18:53:22]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-01-23 18:53:28]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[pdr., 2017-01-23 18:54:04]

On 2017/01/23 at 18:53:20, chrishtr wrote:
>
https://codereview.chromium.org/2642193011/diff/180001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):
> 
>
https://codereview.chromium.org/2642193011/diff/180001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/layout/LayoutBox.cpp:1795: if
(hasControlClip())
> On 2017/01/23 at 18:46:12, pdr. wrote:
> > I think this needs to be after excludeScrollbars.
> 
> DONE!!!

LGTM!!

[commit-bot: I haz the power, 2017-01-23 18:54:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 21:51:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 21:51:09]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2017-01-23 21:54:56]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-01-23 21:55:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 22:01:10]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1485208496871540,
"parent_rev": "9bbd8e05d86dba5969b84ebfbedf3d53ee2437ce", "commit_rev":
"aa907828b27ae82aeb95be2f86d35d03cc67dc54"}

[commit-bot: I haz the power, 2017-01-23 22:01:41]

Description was changed from

==========
Unify all types of overflow-related clips for paint and hit testing.

This patch:
* Centralizes business logic around clipping overflow into LayoutBox
instead of spread across paint layer, box and property tree use-cases for
painting/
hit-testing.

* Makes control clip a kind of overflow clip.

Now shouldClipOverflow() and overflowClipRect() apply overflow and control
clipping
for overflow:hidden/scroll CSS, contain: paint, control clip and SVG viewport
overflow clipping.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Unify all types of overflow-related clips for paint and hit testing.

This patch:
* Centralizes business logic around clipping overflow into LayoutBox
instead of spread across paint layer, box and property tree use-cases for
painting/
hit-testing.

* Makes control clip a kind of overflow clip.

Now shouldClipOverflow() and overflowClipRect() apply overflow and control
clipping
for overflow:hidden/scroll CSS, contain: paint, control clip and SVG viewport
overflow clipping.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2642193011
Cr-Commit-Position: refs/heads/master@{#445503}
Committed:
https://chromium.googlesource.com/chromium/src/+/aa907828b27ae82aeb95be2f86d3...
==========

[commit-bot: I haz the power, 2017-01-23 22:01:42]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/aa907828b27ae82aeb95be2f86d3...