third_party/WebKit/Source/core/paint/BlockPainter.cpp - Issue 2642193011: Unify all types of overflow-related clips for paint and hit testing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/BlockPainter.cpp

Issue 2642193011: Unify all types of overflow-related clips for paint and hit testing. (Closed)

Patch Set: none Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/BlockPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/BlockPainter.cpp b/third_party/WebKit/Source/core/paint/BlockPainter.cpp

index c17939e17e86c1b9a69b32fe410eae55c1d3eca3..a6154a5a7b35cb8668c9b18ae76c2babab9c7f58 100644

--- a/third_party/WebKit/Source/core/paint/BlockPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/BlockPainter.cpp

@@ -42,7 +42,7 @@ void BlockPainter::paint(const PaintInfo& paintInfo,

// for.

// FIXME: reduce the number of such cases.

ContentsClipBehavior contentsClipBehavior = ForceContentsClip;

- if (m_layoutBlock.hasOverflowClip() && !m_layoutBlock.hasControlClip() &&

+ if (m_layoutBlock.shouldClipOverflow() && !m_layoutBlock.hasControlClip() &&

!m_layoutBlock.hasCaret())

contentsClipBehavior = SkipContentsClipIfPossible;