Fix surface reference assumptions in SurfaceManager.

Fix surface reference assumptions in SurfaceManager.

The original plan was to use the surface reference graph plus
SurfaceSequences to help migrate code to use surface reference graph.
That doesn't look to be necessary and/or workable now so cleanup
SurfaceMananger.

1. Remove checking count of surface references in the surface reference
   graph. We won't add references if we are using the old system.
2. If a surface drops to having 0 incoming references, don't delete all
   references it holds. We are doing garbage collection via top-level
   root, so there is no need to cleanup references. This wouldn't work
   if a cycle got introduced anyways.
3. Add cleanup of references when a surface is deleted. Since (2) no
   longer happens we have to cleanup references on delete.
4. Cleanup unit tests. The older tests are improved to actually check
   the specific references exist instead of just having the right
   number. Also fix some style differences across new + old tests to
   make them easier to read.

This also sets things up to remove the SurfaceReferenceManager interface
that is now unused.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2642123004
Cr-Commit-Position: refs/heads/master@{#446053}
Committed: https://chromium.googlesource.com/chromium/src/+/43117a2e3860fed908e46bed85624b17358fe63b

[kylechar, 2017-01-20 21:41:00]

Description was changed from

==========
Fix surface reference assumptions in SurfaceManager.

The original plan was to mix new surface references and old
SurfaceSequence dependencies code in chrome to aid in migration. That
doesn't look to be necessary or workable now, so cleanup SurfaceMananger
so it's either using the old system or the new system, not both.


BUG=
==========

to

==========
Fix surface reference assumptions in SurfaceManager.

The original plan was to mix new surface references and old
SurfaceSequence dependencies code in chrome to aid in migration. That
doesn't look to be necessary or workable now, so cleanup SurfaceMananger
so it's either using the old system or the new system, not both.


BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[kylechar, 2017-01-24 18:16:51]

Description was changed from

==========
Fix surface reference assumptions in SurfaceManager.

The original plan was to mix new surface references and old
SurfaceSequence dependencies code in chrome to aid in migration. That
doesn't look to be necessary or workable now, so cleanup SurfaceMananger
so it's either using the old system or the new system, not both.


BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Fix surface reference assumptions in SurfaceManager.

The original plan was to use the surface reference graph plus
SurfaceSequences to help migrate code to use surface reference graph.
That doesn't look to be necessary and/or workable now so cleanup
SurfaceMananger.

1. Remove checking count of surface references in the surface reference
   graph. We won't add references if we are using the old system.
2. If a surface drops to having 0 incoming references, don't delete all
   references it holds. We are doing garbage collection via top-level
   root, so there is no need to cleanup references. This wouldn't work
   if a cycle got introduced anyways.
3. Add cleanup of references when a surface is deleted. Since (2) no
   longer happens we have to cleanup references on delete.
4. Cleanup unit tests. The older tests are improved to actually check
   the specific references exist instead of just having the right
   number. Also fix some style differences across new + old tests to
   make them easier to read.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[kylechar, 2017-01-24 18:20:09]

Description was changed from

==========
Fix surface reference assumptions in SurfaceManager.

The original plan was to use the surface reference graph plus
SurfaceSequences to help migrate code to use surface reference graph.
That doesn't look to be necessary and/or workable now so cleanup
SurfaceMananger.

1. Remove checking count of surface references in the surface reference
   graph. We won't add references if we are using the old system.
2. If a surface drops to having 0 incoming references, don't delete all
   references it holds. We are doing garbage collection via top-level
   root, so there is no need to cleanup references. This wouldn't work
   if a cycle got introduced anyways.
3. Add cleanup of references when a surface is deleted. Since (2) no
   longer happens we have to cleanup references on delete.
4. Cleanup unit tests. The older tests are improved to actually check
   the specific references exist instead of just having the right
   number. Also fix some style differences across new + old tests to
   make them easier to read.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Fix surface reference assumptions in SurfaceManager.

The original plan was to use the surface reference graph plus
SurfaceSequences to help migrate code to use surface reference graph.
That doesn't look to be necessary and/or workable now so cleanup
SurfaceMananger.

1. Remove checking count of surface references in the surface reference
   graph. We won't add references if we are using the old system.
2. If a surface drops to having 0 incoming references, don't delete all
   references it holds. We are doing garbage collection via top-level
   root, so there is no need to cleanup references. This wouldn't work
   if a cycle got introduced anyways.
3. Add cleanup of references when a surface is deleted. Since (2) no
   longer happens we have to cleanup references on delete.
4. Cleanup unit tests. The older tests are improved to actually check
   the specific references exist instead of just having the right
   number. Also fix some style differences across new + old tests to
   make them easier to read.

This also sets things up to remove the SurfaceReferenceManager interface
that is now unused.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[kylechar, 2017-01-24 18:22:40]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 18:23:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-01-24 18:23:57]

kylechar@chromium.org changed reviewers:
+ danakj@chromium.org, fsamuel@chromium.org

[kylechar, 2017-01-24 18:23:58]

+danakj for review
+fsamuel FYI

[commit-bot: I haz the power, 2017-01-24 19:05:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 19:05:52]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[danakj, 2017-01-24 19:25:38]

danakj@chromium.org changed reviewers:
+ jbauman@chromium.org
- danakj@chromium.org

[danakj, 2017-01-24 19:25:38]

Passing to jbauman, lmk if that's not good

[jbauman, 2017-01-24 20:53:11]

lgtm

[kylechar, 2017-01-25 16:42:04]

Thanks!

[kylechar, 2017-01-25 16:42:08]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 16:42:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 17:39:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 17:39:05]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-01-25 17:39:32]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-01-25 17:39:32]

The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2642123004/#ps40001
(title: "Rebase + fix test.")

[commit-bot: I haz the power, 2017-01-25 17:40:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 17:46:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485365972695090,
"parent_rev": "ccb90539d5af550d7e753984fc79efd62f6495f9", "commit_rev":
"43117a2e3860fed908e46bed85624b17358fe63b"}

[commit-bot: I haz the power, 2017-01-25 17:46:33]

Description was changed from

==========
Fix surface reference assumptions in SurfaceManager.

The original plan was to use the surface reference graph plus
SurfaceSequences to help migrate code to use surface reference graph.
That doesn't look to be necessary and/or workable now so cleanup
SurfaceMananger.

1. Remove checking count of surface references in the surface reference
   graph. We won't add references if we are using the old system.
2. If a surface drops to having 0 incoming references, don't delete all
   references it holds. We are doing garbage collection via top-level
   root, so there is no need to cleanup references. This wouldn't work
   if a cycle got introduced anyways.
3. Add cleanup of references when a surface is deleted. Since (2) no
   longer happens we have to cleanup references on delete.
4. Cleanup unit tests. The older tests are improved to actually check
   the specific references exist instead of just having the right
   number. Also fix some style differences across new + old tests to
   make them easier to read.

This also sets things up to remove the SurfaceReferenceManager interface
that is now unused.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Fix surface reference assumptions in SurfaceManager.

The original plan was to use the surface reference graph plus
SurfaceSequences to help migrate code to use surface reference graph.
That doesn't look to be necessary and/or workable now so cleanup
SurfaceMananger.

1. Remove checking count of surface references in the surface reference
   graph. We won't add references if we are using the old system.
2. If a surface drops to having 0 incoming references, don't delete all
   references it holds. We are doing garbage collection via top-level
   root, so there is no need to cleanup references. This wouldn't work
   if a cycle got introduced anyways.
3. Add cleanup of references when a surface is deleted. Since (2) no
   longer happens we have to cleanup references on delete.
4. Cleanup unit tests. The older tests are improved to actually check
   the specific references exist instead of just having the right
   number. Also fix some style differences across new + old tests to
   make them easier to read.

This also sets things up to remove the SurfaceReferenceManager interface
that is now unused.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2642123004
Cr-Commit-Position: refs/heads/master@{#446053}
Committed:
https://chromium.googlesource.com/chromium/src/+/43117a2e3860fed908e46bed8562...
==========

[commit-bot: I haz the power, 2017-01-25 17:46:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/43117a2e3860fed908e46bed8562...