Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2641873002: Suppress linker warnings for cctests (Closed)

Created:
3 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Suppress linker warnings for cctests R=machenbach@chromium.org,eholk@chromium.org BUG= Review-Url: https://codereview.chromium.org/2641873002 Cr-Commit-Position: refs/heads/master@{#42457} Committed: https://chromium.googlesource.com/v8/v8/+/29526d96a65741b35952d940baa987225cf46456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M test/cctest/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
jochen (gone - plz use gerrit)
3 years, 11 months ago (2017-01-18 13:44:58 UTC) #1
Michael Achenbach
lgtm
3 years, 11 months ago (2017-01-18 13:58:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641873002/1
3 years, 11 months ago (2017-01-18 14:12:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/29526d96a65741b35952d940baa987225cf46456
3 years, 11 months ago (2017-01-18 14:14:51 UTC) #11
Eric Holk
3 years, 11 months ago (2017-01-18 19:30:03 UTC) #12
Message was sent while issue was closed.
Thanks, this fixed the issue I was having!

Powered by Google App Engine
This is Rietveld 408576698