Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/BUILD.gn

Issue 2641873002: Suppress linker warnings for cctests (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/BUILD.gn
diff --git a/test/cctest/BUILD.gn b/test/cctest/BUILD.gn
index 54e733c2dced3b4aa4fb293c043785e6d309d767..e02d238ddebdf23b4f714658f780b7efd8a725de 100644
--- a/test/cctest/BUILD.gn
+++ b/test/cctest/BUILD.gn
@@ -360,7 +360,12 @@ v8_executable("cctest") {
# crbug.com/676417: Suppress symbol import warning from linker.
if (is_win && is_component_build) {
- ldflags = [ "/ignore:4217" ]
+ ldflags += [
+ "/ignore:4217",
+ "/ignore:4049",
+ ]
+ remove_configs = [ "//build/config/win:default_incremental_linking" ]
+ configs += [ "//build/config/win:no_incremental_linking" ]
}
if (v8_current_cpu == "ppc" || v8_current_cpu == "ppc64" ||
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698