Active Directory: Propagate username to online reauth

Active Directory: Propagate username to online reauth

BUG=681028
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2641453002
Cr-Commit-Position: refs/heads/master@{#444704}
Committed: https://chromium.googlesource.com/chromium/src/+/89bed32dfee51bcf0428012be7f09766543ac06a

[Roman Sorokin (ftl), 2017-01-17 16:09:34]

Description was changed from

==========
Active Directory: Propagate username to online reauth

BUG=681028
TEST=manual
==========

to

==========
Active Directory: Propagate username to online reauth

BUG=681028
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Roman Sorokin (ftl), 2017-01-17 16:09:47]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 16:10:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2017-01-17 16:10:47]

rsorokin@chromium.org changed reviewers:
+ alemate@chromium.org

[Roman Sorokin (ftl), 2017-01-17 16:10:48]

Hey Alex, PTAL!

[commit-bot: I haz the power, 2017-01-17 16:58:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 16:58:40]

Dry run: This issue passed the CQ dry run.

[Roman Sorokin (ftl), 2017-01-18 17:41:56]

Description was changed from

==========
Active Directory: Propagate username to online reauth

BUG=681028
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Active Directory: Propagate username to online reauth

BUG=681028
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Roman Sorokin (ftl), 2017-01-18 17:41:56]

rsorokin@chromium.org changed reviewers:
- alemate@chromium.org

[Roman Sorokin (ftl), 2017-01-18 17:43:47]

rsorokin@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Roman Sorokin (ftl), 2017-01-18 17:43:47]

Hey Michael, seems like Alex is OOO. Could you PTAL? Thanks!

[achuithb, 2017-01-18 19:22:47]

achuith@chromium.org changed reviewers:
+ achuith@chromium.org

[achuithb, 2017-01-18 19:22:48]

Is there a plan to add some test for this?

https://codereview.chromium.org/2641453002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

https://codereview.chromium.org/2641453002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:53:
'invalidateAd',
Shouldn't this be invalidateAD?

[Roman Sorokin (ftl), 2017-01-18 22:06:01]

On 2017/01/18 19:22:48, achuithb wrote:
> Is there a plan to add some test for this?
> 
Yes! We are targeting tests for m-58. Just filed a bug to track this
crbug.com/682421
>
https://codereview.chromium.org/2641453002/diff/1/chrome/browser/resources/ch...
> File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):
> 
>
https://codereview.chromium.org/2641453002/diff/1/chrome/browser/resources/ch...
> chrome/browser/resources/chromeos/login/screen_gaia_signin.js:53:
> 'invalidateAd',
> Shouldn't this be invalidateAD?
In one of the previous CLs we agreed to use Ad.

[achuithb, 2017-01-18 23:47:03]

On 2017/01/18 22:06:01, Roman Sorokin wrote:
> On 2017/01/18 19:22:48, achuithb wrote:
> > Is there a plan to add some test for this?
> > 
> Yes! We are targeting tests for m-58. Just filed a bug to track this
> crbug.com/682421

Hopefully we allocate the time to do this.

> >
>
https://codereview.chromium.org/2641453002/diff/1/chrome/browser/resources/ch...
> > File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):
> > 
> >
>
https://codereview.chromium.org/2641453002/diff/1/chrome/browser/resources/ch...
> > chrome/browser/resources/chromeos/login/screen_gaia_signin.js:53:
> > 'invalidateAd',
> > Shouldn't this be invalidateAD?
> In one of the previous CLs we agreed to use Ad.

lgtm

[Roman Sorokin (ftl), 2017-01-19 08:38:52]

rsorokin@chromium.org changed reviewers:
- michaelpg@chromium.org

[Roman Sorokin (ftl), 2017-01-19 08:39:33]

On 2017/01/18 23:47:03, achuithb wrote:
> On 2017/01/18 22:06:01, Roman Sorokin wrote:
> > On 2017/01/18 19:22:48, achuithb wrote:
> > > Is there a plan to add some test for this?
> > > 
> > Yes! We are targeting tests for m-58. Just filed a bug to track this
> > crbug.com/682421
> 
> Hopefully we allocate the time to do this.
Yes.
> 
> > >
> >
>
https://codereview.chromium.org/2641453002/diff/1/chrome/browser/resources/ch...
> > > File chrome/browser/resources/chromeos/login/screen_gaia_signin.js
(right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2641453002/diff/1/chrome/browser/resources/ch...
> > > chrome/browser/resources/chromeos/login/screen_gaia_signin.js:53:
> > > 'invalidateAd',
> > > Shouldn't this be invalidateAD?
> > In one of the previous CLs we agreed to use Ad.
> 
> lgtm
Thanks!

[Roman Sorokin (ftl), 2017-01-19 08:39:42]

The CQ bit was checked by rsorokin@chromium.org

[commit-bot: I haz the power, 2017-01-19 08:40:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 10:56:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484815182713500, "parent_rev":
"47fb183f3d579aed696376053b74e691618d3cf2", "commit_rev":
"89bed32dfee51bcf0428012be7f09766543ac06a"}

[commit-bot: I haz the power, 2017-01-19 10:57:25]

Description was changed from

==========
Active Directory: Propagate username to online reauth

BUG=681028
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Active Directory: Propagate username to online reauth

BUG=681028
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2641453002
Cr-Commit-Position: refs/heads/master@{#444704}
Committed:
https://chromium.googlesource.com/chromium/src/+/89bed32dfee51bcf0428012be7f0...
==========

[commit-bot: I haz the power, 2017-01-19 10:57:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/89bed32dfee51bcf0428012be7f0...