Handle login and password error for the domain join

Handle login and password error for the domain join

BUG=659984
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2622273002
Cr-Commit-Position: refs/heads/master@{#444487}
Committed: https://chromium.googlesource.com/chromium/src/+/4db2dd71234b642c7ff3fd9d432652e1e9e2e0e5

[Roman Sorokin (ftl), 2017-01-11 14:24:49]

Description was changed from

==========
Handle login and password error for the domain join

BUG=659984
TEST=manual
==========

to

==========
Handle login and password error for the domain join

BUG=659984
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Roman Sorokin (ftl), 2017-01-11 14:25:49]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 14:26:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 16:03:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 16:03:32]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Roman Sorokin (ftl), 2017-01-16 17:33:31]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 17:33:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 20:11:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 20:11:12]

Dry run: This issue passed the CQ dry run.

[dskaram, 2017-01-17 10:30:50]

https://codereview.chromium.org/2622273002/diff/20001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2622273002/diff/20001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6258: The username and password you entered
don't match
don't --> do not

https://codereview.chromium.org/2622273002/diff/20001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6268: Do you have sufficient permissions to
create machine accounts?
Failed to join the machine to the domain. This might be due to insufficient
privileges for your account on the server.

Though ideally we put the latter part of the sentence in some bubble hover. Is
that possible? Is this error showing in a screen on its own (like the Oops!
error) or inline on the Join domain screen? If the former, then it should be
fine if it's two sentences and no hover is needed.

https://codereview.chromium.org/2622273002/diff/20001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6272: You've probably added maximum number
machines to the domain.
Failed to join the machine to the domain. This might be due to exceeding the
maximum number of allowed machine joins for your account on the server.

Same comment as above.

[Roman Sorokin (ftl), 2017-01-17 12:20:21]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 12:20:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2017-01-17 12:21:45]

rsorokin@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Roman Sorokin (ftl), 2017-01-17 12:21:46]

Hey Michael, could you PTAL? Thanks!

https://codereview.chromium.org/2622273002/diff/20001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2622273002/diff/20001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6258: The username and password you entered
don't match
On 2017/01/17 10:30:50, dskaram wrote:
> don't --> do not

Done.

https://codereview.chromium.org/2622273002/diff/20001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6268: Do you have sufficient permissions to
create machine accounts?
On 2017/01/17 10:30:50, dskaram wrote:
> Failed to join the machine to the domain. This might be due to insufficient
> privileges for your account on the server.
> 
> Though ideally we put the latter part of the sentence in some bubble hover. Is
> that possible? Is this error showing in a screen on its own (like the Oops!
> error) or inline on the Join domain screen? If the former, then it should be
> fine if it's two sentences and no hover is needed.

It's former.

https://codereview.chromium.org/2622273002/diff/20001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6272: You've probably added maximum number
machines to the domain.
On 2017/01/17 10:30:50, dskaram wrote:
> Failed to join the machine to the domain. This might be due to exceeding the
> maximum number of allowed machine joins for your account on the server.
> 
> Same comment as above.

Done.

[commit-bot: I haz the power, 2017-01-17 13:12:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 13:12:52]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2017-01-18 00:32:30]

https://codereview.chromium.org/2622273002/diff/40001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2622273002/diff/40001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6270: Oops!  Something went wrong when trying
to join the domain.  Please try again.
single spaces after punctuation

https://codereview.chromium.org/2622273002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/offline_ad_login.js (right):

https://codereview.chromium.org/2622273002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/offline_ad_login.js:11: /** @const */
var ACTIVE_DIRECTORY_ERROR_STATE = {
@enum {number} instead of const

https://codereview.chromium.org/2622273002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/offline_ad_login.js:12: NONE : 0,
no space before :

https://codereview.chromium.org/2622273002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/offline_ad_login.js:22: 
remove blank line

https://codereview.chromium.org/2622273002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/offline_ad_login.js:93: setInvalid:
function(value) {
annotate

https://codereview.chromium.org/2622273002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/offline_ad_login.js:93: setInvalid:
function(value) {
how does this get "cleared" after a successful attempt?

[Roman Sorokin (ftl), 2017-01-18 13:56:18]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 13:56:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2017-01-18 13:56:44]

Michael, thanks for the review! PTAL.

https://codereview.chromium.org/2622273002/diff/40001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2622273002/diff/40001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6270: Oops!  Something went wrong when trying
to join the domain.  Please try again.
On 2017/01/18 00:32:30, michaelpg wrote:
> single spaces after punctuation

Done.

https://codereview.chromium.org/2622273002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/offline_ad_login.js (right):

https://codereview.chromium.org/2622273002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/offline_ad_login.js:11: /** @const */
var ACTIVE_DIRECTORY_ERROR_STATE = {
On 2017/01/18 00:32:30, michaelpg wrote:
> @enum {number} instead of const

Done.

https://codereview.chromium.org/2622273002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/offline_ad_login.js:12: NONE : 0,
On 2017/01/18 00:32:30, michaelpg wrote:
> no space before :

Done.

https://codereview.chromium.org/2622273002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/offline_ad_login.js:22: 
On 2017/01/18 00:32:30, michaelpg wrote:
> remove blank line

Done.

https://codereview.chromium.org/2622273002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/offline_ad_login.js:93: setInvalid:
function(value) {
On 2017/01/18 00:32:30, michaelpg wrote:
> annotate

Done.

https://codereview.chromium.org/2622273002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/offline_ad_login.js:93: setInvalid:
function(value) {
On 2017/01/18 00:32:30, michaelpg wrote:
> how does this get "cleared" after a successful attempt?

Good point! Added it to |showStep|

[commit-bot: I haz the power, 2017-01-18 14:56:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 14:56:14]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2017-01-18 21:11:31]

lgtm

[Roman Sorokin (ftl), 2017-01-18 21:16:53]

The CQ bit was checked by rsorokin@chromium.org

[commit-bot: I haz the power, 2017-01-18 21:17:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 21:23:24]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484774213574940,
"parent_rev": "f32903d5d3d0ca5dd5a45c3110f95f47cac02c86", "commit_rev":
"4db2dd71234b642c7ff3fd9d432652e1e9e2e0e5"}

[commit-bot: I haz the power, 2017-01-18 21:23:58]

Description was changed from

==========
Handle login and password error for the domain join

BUG=659984
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Handle login and password error for the domain join

BUG=659984
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2622273002
Cr-Commit-Position: refs/heads/master@{#444487}
Committed:
https://chromium.googlesource.com/chromium/src/+/4db2dd71234b642c7ff3fd9d4326...
==========

[commit-bot: I haz the power, 2017-01-18 21:24:00]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4db2dd71234b642c7ff3fd9d4326...