Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2641283002: Revert of [debugger] temporarily re-implement --expose-debug-as. (Closed)

Created:
3 years, 11 months ago by Yang
Modified:
3 years, 11 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Michael Hablich, ofrobots
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugger] temporarily re-implement --expose-debug-as. (patchset #1 id:1 of https://codereview.chromium.org/2636423002/ ) Reason for revert: Flag is being removed for 5.8. Original issue's description: > [debugger] temporarily re-implement --expose-debug-as. > > This is done out of courtesy for Node.js and will be > removed as soon as we branch for version 5.8. > > R=jgruber@chromium.org > > Review-Url: https://codereview.chromium.org/2636423002 > Cr-Commit-Position: refs/heads/master@{#42437} > Committed: https://chromium.googlesource.com/v8/v8/+/cbb7145221dad688ebe86f90bfa4fdd63ea1263e TBR=jgruber@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2641283002 Cr-Commit-Position: refs/heads/master@{#42546} Committed: https://chromium.googlesource.com/v8/v8/+/7425b1f2c9c026dd6e4f7471995d4d605262d553

Patch Set 1 #

Patch Set 2 : fix conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M src/bootstrapper.cc View 1 1 chunk +0 lines, -20 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Yang
Created Revert of [debugger] temporarily re-implement --expose-debug-as.
3 years, 11 months ago (2017-01-20 07:51:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641283002/1
3 years, 11 months ago (2017-01-20 07:51:36 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/15531) v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 11 months ago (2017-01-20 07:52:49 UTC) #5
jgruber
lgtm
3 years, 11 months ago (2017-01-20 10:44:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641283002/70001
3 years, 11 months ago (2017-01-20 10:45:54 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 10:48:02 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:70001) as
https://chromium.googlesource.com/v8/v8/+/7425b1f2c9c026dd6e4f7471995d4d60526...

Powered by Google App Engine
This is Rietveld 408576698