Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2636423002: [debugger] temporarily re-implement --expose-debug-as. (Closed)

Created:
3 years, 11 months ago by Yang
Modified:
3 years, 11 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Michael Hablich, ofrobots
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] temporarily re-implement --expose-debug-as. This is done out of courtesy for Node.js and will be removed as soon as we branch for version 5.8. R=jgruber@chromium.org Review-Url: https://codereview.chromium.org/2636423002 Cr-Commit-Position: refs/heads/master@{#42437} Committed: https://chromium.googlesource.com/v8/v8/+/cbb7145221dad688ebe86f90bfa4fdd63ea1263e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/bootstrapper.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Yang
3 years, 11 months ago (2017-01-18 07:59:10 UTC) #1
Yang
/cc Ali
3 years, 11 months ago (2017-01-18 07:59:39 UTC) #2
jgruber
lgtm I'm not clear on the terminology here, this means we will be able to ...
3 years, 11 months ago (2017-01-18 08:26:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636423002/1
3 years, 11 months ago (2017-01-18 08:57:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/cbb7145221dad688ebe86f90bfa4fdd63ea1263e
3 years, 11 months ago (2017-01-18 08:59:03 UTC) #12
Yang
3 years, 11 months ago (2017-01-20 07:51:29 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2641283002/ by yangguo@chromium.org.

The reason for reverting is: Flag is being removed for 5.8..

Powered by Google App Engine
This is Rietveld 408576698