Revert of [Sync] Make directory types registration explicit in ModelTypeRegistry (patchset #3 id:40…

Revert of [Sync] Make directory types registration explicit in ModelTypeRegistry (patchset #3 id:40001 of https://codereview.chromium.org/2641523004/ )

Reason for revert:
This change causes crashes in sync: http://crbug.com/682998

Original issue's description:
> [Sync] Make directory types registration explicit in ModelTypeRegistry
>
> The goal of this change is to make registration of directory types with
> ModelTypeRegistry to be driven by individual data type controllers. Today set of
> directory data types are registered with single call to
> SetEnabledDirectoryTypes, they are derived from routing info passed through
> sync manager and scheduler.
>
> Since datatype registration will be performed as separate posts to sync thread
> it is important to switch scheduler to configuration mode at the beginning of
> configuration.
>
> In this change I:
> - Added Register/UnregisterDirectoryType to ModelTypeConnector and
>   ModelTypeRegistry.
> - Removed SetEnabledDirectoryTypes form ModelTypeRegistry as it is no longer
>   needed.
> - Added StartConfiguration to SyncEngine. This method needs to be called before
>   RegisterDirectoryDataType are called so that normal sync cycle doesn't get
>   executed on sync thread and doesn't include new datatypes before their
>   services are ready to receive updates.
> - Added BeforeLoadModels method to DataTypeController. This method is called
>   right before LoadModels and allows directory datatypes to register with sync
>   engine before initial data downloading begins.
>
> BUG=647505
> R=maxbogue@chromium.org
>
> Review-Url: https://codereview.chromium.org/2641523004
> Cr-Commit-Position: refs/heads/master@{#444846}
> Committed: https://chromium.googlesource.com/chromium/src/+/1c7af89ea2d8e6e5e31be9d1f7bfa6c306584f5d

TBR=maxbogue@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=647505
Review-Url: https://codereview.chromium.org/2644373003
Cr-Commit-Position: refs/heads/master@{#445105}
(cherry picked from commit 5c363ea4a04878fd491b6e674f802deff42245f6)

Review-Url: https://codereview.chromium.org/2641253004 .
Cr-Commit-Position: refs/branch-heads/2987@{#5}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/61709422b5beea0c9fd25c373788338230b8d1ad

[pavely, 2017-01-20 19:44:08]

Description was changed from

==========
Revert of [Sync] Make directory types registration explicit in ModelTypeRegistry
(patchset #3 id:40001 of https://codereview.chromium.org/2641523004/ )

Reason for revert:
This change causes crashes in sync: http://crbug.com/682998

Original issue's description:
> [Sync] Make directory types registration explicit in ModelTypeRegistry
>
> The goal of this change is to make registration of directory types with
> ModelTypeRegistry to be driven by individual data type controllers. Today set
of
> directory data types are registered with single call to
> SetEnabledDirectoryTypes, they are derived from routing info passed through
> sync manager and scheduler.
>
> Since datatype registration will be performed as separate posts to sync thread
> it is important to switch scheduler to configuration mode at the beginning of
> configuration.
>
> In this change I:
> - Added Register/UnregisterDirectoryType to ModelTypeConnector and
>   ModelTypeRegistry.
> - Removed SetEnabledDirectoryTypes form ModelTypeRegistry as it is no longer
>   needed.
> - Added StartConfiguration to SyncEngine. This method needs to be called
before
>   RegisterDirectoryDataType are called so that normal sync cycle doesn't get
>   executed on sync thread and doesn't include new datatypes before their
>   services are ready to receive updates.
> - Added BeforeLoadModels method to DataTypeController. This method is called
>   right before LoadModels and allows directory datatypes to register with sync
>   engine before initial data downloading begins.
>
> BUG=647505
> R=maxbogue@chromium.org
>
> Review-Url: https://codereview.chromium.org/2641523004
> Cr-Commit-Position: refs/heads/master@{#444846}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1c7af89ea2d8e6e5e31be9d1f7bf...

TBR=maxbogue@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=647505

Review-Url: https://codereview.chromium.org/2644373003
Cr-Commit-Position: refs/heads/master@{#445105}
(cherry picked from commit 5c363ea4a04878fd491b6e674f802deff42245f6)
==========

to

==========
Revert of [Sync] Make directory types registration explicit in ModelTypeRegistry
(patchset #3 id:40001 of https://codereview.chromium.org/2641523004/ )

Reason for revert:
This change causes crashes in sync: http://crbug.com/682998

Original issue's description:
> [Sync] Make directory types registration explicit in ModelTypeRegistry
>
> The goal of this change is to make registration of directory types with
> ModelTypeRegistry to be driven by individual data type controllers. Today set
of
> directory data types are registered with single call to
> SetEnabledDirectoryTypes, they are derived from routing info passed through
> sync manager and scheduler.
>
> Since datatype registration will be performed as separate posts to sync thread
> it is important to switch scheduler to configuration mode at the beginning of
> configuration.
>
> In this change I:
> - Added Register/UnregisterDirectoryType to ModelTypeConnector and
>   ModelTypeRegistry.
> - Removed SetEnabledDirectoryTypes form ModelTypeRegistry as it is no longer
>   needed.
> - Added StartConfiguration to SyncEngine. This method needs to be called
before
>   RegisterDirectoryDataType are called so that normal sync cycle doesn't get
>   executed on sync thread and doesn't include new datatypes before their
>   services are ready to receive updates.
> - Added BeforeLoadModels method to DataTypeController. This method is called
>   right before LoadModels and allows directory datatypes to register with sync
>   engine before initial data downloading begins.
>
> BUG=647505
> R=maxbogue@chromium.org
>
> Review-Url: https://codereview.chromium.org/2641523004
> Cr-Commit-Position: refs/heads/master@{#444846}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1c7af89ea2d8e6e5e31be9d1f7bf...

TBR=maxbogue@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=647505

Review-Url: https://codereview.chromium.org/2644373003
Cr-Commit-Position: refs/heads/master@{#445105}
(cherry picked from commit 5c363ea4a04878fd491b6e674f802deff42245f6)

Review-Url: https://codereview.chromium.org/2641253004 .
Cr-Commit-Position: refs/branch-heads/2987@{#5}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/61709422b5beea0c9fd25c373788...
==========

[pavely, 2017-01-20 19:44:09]

Committed patchset #1 (id:1) manually as
61709422b5beea0c9fd25c373788338230b8d1ad.