Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2641193002: Remove "Missing Worker Pool Configuration: ..." DLOG. (Closed)

Created:
3 years, 11 months ago by fdoray
Modified:
3 years, 11 months ago
Reviewers:
robliao, gab
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "Missing Worker Pool Configuration: ..." DLOG. Non-branded builds don't have access to external worker pool configurations. It is undesirable to log "Missing Worker Pool Configuration: ..." every time these builds are launched. BUG=682222 Review-Url: https://codereview.chromium.org/2641193002 Cr-Commit-Position: refs/heads/master@{#444784} Committed: https://chromium.googlesource.com/chromium/src/+/4b9b580a3159188e0708392406b8ccb36725f479

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR robliao #5 (add comment) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/task_scheduler_util/common/variations_util.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
fdoray
PTAL
3 years, 11 months ago (2017-01-19 16:33:54 UTC) #4
robliao
lgtm + comment https://codereview.chromium.org/2641193002/diff/1/components/task_scheduler_util/common/variations_util.cc File components/task_scheduler_util/common/variations_util.cc (left): https://codereview.chromium.org/2641193002/diff/1/components/task_scheduler_util/common/variations_util.cc#oldcode102 components/task_scheduler_util/common/variations_util.cc:102: DLOG(ERROR) << "Missing Worker Pool Configuration: ...
3 years, 11 months ago (2017-01-19 16:58:24 UTC) #5
fdoray
https://codereview.chromium.org/2641193002/diff/1/components/task_scheduler_util/common/variations_util.cc File components/task_scheduler_util/common/variations_util.cc (left): https://codereview.chromium.org/2641193002/diff/1/components/task_scheduler_util/common/variations_util.cc#oldcode102 components/task_scheduler_util/common/variations_util.cc:102: DLOG(ERROR) << "Missing Worker Pool Configuration: " << worker_pool_name; ...
3 years, 11 months ago (2017-01-19 17:02:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641193002/20001
3 years, 11 months ago (2017-01-19 17:03:05 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 18:01:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4b9b580a3159188e0708392406b8...

Powered by Google App Engine
This is Rietveld 408576698