Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: components/task_scheduler_util/common/variations_util.cc

Issue 2641193002: Remove "Missing Worker Pool Configuration: ..." DLOG. (Closed)
Patch Set: CR robliao #5 (add comment) Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/task_scheduler_util/common/variations_util.h" 5 #include "components/task_scheduler_util/common/variations_util.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/strings/string_piece.h" 10 #include "base/strings/string_piece.h"
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 std::vector<base::SchedulerWorkerPoolParams> GetWorkerPoolParams( 92 std::vector<base::SchedulerWorkerPoolParams> GetWorkerPoolParams(
93 const std::vector<SchedulerImmutableWorkerPoolParams>& 93 const std::vector<SchedulerImmutableWorkerPoolParams>&
94 constant_worker_pool_params_vector, 94 constant_worker_pool_params_vector,
95 const std::map<std::string, std::string>& variation_params) { 95 const std::map<std::string, std::string>& variation_params) {
96 std::vector<base::SchedulerWorkerPoolParams> worker_pool_params_vector; 96 std::vector<base::SchedulerWorkerPoolParams> worker_pool_params_vector;
97 for (const auto& constant_worker_pool_params : 97 for (const auto& constant_worker_pool_params :
98 constant_worker_pool_params_vector) { 98 constant_worker_pool_params_vector) {
99 const char* const worker_pool_name = constant_worker_pool_params.name(); 99 const char* const worker_pool_name = constant_worker_pool_params.name();
100 auto it = variation_params.find(worker_pool_name); 100 auto it = variation_params.find(worker_pool_name);
101 if (it == variation_params.end()) { 101 if (it == variation_params.end()) {
102 DLOG(ERROR) << "Missing Worker Pool Configuration: " << worker_pool_name; 102 // Non-branded builds don't have access to external worker pool
103 // configurations.
103 return std::vector<base::SchedulerWorkerPoolParams>(); 104 return std::vector<base::SchedulerWorkerPoolParams>();
104 } 105 }
105 const auto variable_worker_pool_params = 106 const auto variable_worker_pool_params =
106 StringToVariableWorkerPoolParams(it->second); 107 StringToVariableWorkerPoolParams(it->second);
107 if (variable_worker_pool_params.max_threads <= 0 || 108 if (variable_worker_pool_params.max_threads <= 0 ||
108 variable_worker_pool_params.detach_period <= base::TimeDelta()) { 109 variable_worker_pool_params.detach_period <= base::TimeDelta()) {
109 DLOG(ERROR) << "Invalid Worker Pool Configuration: " << worker_pool_name 110 DLOG(ERROR) << "Invalid Worker Pool Configuration: " << worker_pool_name
110 << " [" << it->second << "]"; 111 << " [" << it->second << "]";
111 return std::vector<base::SchedulerWorkerPoolParams>(); 112 return std::vector<base::SchedulerWorkerPoolParams>();
112 } 113 }
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 return std::map<std::string, std::string>(); 167 return std::map<std::string, std::string>();
167 } 168 }
168 base::StringPiece value = *it; 169 base::StringPiece value = *it;
169 variation_params[key.as_string()] = value.as_string(); 170 variation_params[key.as_string()] = value.as_string();
170 } 171 }
171 return variation_params; 172 return variation_params;
172 } 173 }
173 #endif // !defined(OS_IOS) 174 #endif // !defined(OS_IOS)
174 175
175 } // namespace task_scheduler_util 176 } // namespace task_scheduler_util
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698