Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2641173005:
Fix flaky FtpBrowserTest.DirectoryListingNavigation (Closed)
DescriptionFix flaky FtpBrowserTest.DirectoryListingNavigation
The test executes a script assuming the DOM tree has already been created, but
it is not generally true and that leads to flakiness. This CL fixes that by
changing the script.
BUG=521409, 603396
Review-Url: https://codereview.chromium.org/2641173005
Cr-Commit-Position: refs/heads/master@{#445058}
Committed: https://chromium.googlesource.com/chromium/src/+/7358250caa2a9c6db318ed1d1caa6d542b3e08c5
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : fix #Patch Set 4 : fix #Messages
Total messages: 26 (18 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yhirano@chromium.org changed reviewers: + tzik@chromium.org
Description was changed from ========== Fix flaky FtpBrowserTest.DirectoryListingNavigation The test executes a script assuming the DOM tree has already been created, but it is not generally true and that leads to flakiness. This CL fixes that by changing the script. BUG=521409 ========== to ========== Fix flaky FtpBrowserTest.DirectoryListingNavigation The test executes a script assuming the DOM tree has already been created, but it is not generally true and that leads to flakiness. This CL fixes that by changing the script. BUG=521409, 603396 ==========
lgtm
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Fixed based on the offline chat. tzik@, do you like PS3 more than PS2?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
yhirano@chromium.org changed reviewers: + agl@chromium.org
+agl@ for OWNER review.
The CQ bit was checked by agl@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484925513609810,
"parent_rev": "47fc6586d76ba2b8d2fc7c5e1432b1f07788e574", "commit_rev":
"7358250caa2a9c6db318ed1d1caa6d542b3e08c5"}
Message was sent while issue was closed.
Description was changed from ========== Fix flaky FtpBrowserTest.DirectoryListingNavigation The test executes a script assuming the DOM tree has already been created, but it is not generally true and that leads to flakiness. This CL fixes that by changing the script. BUG=521409, 603396 ========== to ========== Fix flaky FtpBrowserTest.DirectoryListingNavigation The test executes a script assuming the DOM tree has already been created, but it is not generally true and that leads to flakiness. This CL fixes that by changing the script. BUG=521409, 603396 Review-Url: https://codereview.chromium.org/2641173005 Cr-Commit-Position: refs/heads/master@{#445058} Committed: https://chromium.googlesource.com/chromium/src/+/7358250caa2a9c6db318ed1d1caa... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/7358250caa2a9c6db318ed1d1caa... |
