Fix flaky FtpBrowserTest.DirectoryListingNavigation

chrome/browser/net/ftp_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
@@ skipping 28 matching lines @@
 IN_PROC_BROWSER_TEST_F(FtpBrowserTest, BasicFtpUrlAuthentication) {
   ASSERT_TRUE(ftp_server_.Start());
   ui_test_utils::NavigateToURL(
       browser(),
       ftp_server_.GetURLWithUserAndPassword("", "chrome", "chrome"));
 
   WaitForTitle(browser()->tab_strip_model()->GetActiveWebContents(),
                "Index of /");
 }
 
-// http://crbug.com/521409
-#if defined(OS_WIN)
-#define MAYBE_DirectoryListingNavigation DISABLED_DirectoryListingNavigation
-#else
-#define MAYBE_DirectoryListingNavigation DirectoryListingNavigation
-#endif
-IN_PROC_BROWSER_TEST_F(FtpBrowserTest, MAYBE_DirectoryListingNavigation) {
+IN_PROC_BROWSER_TEST_F(FtpBrowserTest, DirectoryListingNavigation) {
   ftp_server_.set_no_anonymous_ftp_user(true);
   ASSERT_TRUE(ftp_server_.Start());
 
   ui_test_utils::NavigateToURL(
       browser(),
       ftp_server_.GetURLWithUserAndPassword("", "chrome", "chrome"));
 
   // Navigate to directory dir1/ without needing to re-authenticate
   EXPECT_TRUE(content::ExecuteScript(
       browser()->tab_strip_model()->GetActiveWebContents(),
-      "var elements = document.getElementsByTagName('a');"
-      "for (var i = 0; i < elements.length; i++) {"
-      "  if (elements[i].innerHTML == 'dir1/') {"
-      "    elements[i].click();"
+      "(function() {"
+      "  function navigate() {"
+      "    for (const element of document.getElementsByTagName('a')) {"
+      "      if (element.innerHTML == 'dir1/') {"
+      "        element.click();"
+      "      }"
+      "    }"
       "  }"
-      "}"));
+      "  if (document.readyState === 'loading') {"
+      "    document.addEventListener('DOMContentLoaded', navigate);"
+      "  } else {"
+      "    navigate();"
+      "  }"
+      "})()"));
 
   WaitForTitle(browser()->tab_strip_model()->GetActiveWebContents(),
                "Index of /dir1/");
 
   EXPECT_TRUE(content::ExecuteScript(
-        browser()->tab_strip_model()->GetActiveWebContents(),
-        "var elements = document.getElementsByTagName('a');"
-        "for (var i = 0; i < elements.length; i++) {"
-        "  if (elements[i].innerHTML == 'test.html') {"
-        "    elements[i].click();"
-        "  }"
-        "}"));
+      browser()->tab_strip_model()->GetActiveWebContents(),
+      "(function() {"
+      "  function navigate() {"
+      "    for (const element of document.getElementsByTagName('a')) {"
+      "      if (element.innerHTML == 'test.html') {"
+      "        element.click();"
+      "      }"
+      "    }"
+      "  }"
+      "  if (document.readyState === 'loading') {"
+      "    document.addEventListener('DOMContentLoaded', navigate);"
+      "  } else {"
+      "    navigate();"
+      "  }"
+      "})()"));
 
   WaitForTitle(browser()->tab_strip_model()->GetActiveWebContents(),
                "PASS");
 }