Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2641123007: Fix offline_gaia.js and re-run polymer reproduce.sh (Closed)

Created:
3 years, 11 months ago by stevenjb
Modified:
3 years, 11 months ago
Reviewers:
afakhry, Dan Beam, dpapad
CC:
achuith+watch_chromium.org, alemate+watch_chromium.org, arv+watch_chromium.org, asanka, chromium-reviews, dbeam+watch-downloads_chromium.org, dbeam+watch-history_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, oshima+watch_chromium.org, pam+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix offline_gaia.js and re-run polymer reproduce.sh This fixes offline_gaia.js to prevent a parse error while searching for unused elements while running third_party/polymer/v1_0/reproduce.sh It also updates vulcanized files, eliminating extra ;'s. Vulcanized files were updated by running third_party/polymer/v1_0/reproduce.sh. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M chrome/browser/resources/chromeos/login/offline_gaia.js View 2 chunks +2 lines, -2 lines 4 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 11 chunks +24 lines, -24 lines 2 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
stevenjb
3 years, 11 months ago (2017-01-20 19:10:25 UTC) #4
dpapad
https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/chromeos/login/offline_gaia.js File chrome/browser/resources/chromeos/login/offline_gaia.js (right): https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/chromeos/login/offline_gaia.js#newcode106 chrome/browser/resources/chromeos/login/offline_gaia.js:106: switchToEmailCard: function(animated) { @param? https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/chromeos/login/offline_gaia.js#newcode117 chrome/browser/resources/chromeos/login/offline_gaia.js:117: switchToPasswordCard: function(email, animated) ...
3 years, 11 months ago (2017-01-20 22:48:32 UTC) #5
stevenjb
https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/chromeos/login/offline_gaia.js File chrome/browser/resources/chromeos/login/offline_gaia.js (right): https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/chromeos/login/offline_gaia.js#newcode106 chrome/browser/resources/chromeos/login/offline_gaia.js:106: switchToEmailCard: function(animated) { On 2017/01/20 22:48:32, dpapad wrote: > ...
3 years, 11 months ago (2017-01-20 23:05:45 UTC) #6
stevenjb
On 2017/01/20 23:05:45, stevenjb wrote: > https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/chromeos/login/offline_gaia.js > File chrome/browser/resources/chromeos/login/offline_gaia.js (right): > > https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/chromeos/login/offline_gaia.js#newcode106 > ...
3 years, 11 months ago (2017-01-20 23:15:35 UTC) #7
afakhry
offline_gaia.js lgtm
3 years, 11 months ago (2017-01-24 02:31:16 UTC) #8
stevenjb
3 years, 11 months ago (2017-01-24 02:37:48 UTC) #9
Message was sent while issue was closed.
On 2017/01/24 02:31:16, afakhry wrote:
> offline_gaia.js lgtm

Note: I closed this, we need a separate CL with the fix to offline_gaia.js, and
preferably with closure jsdoc and compilation added (i.e an entry for
offline_gaia.js in the compiled_resources.gyp file in that directory). Thanks!

Powered by Google App Engine
This is Rietveld 408576698