Fix offline_gaia.js and re-run polymer reproduce.sh

Fix offline_gaia.js and re-run polymer reproduce.sh

This fixes offline_gaia.js to prevent a parse error while searching for
unused elements while running third_party/polymer/v1_0/reproduce.sh

It also updates vulcanized files, eliminating extra ;'s. Vulcanized files
were updated by running third_party/polymer/v1_0/reproduce.sh.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

[stevenjb, 2017-01-20 19:02:49]

Description was changed from

==========
Fix offline_gaia.js and re-run polymer reproduce.sh

This fixes offline_gaia.js to prevent a parse error while searching for
unused elements while running third_party/polymer/v1_0/reproduce.sh

It also updates vulcanized files, eliminating extra ;'s.

BUG=none
==========

to

==========
Fix offline_gaia.js and re-run polymer reproduce.sh

This fixes offline_gaia.js to prevent a parse error while searching for
unused elements while running third_party/polymer/v1_0/reproduce.sh

It also updates vulcanized files, eliminating extra ;'s.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-01-20 19:09:52]

Description was changed from

==========
Fix offline_gaia.js and re-run polymer reproduce.sh

This fixes offline_gaia.js to prevent a parse error while searching for
unused elements while running third_party/polymer/v1_0/reproduce.sh

It also updates vulcanized files, eliminating extra ;'s.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix offline_gaia.js and re-run polymer reproduce.sh

This fixes offline_gaia.js to prevent a parse error while searching for
unused elements while running third_party/polymer/v1_0/reproduce.sh

It also updates vulcanized files, eliminating extra ;'s. Vulcanized files
were updated by running third_party/polymer/v1_0/reproduce.sh.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-01-20 19:10:24]

stevenjb@chromium.org changed reviewers:
+ afakhry@chromium.org, dbeam@chromium.org, dpapad@chromium.org

[dpapad, 2017-01-20 22:48:32]

https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/offline_gaia.js (right):

https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/offline_gaia.js:106: switchToEmailCard:
function(animated) {
@param?

https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/offline_gaia.js:117:
switchToPasswordCard: function(email, animated) {
Same here.

https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/vulcanized.html (right):

https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/vulcanized.html:856: background:
var(--paper-progress-container-color,var(--google-grey-300));
Can you verify that ran reproduce.sh after @dbeam's
https://codereview.chromium.org/2649483002 landed, which modified vulcanize.py
itself (which is called by reproduce.sh)?

[stevenjb, 2017-01-20 23:05:45]

https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/offline_gaia.js (right):

https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/offline_gaia.js:106: switchToEmailCard:
function(animated) {
On 2017/01/20 22:48:32, dpapad wrote:
> @param?

None of the methods in this file (which I am not actually familiar with) appear
to use closure jsdoc. This CL is just to prevent a parse error when running
reproduce.sh.

https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/offline_gaia.js:117:
switchToPasswordCard: function(email, animated) {
On 2017/01/20 22:48:32, dpapad wrote:
> Same here.

ditto

https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/vulcanized.html (right):

https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/vulcanized.html:856: background:
var(--paper-progress-container-color,var(--google-grey-300));
On 2017/01/20 22:48:32, dpapad wrote:
> Can you verify that ran reproduce.sh after @dbeam's
> https://codereview.chromium.org/2649483002 landed, which modified vulcanize.py
> itself (which is called by reproduce.sh)?

I ran this @ #445084 < 445156, I will rebase it.

[stevenjb, 2017-01-20 23:15:35]

On 2017/01/20 23:05:45, stevenjb wrote:
>
https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/ch...
> File chrome/browser/resources/chromeos/login/offline_gaia.js (right):
> 
>
https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/ch...
> chrome/browser/resources/chromeos/login/offline_gaia.js:106:
switchToEmailCard:
> function(animated) {
> On 2017/01/20 22:48:32, dpapad wrote:
> > @param?
> 
> None of the methods in this file (which I am not actually familiar with)
appear
> to use closure jsdoc. This CL is just to prevent a parse error when running
> reproduce.sh.
> 
>
https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/ch...
> chrome/browser/resources/chromeos/login/offline_gaia.js:117:
> switchToPasswordCard: function(email, animated) {
> On 2017/01/20 22:48:32, dpapad wrote:
> > Same here.
> 
> ditto
> 
>
https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/md...
> File chrome/browser/resources/md_downloads/vulcanized.html (right):
> 
>
https://codereview.chromium.org/2641123007/diff/1/chrome/browser/resources/md...
> chrome/browser/resources/md_downloads/vulcanized.html:856: background:
> var(--paper-progress-container-color,var(--google-grey-300));
> On 2017/01/20 22:48:32, dpapad wrote:
> > Can you verify that ran reproduce.sh after @dbeam's
> > https://codereview.chromium.org/2649483002 landed, which modified
vulcanize.py
> > itself (which is called by reproduce.sh)?
> 
> I ran this @ #445084 < 445156, I will rebase it.

With a more current ToT checkout the only change is to offline_gaia.js.

afakhry@, could you fix that at your leisure and add jsdoc types (and ideally
closure compilation)? Thanks!

[afakhry, 2017-01-24 02:31:16]

offline_gaia.js lgtm

[stevenjb, 2017-01-24 02:37:48]

On 2017/01/24 02:31:16, afakhry wrote:
> offline_gaia.js lgtm

Note: I closed this, we need a separate CL with the fix to offline_gaia.js, and
preferably with closure jsdoc and compilation added (i.e an entry for
offline_gaia.js in the compiled_resources.gyp file in that directory). Thanks!