Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2646943003: Polymer: roll paper-slider, 1.0.11 -> 1.0.13 (Closed)

Created:
3 years, 11 months ago by stevenjb
Modified:
3 years, 11 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Polymer: roll paper-slider, 1.0.11 -> 1.0.13 Primarily this picks up a fix to preven arrow keys from scrolling the page when used with a paper slider focused. BUG=675393 Review-Url: https://codereview.chromium.org/2646943003 Cr-Commit-Position: refs/heads/master@{#445254} Committed: https://chromium.googlesource.com/chromium/src/+/a2bec78f3efa4fe7e9766938c606367df553070f

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -42 lines) Patch
M third_party/polymer/v1_0/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider.html View 12 chunks +34 lines, -32 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js View 5 chunks +9 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components_summary.txt View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
stevenjb
3 years, 11 months ago (2017-01-20 19:10:38 UTC) #2
Dan Beam
we run vulcanize.py from reproduce.sh so the functional change happens for downloads / history in ...
3 years, 11 months ago (2017-01-20 20:52:26 UTC) #3
stevenjb
On 2017/01/20 20:52:26, Dan Beam (slow - converging) wrote: > we run vulcanize.py from reproduce.sh ...
3 years, 11 months ago (2017-01-20 21:06:29 UTC) #4
Dan Beam
On 2017/01/20 21:06:29, stevenjb wrote: > On 2017/01/20 20:52:26, Dan Beam (slow - converging) wrote: ...
3 years, 11 months ago (2017-01-20 21:49:53 UTC) #5
stevenjb
When I first made this change I saw some unrelated side effects, so I re-ran ...
3 years, 11 months ago (2017-01-20 22:01:00 UTC) #6
dpapad
Removing myself since dbeam is already looking at this.
3 years, 11 months ago (2017-01-20 22:22:29 UTC) #8
stevenjb
dpapad@ pointed out that I just missed ToT fixes to the vulcanized files, so rebased ...
3 years, 11 months ago (2017-01-20 23:22:20 UTC) #9
stevenjb
(PTAL)
3 years, 11 months ago (2017-01-20 23:22:42 UTC) #10
Dan Beam
lgtm
3 years, 11 months ago (2017-01-21 00:50:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646943003/20001
3 years, 11 months ago (2017-01-21 00:51:31 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 02:26:45 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a2bec78f3efa4fe7e9766938c606...

Powered by Google App Engine
This is Rietveld 408576698