Polymer: roll paper-slider, 1.0.11 -> 1.0.13

Polymer: roll paper-slider, 1.0.11 -> 1.0.13

Primarily this picks up a fix to preven arrow keys from scrolling
the page when used with a paper slider focused.

BUG=675393
Review-Url: https://codereview.chromium.org/2646943003
Cr-Commit-Position: refs/heads/master@{#445254}
Committed: https://chromium.googlesource.com/chromium/src/+/a2bec78f3efa4fe7e9766938c606367df553070f

[stevenjb, 2017-01-20 19:10:37]

stevenjb@chromium.org changed reviewers:
+ dbeam@chromium.org, dpapad@chromium.org

[Dan Beam, 2017-01-20 20:52:26]

we run vulcanize.py from reproduce.sh so the functional change happens for
downloads / history in this CL.  please don't separate them or edit generated
files (all the .vulcanized or .crisper files)

[stevenjb, 2017-01-20 21:06:29]

On 2017/01/20 20:52:26, Dan Beam (slow - converging) wrote:
> we run vulcanize.py from reproduce.sh so the functional change happens for
> downloads / history in this CL.  please don't separate them or edit generated
> files (all the .vulcanized or .crisper files)

I do not understand. The changes in this CL do not generate any changes to any
vulcanized files.

[Dan Beam, 2017-01-20 21:49:53]

On 2017/01/20 21:06:29, stevenjb wrote:
> On 2017/01/20 20:52:26, Dan Beam (slow - converging) wrote:
> > we run vulcanize.py from reproduce.sh so the functional change happens for
> > downloads / history in this CL.  please don't separate them or edit
generated
> > files (all the .vulcanized or .crisper files)
> 
> I do not understand. The changes in this CL do not generate any changes to any
> vulcanized files.

ah, you said here in a CL published in the same minute that vulcanized files
were created by running reproduce.sh:
https://codereview.chromium.org/2641123007/

so you're saying that paper-slider is not used on downloads or history?  I
figured when you changed paper-slider, downloads and history used it somehow and
had to be updated.  does only settings use paper-slider?

[stevenjb, 2017-01-20 22:01:00]

When I first made this change I saw some unrelated side effects, so I
re-ran reproduce.sh in a master checkout and generated a separate CL for
that: https://codereview.chromium.org/2641123007/

This CL is chained off of that, but doesn't actually depend on it, except
that it confirms that updating paper-slider does not impact the
vulcanization of downloads or history after reproduce.sh is run on an
unmodified ToT.




On Fri, Jan 20, 2017 at 2:49 PM, <dbeam@chromium.org> wrote:

> On 2017/01/20 21:06:29, stevenjb wrote:
> > On 2017/01/20 20:52:26, Dan Beam (slow - converging) wrote:
> > > we run vulcanize.py from reproduce.sh so the functional change happens
> for
> > > downloads / history in this CL. please don't separate them or edit
> generated
> > > files (all the .vulcanized or .crisper files)
> >
> > I do not understand. The changes in this CL do not generate any changes
> to any
> > vulcanized files.
>
> ah, you said here in a CL published in the same minute that vulcanized
> files
> were created by running reproduce.sh:
> https://codereview.chromium.org/2641123007/
>
> so you're saying that paper-slider is not used on downloads or history? I
> figured when you changed paper-slider, downloads and history used it
> somehow and
> had to be updated. does only settings use paper-slider?
>
> https://codereview.chromium.org/2646943003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dpapad, 2017-01-20 22:21:47]

dpapad@chromium.org changed reviewers:
- dpapad@chromium.org

[dpapad, 2017-01-20 22:22:29]

Removing myself since dbeam is already looking at this.

[stevenjb, 2017-01-20 23:22:20]

dpapad@ pointed out that I just missed ToT fixes to the vulcanized files, so
rebased and closed the dependent CL.

[stevenjb, 2017-01-20 23:22:42]

(PTAL)

[Dan Beam, 2017-01-21 00:50:10]

lgtm

[stevenjb, 2017-01-21 00:51:08]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-01-21 00:51:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 02:26:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484959868301900,
"parent_rev": "6e6efc439af07b0d6f11d6fb26ed6900c9a94e7a", "commit_rev":
"a2bec78f3efa4fe7e9766938c606367df553070f"}

[commit-bot: I haz the power, 2017-01-21 02:26:41]

Description was changed from

==========
Polymer: roll paper-slider, 1.0.11 -> 1.0.13

Primarily this picks up a fix to preven arrow keys from scrolling
the page when used with a paper slider focused.

BUG=675393
==========

to

==========
Polymer: roll paper-slider, 1.0.11 -> 1.0.13

Primarily this picks up a fix to preven arrow keys from scrolling
the page when used with a paper slider focused.

BUG=675393

Review-Url: https://codereview.chromium.org/2646943003
Cr-Commit-Position: refs/heads/master@{#445254}
Committed:
https://chromium.googlesource.com/chromium/src/+/a2bec78f3efa4fe7e9766938c606...
==========

[commit-bot: I haz the power, 2017-01-21 02:26:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a2bec78f3efa4fe7e9766938c606...