Implements CSSPropertyAPI for letter and word spacing

Implements CSSPropertyAPI for letter and word spacing

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyLetterSpacing, and CSSPropertyWordSpacing from the switch
statement in parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for
the letter and word spacing properties is stored in a
CSSPropertyDescriptor, and is called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPILetterAndWordSpacing.cpp to the BUILD.gn file.
- Adds api_class=CSSPropertyAPILetterAndWordSpacing flag to each border
  class property in CSSProperties.in, which indicates that
  CSSPropertyAPILetterAndWordSpacing.h is generated.
- Moves the parsing logic for letter and word spacing from  
  CSSPropertyParser.cpp to CSSPropertyAPILetterAndWordSpacing.cpp, 
  which implements CSSPropertyAPI.h.

BUG=668012
Review-Url: https://codereview.chromium.org/2641083002
Cr-Commit-Position: refs/heads/master@{#444675}
Committed: https://chromium.googlesource.com/chromium/src/+/0006a31fd4a9fcf1b39a099f9a3056856fa8e063

[gracie, 2017-01-19 00:33:10]

Description was changed from

==========
Implements CSSPrpertyAPI for letter and word spacing

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyLetterSpacing, and CSSPropertyWordSpacing from the switch
statement in parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
letter and word spacing properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPILetterAndWordSpacing.cpp to the BUILD.gn file.
- Adds api_class=CSSPropertyAPILetterAndWordSpacing flag to each border class
  property in CSSProperties.in, which indicates that
  CSSPropertyAPILetterAndWordSpacing.h is generated.
- Moves the parsing logic for letter and word spacing from CSSPropertyParser.cpp
  to CSSPropertyAPILetterAndWordSpacing.cpp, which implements CSSPropertyAPI.h.

BUG=
==========

to

==========
Implements CSSPropertyAPI for letter and word spacing

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyLetterSpacing, and CSSPropertyWordSpacing from the switch
statement in parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
letter and word spacing properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPILetterAndWordSpacing.cpp to the BUILD.gn file.
- Adds api_class=CSSPropertyAPILetterAndWordSpacing flag to each border class
  property in CSSProperties.in, which indicates that
  CSSPropertyAPILetterAndWordSpacing.h is generated.
- Moves the parsing logic for letter and word spacing from CSSPropertyParser.cpp
  to CSSPropertyAPILetterAndWordSpacing.cpp, which implements CSSPropertyAPI.h.

BUG=
==========

[gracie, 2017-01-19 00:33:57]

Description was changed from

==========
Implements CSSPropertyAPI for letter and word spacing

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyLetterSpacing, and CSSPropertyWordSpacing from the switch
statement in parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
letter and word spacing properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPILetterAndWordSpacing.cpp to the BUILD.gn file.
- Adds api_class=CSSPropertyAPILetterAndWordSpacing flag to each border class
  property in CSSProperties.in, which indicates that
  CSSPropertyAPILetterAndWordSpacing.h is generated.
- Moves the parsing logic for letter and word spacing from CSSPropertyParser.cpp
  to CSSPropertyAPILetterAndWordSpacing.cpp, which implements CSSPropertyAPI.h.

BUG=
==========

to

==========
Implements CSSPropertyAPI for letter and word spacing

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyLetterSpacing, and CSSPropertyWordSpacing from the switch
statement in parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
letter and word spacing properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPILetterAndWordSpacing.cpp to the BUILD.gn file.
- Adds api_class=CSSPropertyAPILetterAndWordSpacing flag to each border class
  property in CSSProperties.in, which indicates that
  CSSPropertyAPILetterAndWordSpacing.h is generated.
- Moves the parsing logic for letter and word spacing from CSSPropertyParser.cpp
  to CSSPropertyAPILetterAndWordSpacing.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

[gracie, 2017-01-19 00:34:41]

gracec@chromium.org changed reviewers:
+ aazzam@google.com

[aazzam, 2017-01-19 00:35:43]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[aazzam, 2017-01-19 00:35:44]

thanks grace!! lgtm, ptal sasha :)

[sashab, 2017-01-19 00:47:24]

LGTM pending anna's approval on the naming convention :)

https://codereview.chromium.org/2641083002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyAPILetterAndWordSpacing.cpp
(right):

https://codereview.chromium.org/2641083002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPILetterAndWordSpacing.cpp:12:
const CSSValue* CSSPropertyAPILetterAndWordSpacing::parseSingleValue(
Anna -- do we have a convention around names for these, i.e. should this end
with the word 'Group'? The other one I'm looking at is Naina's patch which calls
it 'CSSPropertyAPIBoxGroup' (https://codereview.chromium.org/2639303004)

[sashab, 2017-01-19 00:47:37]

Oh sorry also please wrap CL description to 72 chars :) thanks

[gracie, 2017-01-19 02:48:41]

Description was changed from

==========
Implements CSSPropertyAPI for letter and word spacing

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyLetterSpacing, and CSSPropertyWordSpacing from the switch
statement in parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
letter and word spacing properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPILetterAndWordSpacing.cpp to the BUILD.gn file.
- Adds api_class=CSSPropertyAPILetterAndWordSpacing flag to each border class
  property in CSSProperties.in, which indicates that
  CSSPropertyAPILetterAndWordSpacing.h is generated.
- Moves the parsing logic for letter and word spacing from CSSPropertyParser.cpp
  to CSSPropertyAPILetterAndWordSpacing.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for letter and word spacing

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyLetterSpacing, and CSSPropertyWordSpacing from the switch
statement in parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for
the letter and word spacing properties is stored in a
CSSPropertyDescriptor, and is called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPILetterAndWordSpacing.cpp to the BUILD.gn file.
- Adds api_class=CSSPropertyAPILetterAndWordSpacing flag to each border
  class property in CSSProperties.in, which indicates that
  CSSPropertyAPILetterAndWordSpacing.h is generated.
- Moves the parsing logic for letter and word spacing from  
  CSSPropertyParser.cpp to CSSPropertyAPILetterAndWordSpacing.cpp, 
  which implements CSSPropertyAPI.h.

BUG=668012
==========

[gracie, 2017-01-19 02:50:13]

On 2017/01/19 00:47:37, sashab wrote:
> Oh sorry also please wrap CL description to 72 chars :) thanks

Fixed the CL description and Anna has confirmed that this is the right naming
convention as specified in
https://docs.google.com/spreadsheets/d/1Ba3oAOZXIMUjMepzeW-eY2HtxJYWwvuHDHELc...

[gracie, 2017-01-19 02:50:34]

The CQ bit was checked by gracec@chromium.org

[commit-bot: I haz the power, 2017-01-19 02:51:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 04:48:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 04:49:01]

Failed to apply patch for third_party/WebKit/Source/core/css/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/core/css/BUILD.gn:351
  error: third_party/WebKit/Source/core/css/BUILD.gn: patch does not apply

Patch:       third_party/WebKit/Source/core/css/BUILD.gn
Index: third_party/WebKit/Source/core/css/BUILD.gn
diff --git a/third_party/WebKit/Source/core/css/BUILD.gn
b/third_party/WebKit/Source/core/css/BUILD.gn
index
231a6b0cd7fc56ae57cd489cafe91f2f0d15a1c8..9b408bb18cf6354ae019a44abb5af0e2148956a0
100644
--- a/third_party/WebKit/Source/core/css/BUILD.gn
+++ b/third_party/WebKit/Source/core/css/BUILD.gn
@@ -351,6 +351,7 @@ blink_core_sources("css") {
     "properties/CSSPropertyAPIFlexBasis.cpp",
     "properties/CSSPropertyAPIFontSizeAdjust.cpp",
     "properties/CSSPropertyAPIFontVariationSettings.cpp",
+    "properties/CSSPropertyAPILetterAndWordSpacing.cpp",
     "properties/CSSPropertyAPIOffsetPosition.cpp",
     "properties/CSSPropertyAPIOutlineOffset.cpp",
     "properties/CSSPropertyAPIPage.cpp",

[gracie, 2017-01-19 05:49:13]

The CQ bit was checked by gracec@chromium.org

[gracie, 2017-01-19 05:49:13]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
aazzam@google.com
Link to the patchset: https://codereview.chromium.org/2641083002/#ps20001
(title: "rebase update")

[commit-bot: I haz the power, 2017-01-19 05:49:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 07:40:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484804953477780,
"parent_rev": "29276c3a4db55690390a4a2c7d072f21cd7b34d9", "commit_rev":
"0006a31fd4a9fcf1b39a099f9a3056856fa8e063"}

[commit-bot: I haz the power, 2017-01-19 07:41:24]

Description was changed from

==========
Implements CSSPropertyAPI for letter and word spacing

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyLetterSpacing, and CSSPropertyWordSpacing from the switch
statement in parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for
the letter and word spacing properties is stored in a
CSSPropertyDescriptor, and is called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPILetterAndWordSpacing.cpp to the BUILD.gn file.
- Adds api_class=CSSPropertyAPILetterAndWordSpacing flag to each border
  class property in CSSProperties.in, which indicates that
  CSSPropertyAPILetterAndWordSpacing.h is generated.
- Moves the parsing logic for letter and word spacing from  
  CSSPropertyParser.cpp to CSSPropertyAPILetterAndWordSpacing.cpp, 
  which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for letter and word spacing

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyLetterSpacing, and CSSPropertyWordSpacing from the switch
statement in parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for
the letter and word spacing properties is stored in a
CSSPropertyDescriptor, and is called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPILetterAndWordSpacing.cpp to the BUILD.gn file.
- Adds api_class=CSSPropertyAPILetterAndWordSpacing flag to each border
  class property in CSSProperties.in, which indicates that
  CSSPropertyAPILetterAndWordSpacing.h is generated.
- Moves the parsing logic for letter and word spacing from  
  CSSPropertyParser.cpp to CSSPropertyAPILetterAndWordSpacing.cpp, 
  which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2641083002
Cr-Commit-Position: refs/heads/master@{#444675}
Committed:
https://chromium.googlesource.com/chromium/src/+/0006a31fd4a9fcf1b39a099f9a30...
==========

[commit-bot: I haz the power, 2017-01-19 07:41:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0006a31fd4a9fcf1b39a099f9a30...