Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2641073004: Revert of [headless] Fix screenshots with gpu enabled. (Closed)

Created:
3 years, 11 months ago by Mike West
Modified:
3 years, 11 months ago
CC:
chromium-reviews, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [headless] Fix screenshots with gpu enabled. (patchset #5 id:100001 of https://codereview.chromium.org/2631263003/ ) Reason for revert: HeadlessWebContentsSecurityTest.RunAsyncTest is failing: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/51027/steps/headless_browsertests/logs/HeadlessWebContentsSecurityTest.RunAsyncTest Started in https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/51027/. This is the only patch in the build that touches headless, so... BUG=682670 Original issue's description: > [headless] Fix screenshots with gpu enabled. > > Turns out this is due to two things: > 1) We were overriding ShouldCreateCompositorFrameSink in the browser > compositor to always return false (which is unnecessary). > 2) Contrary to what GpuBrowserCompositorOutputSurface and > SoftwareBrowserCompositorOutputSurface do, the > OffscreenBrowserCompositorOutputSurface wasn't letting the RWHI know > about swapped frames. > > This fixes both issues. > > BUG=681614 > > Review-Url: https://codereview.chromium.org/2631263003 > Cr-Commit-Position: refs/heads/master@{#444694} > Committed: https://chromium.googlesource.com/chromium/src/+/f5077ffe4f7a3d8c053e8bd8b2070bc699ca937f TBR=skyostil@chromium.org,jbauman@chromium.org,bsalomon@google.com,eseckler@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=681614 Review-Url: https://codereview.chromium.org/2641073004 Cr-Commit-Position: refs/heads/master@{#444720} Committed: https://chromium.googlesource.com/chromium/src/+/5466789f07c47118956eaca0a9baf4f35b02737b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -71 lines) Patch
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/compositor/offscreen_browser_compositor_output_surface.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/compositor/offscreen_browser_compositor_output_surface.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M headless/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D headless/lib/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
M headless/lib/headless_web_contents_browsertest.cc View 4 chunks +3 lines, -53 lines 0 comments Download
M headless/test/headless_browser_test.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Mike West
Created Revert of [headless] Fix screenshots with gpu enabled.
3 years, 11 months ago (2017-01-19 13:37:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641073004/1
3 years, 11 months ago (2017-01-19 13:37:37 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 13:38:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5466789f07c47118956eaca0a9ba...

Powered by Google App Engine
This is Rietveld 408576698