Chromium Code Reviews
DescriptionRevert of [headless] Fix screenshots with gpu enabled. (patchset #5 id:100001 of https://codereview.chromium.org/2631263003/ )
Reason for revert:
HeadlessWebContentsSecurityTest.RunAsyncTest is failing: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/51027/steps/headless_browsertests/logs/HeadlessWebContentsSecurityTest.RunAsyncTest
Started in https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/51027/. This is the only patch in the build that touches headless, so...
BUG=682670
Original issue's description:
> [headless] Fix screenshots with gpu enabled.
>
> Turns out this is due to two things:
> 1) We were overriding ShouldCreateCompositorFrameSink in the browser
> compositor to always return false (which is unnecessary).
> 2) Contrary to what GpuBrowserCompositorOutputSurface and
> SoftwareBrowserCompositorOutputSurface do, the
> OffscreenBrowserCompositorOutputSurface wasn't letting the RWHI know
> about swapped frames.
>
> This fixes both issues.
>
> BUG=681614
>
> Review-Url: https://codereview.chromium.org/2631263003
> Cr-Commit-Position: refs/heads/master@{#444694}
> Committed: https://chromium.googlesource.com/chromium/src/+/f5077ffe4f7a3d8c053e8bd8b2070bc699ca937f
TBR=skyostil@chromium.org,jbauman@chromium.org,bsalomon@google.com,eseckler@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=681614
Review-Url: https://codereview.chromium.org/2641073004
Cr-Commit-Position: refs/heads/master@{#444720}
Committed: https://chromium.googlesource.com/chromium/src/+/5466789f07c47118956eaca0a9baf4f35b02737b
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||