[headless] Fix screenshots with gpu enabled.

[headless] Fix screenshots with gpu enabled.

Turns out this is due to two things:
1) We were overriding ShouldCreateCompositorFrameSink in the browser
   compositor to always return false (which is unnecessary).
2) Contrary to what GpuBrowserCompositorOutputSurface and
   SoftwareBrowserCompositorOutputSurface do, the
   OffscreenBrowserCompositorOutputSurface wasn't letting the RWHI know
   about swapped frames.

This fixes both issues.

BUG=681614
Review-Url: https://codereview.chromium.org/2631263003
Cr-Original-Commit-Position: refs/heads/master@{#444694}
Committed: https://chromium.googlesource.com/chromium/src/+/f5077ffe4f7a3d8c053e8bd8b2070bc699ca937f
Review-Url: https://codereview.chromium.org/2631263003
Cr-Commit-Position: refs/heads/master@{#444730}
Committed: https://chromium.googlesource.com/chromium/src/+/d2869ffcce7a030d6cceabb6f52d3c67f897e06a

[Eric Seckler, 2017-01-17 13:13:23]

Patchset #1 (id:1) has been deleted

[Eric Seckler, 2017-01-17 13:13:32]

The CQ bit was checked by eseckler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 13:13:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Seckler, 2017-01-18 12:13:07]

The CQ bit was checked by eseckler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 12:13:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Seckler, 2017-01-18 12:48:40]

eseckler@chromium.org changed reviewers:
+ jbauman@chromium.org, skyostil@chromium.org

[Eric Seckler, 2017-01-18 12:48:41]

Sami, PTAL.

+John for content/browser/compositor.

Thanks!

[Eric Seckler, 2017-01-18 12:55:53]

eseckler@chromium.org changed reviewers:
+ bsalomon@google.com

[Eric Seckler, 2017-01-18 12:55:53]

+bsalomon for dependency on third_party/skia/include.

[commit-bot: I haz the power, 2017-01-18 13:00:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 13:00:13]

Dry run: This issue passed the CQ dry run.

[Sami, 2017-01-18 13:57:37]

Thanks! headless/ lgtm (other parts too as far as I can tell.)

https://codereview.chromium.org/2631263003/diff/60001/headless/lib/headless_w...
File headless/lib/headless_web_contents_browsertest.cc (right):

https://codereview.chromium.org/2631263003/diff/60001/headless/lib/headless_w...
headless/lib/headless_web_contents_browsertest.cc:69: return
gfx::PNGCodec::Decode(
FWIW there's also a non-SkBitmap version of this function. It's probably fine
for headless clients to depend on Skia, but it's worth noting that it's yet
another potentially changing API.

[bsalomon, 2017-01-18 14:28:01]

lgtm

[Eric Seckler, 2017-01-18 19:22:51]

https://codereview.chromium.org/2631263003/diff/60001/headless/lib/headless_w...
File headless/lib/headless_web_contents_browsertest.cc (right):

https://codereview.chromium.org/2631263003/diff/60001/headless/lib/headless_w...
headless/lib/headless_web_contents_browsertest.cc:69: return
gfx::PNGCodec::Decode(
On 2017/01/18 13:57:37, Sami wrote:
> FWIW there's also a non-SkBitmap version of this function. It's probably fine
> for headless clients to depend on Skia, but it's worth noting that it's yet
> another potentially changing API.

Limited the DEP to the test file only to avoid 
enabling public APIs to incorporate skia types.

[jbauman, 2017-01-19 00:18:06]

lgtm

[Eric Seckler, 2017-01-19 09:08:03]

The CQ bit was checked by eseckler@chromium.org

[Eric Seckler, 2017-01-19 09:08:04]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com,
skyostil@chromium.org, jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2631263003/#ps100001
(title: "add skia dep to build file.")

[commit-bot: I haz the power, 2017-01-19 09:08:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 10:13:34]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484816883903100,
"parent_rev": "ecb7bd1cd2294ead17cb71265c98a9574dd5f342", "commit_rev":
"f5077ffe4f7a3d8c053e8bd8b2070bc699ca937f"}

[commit-bot: I haz the power, 2017-01-19 10:14:02]

Description was changed from

==========
[headless] Fix screenshots with gpu enabled.

Turns out this is due to two things:
1) We were overriding ShouldCreateCompositorFrameSink in the browser
   compositor to always return false (which is unnecessary).
2) Contrary to what GpuBrowserCompositorOutputSurface and
   SoftwareBrowserCompositorOutputSurface do, the
   OffscreenBrowserCompositorOutputSurface wasn't letting the RWHI know
   about swapped frames.

This fixes both issues.

BUG=681614
==========

to

==========
[headless] Fix screenshots with gpu enabled.

Turns out this is due to two things:
1) We were overriding ShouldCreateCompositorFrameSink in the browser
   compositor to always return false (which is unnecessary).
2) Contrary to what GpuBrowserCompositorOutputSurface and
   SoftwareBrowserCompositorOutputSurface do, the
   OffscreenBrowserCompositorOutputSurface wasn't letting the RWHI know
   about swapped frames.

This fixes both issues.

BUG=681614

Review-Url: https://codereview.chromium.org/2631263003
Cr-Commit-Position: refs/heads/master@{#444694}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5077ffe4f7a3d8c053e8bd8b207...
==========

[commit-bot: I haz the power, 2017-01-19 10:14:03]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/f5077ffe4f7a3d8c053e8bd8b207...

[Mike West, 2017-01-19 13:37:24]

A revert of this CL (patchset #5 id:100001) has been created in
https://codereview.chromium.org/2641073004/ by mkwst@chromium.org.

The reason for reverting is: HeadlessWebContentsSecurityTest.RunAsyncTest is
failing:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/510...

Started in
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/51027/.
This is the only patch in the build that touches headless, so...

BUG=682670.

[Eric Seckler, 2017-01-19 14:41:53]

On 2017/01/19 13:37:24, Mike West (sloooooow) wrote:
> A revert of this CL (patchset #5 id:100001) has been created in
> https://codereview.chromium.org/2641073004/ by mailto:mkwst@chromium.org.
> 
> The reason for reverting is: HeadlessWebContentsSecurityTest.RunAsyncTest is
> failing:
>
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/510...
> 
> Started in
>
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/51027/.
> This is the only patch in the build that touches headless, so...
> 
> BUG=682670.

relanding, now that https://codereview.chromium.org/2645683005/ has fixed the
issue with the test...

[Eric Seckler, 2017-01-19 14:42:07]

Description was changed from

==========
[headless] Fix screenshots with gpu enabled.

Turns out this is due to two things:
1) We were overriding ShouldCreateCompositorFrameSink in the browser
   compositor to always return false (which is unnecessary).
2) Contrary to what GpuBrowserCompositorOutputSurface and
   SoftwareBrowserCompositorOutputSurface do, the
   OffscreenBrowserCompositorOutputSurface wasn't letting the RWHI know
   about swapped frames.

This fixes both issues.

BUG=681614

Review-Url: https://codereview.chromium.org/2631263003
Cr-Commit-Position: refs/heads/master@{#444694}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5077ffe4f7a3d8c053e8bd8b207...
==========

to

==========
[headless] Fix screenshots with gpu enabled.

Turns out this is due to two things:
1) We were overriding ShouldCreateCompositorFrameSink in the browser
   compositor to always return false (which is unnecessary).
2) Contrary to what GpuBrowserCompositorOutputSurface and
   SoftwareBrowserCompositorOutputSurface do, the
   OffscreenBrowserCompositorOutputSurface wasn't letting the RWHI know
   about swapped frames.

This fixes both issues.

BUG=681614

Review-Url: https://codereview.chromium.org/2631263003
Cr-Commit-Position: refs/heads/master@{#444694}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5077ffe4f7a3d8c053e8bd8b207...
==========

[Eric Seckler, 2017-01-19 14:42:13]

The CQ bit was checked by eseckler@chromium.org

[commit-bot: I haz the power, 2017-01-19 14:42:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 14:46:25]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484836933313990,
"parent_rev": "d377f2d2230bc9302eca1f725e919b3b6a4305f1", "commit_rev":
"d2869ffcce7a030d6cceabb6f52d3c67f897e06a"}

[commit-bot: I haz the power, 2017-01-19 14:46:56]

Description was changed from

==========
[headless] Fix screenshots with gpu enabled.

Turns out this is due to two things:
1) We were overriding ShouldCreateCompositorFrameSink in the browser
   compositor to always return false (which is unnecessary).
2) Contrary to what GpuBrowserCompositorOutputSurface and
   SoftwareBrowserCompositorOutputSurface do, the
   OffscreenBrowserCompositorOutputSurface wasn't letting the RWHI know
   about swapped frames.

This fixes both issues.

BUG=681614

Review-Url: https://codereview.chromium.org/2631263003
Cr-Commit-Position: refs/heads/master@{#444694}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5077ffe4f7a3d8c053e8bd8b207...
==========

to

==========
[headless] Fix screenshots with gpu enabled.

Turns out this is due to two things:
1) We were overriding ShouldCreateCompositorFrameSink in the browser
   compositor to always return false (which is unnecessary).
2) Contrary to what GpuBrowserCompositorOutputSurface and
   SoftwareBrowserCompositorOutputSurface do, the
   OffscreenBrowserCompositorOutputSurface wasn't letting the RWHI know
   about swapped frames.

This fixes both issues.

BUG=681614

Review-Url: https://codereview.chromium.org/2631263003
Cr-Original-Commit-Position: refs/heads/master@{#444694}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5077ffe4f7a3d8c053e8bd8b207...
Review-Url: https://codereview.chromium.org/2631263003
Cr-Commit-Position: refs/heads/master@{#444730}
Committed:
https://chromium.googlesource.com/chromium/src/+/d2869ffcce7a030d6cceabb6f52d...
==========

[commit-bot: I haz the power, 2017-01-19 14:46:57]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/d2869ffcce7a030d6cceabb6f52d...